From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D667C433FE for ; Wed, 6 Oct 2021 21:32:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 98C3D611C1 for ; Wed, 6 Oct 2021 21:32:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 98C3D611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 33B686B006C; Wed, 6 Oct 2021 17:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EB75900003; Wed, 6 Oct 2021 17:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DA9C900002; Wed, 6 Oct 2021 17:32:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 10A056B006C for ; Wed, 6 Oct 2021 17:32:26 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CA47E39B29 for ; Wed, 6 Oct 2021 21:32:25 +0000 (UTC) X-FDA: 78667311450.40.1836D3F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 3627F1002196 for ; Wed, 6 Oct 2021 21:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=6m+HOLtIGRYfM6J5PYZs3JgnY5b6/ZoAnBR86sWEAgo=; b=F1fxSx3EZhvdv+VChR3eF+tXny lwpw5rR99hKW2Q/EWjJ2czVgQWT3k16IZzHvQYwY63Q+YQ23rVDG4B6WGklna1btXO/dNc0XmK43s xvGlbnNE2xFRqklTxl4MjcgXTYhMm0DPIerZ89+x8+gPkKdqm4wyQ5HfR2kpjI91bajjpWX53FU7f Kl8iy1/CjGg/ctF/hletub3XgRIy23JWxm5vulwNzUK/wJ/qrVfrtJXUVKlLweqIbw7ByPTPqlKIf f/wNLiyDDTRvMbKG359Wd2wa196B32crSPrImazHMag8KMM9dFUJxpGyO1ydrvO2iBV1qI++pPjwc Py3tLOqQ==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYEWU-00FbpY-6B; Wed, 06 Oct 2021 21:32:22 +0000 Subject: Re: linux-next: Tree for Oct 5 (warnings: a. trace; b. mm/migrate) To: Steven Rostedt Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-mm@kvack.org, Andrew Morton References: <20211005190628.1f26b13d@canb.auug.org.au> <20211006172207.11982951@gandalf.local.home> From: Randy Dunlap Message-ID: <6d8f22a1-5f54-aa2a-7628-1d98a7f0fb95@infradead.org> Date: Wed, 6 Oct 2021 14:32:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211006172207.11982951@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3627F1002196 X-Stat-Signature: 69ozg9kn15dqgtx3x1u3kykrm1jzk61t Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=F1fxSx3E; spf=none (imf12.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-HE-Tag: 1633555945-926462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/6/21 2:22 PM, Steven Rostedt wrote: > On Tue, 5 Oct 2021 13:46:52 -0700 > Randy Dunlap wrote: > >> a. randconfig: KCONFIG_SEED=0xBFBEA13C >> ../kernel/trace/trace.c:1712:13: error: 'trace_create_maxlat_file' defined but not used [-Werror=unused-function] >> static void trace_create_maxlat_file(struct trace_array *tr, > > Does this fix it? > > -- Steve Yes, thanks. Acked-by: Randy Dunlap # build-tested > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 7896d30d90f7..4520cbab0da5 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -1744,16 +1744,15 @@ void latency_fsnotify(struct trace_array *tr) > irq_work_queue(&tr->fsnotify_irqwork); > } > > -/* > - * (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)) && \ > - * defined(CONFIG_FSNOTIFY) > - */ > -#else > +/* CONFIG_FSNOTIFY else */ > +#elif CREATE_MAX_TRACE_FILE > > #define trace_create_maxlat_file(tr, d_tracer) \ > trace_create_file("tracing_max_latency", 0644, d_tracer, \ > &tr->max_latency, &tracing_max_lat_fops) > > +#else > +#define trace_create_maxlat_file(tr, d_tracer) do { } while (0) > #endif > > #ifdef CONFIG_TRACER_MAX_TRACE > @@ -9473,9 +9472,7 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer) > > create_trace_options_dir(tr); > > -#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) > trace_create_maxlat_file(tr, d_tracer); > -#endif > > if (ftrace_create_function_files(tr, d_tracer)) > MEM_FAIL(1, "Could not allocate function filter files"); > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index b7c0f8e160fb..680935949aef 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -679,8 +679,11 @@ void update_max_tr_single(struct trace_array *tr, > #endif /* CONFIG_TRACER_MAX_TRACE */ > > #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ > - || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY) > -#define LATENCY_FS_NOTIFY > + || defined(CONFIG_OSNOISE_TRACER)) > +# define CREATE_MAX_TRACE_FILE > +# ifdef CONFIG_FSNOTIFY > +# define LATENCY_FS_NOTIFY > +# endif > #endif > > #ifdef LATENCY_FS_NOTIFY > -- ~Randy