From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573B4C388F7 for ; Fri, 6 Nov 2020 00:51:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9959420665 for ; Fri, 6 Nov 2020 00:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9959420665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90EBD6B01F8; Thu, 5 Nov 2020 19:51:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BF4B6B01F9; Thu, 5 Nov 2020 19:51:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ADA76B01FA; Thu, 5 Nov 2020 19:51:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 4F9296B01F8 for ; Thu, 5 Nov 2020 19:51:19 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E6D1D8249980 for ; Fri, 6 Nov 2020 00:51:18 +0000 (UTC) X-FDA: 77452164636.25.lead90_1d02ee2272ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id B73611804E3A1 for ; Fri, 6 Nov 2020 00:51:18 +0000 (UTC) X-HE-Tag: lead90_1d02ee2272ce X-Filterd-Recvd-Size: 2731 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 00:51:17 +0000 (UTC) IronPort-SDR: 5+bfECSQYnLpj+vF3wlUVU1hRwfbJTLjku0rHrMYUpej04Fpt1AI5B6CKBvo//E8PXSjPMsK3e qGIKAL2ZhqYg== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="187399206" X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="187399206" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 16:51:16 -0800 IronPort-SDR: cBu0zcFDrl7nR9U7wGjB7/jIKSj4rCzXvR2hg/7w2N38dKsuju3onmQofvyo8KeftidVwFl6Rn T8+lnDjwqsrA== X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="354511338" Received: from schen9-mobl.amr.corp.intel.com ([10.254.99.119]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 16:51:15 -0800 Subject: Re: [PATCH 0/2] Increase the size of LRU pagevecs To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Jan Kara References: <20201105172651.2455-1-willy@infradead.org> From: Tim Chen Message-ID: <6e91d4c1-d1fc-63ad-4ca5-261ad89d50e4@linux.intel.com> Date: Thu, 5 Nov 2020 16:51:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201105172651.2455-1-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/5/20 9:26 AM, Matthew Wilcox (Oracle) wrote: > This attempts to address some of the criticisms of Tim's original > patch back in June: > > https://lore.kernel.org/linux-mm/d1cc9f12a8ad6c2a52cb600d93b06b064f2bbc57.1593205965.git.tim.c.chen@linux.intel.com/ > > I don't love how messy this is. I actually attempted a similar patch to allocate different sizes for pagevec. But it is so ugly that I didn't try to post it. This version looks much better than mine. Tim > Better suggestions (dynamic allocation of > pagevecs?) welcome. It'd be even better if we could measure contention > and resize the LRUvecs on demand. > > I do intend to add pagevec_alloc() and pagevec_free(), but that's to > solve a different problem. > > Matthew Wilcox (Oracle) (2): > pagevec: Allow pagevecs to be different sizes > pagevec: Increase the size of LRU pagevecs > > include/linux/pagevec.h | 25 +++++++++++++++++++++---- > mm/swap.c | 23 +++++++++++++++++------ > 2 files changed, 38 insertions(+), 10 deletions(-) >