From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499B2C433B4 for ; Mon, 12 Apr 2021 14:08:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C242E6121E for ; Mon, 12 Apr 2021 14:08:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C242E6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C30C6B0071; Mon, 12 Apr 2021 10:08:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 371536B0072; Mon, 12 Apr 2021 10:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19DAF6B0073; Mon, 12 Apr 2021 10:08:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id F000C6B0071 for ; Mon, 12 Apr 2021 10:08:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A7DF08248D7C for ; Mon, 12 Apr 2021 14:08:17 +0000 (UTC) X-FDA: 78023894634.01.F710999 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id DAAC7600010E for ; Mon, 12 Apr 2021 14:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618236496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTcpSq1zGOhEeBa9hsl3KO1A3Uftt0XI2Pr0NmWLNbI=; b=fE8UzTneZk4j9U1Cu2Y6XdwxYolCBxfu3xiJJNnYckQWq561DzSzV+RlD0jqnLef9ooQrH dFEsBotmfyH8t7BTJgLU53VJi8vmNMyaYD7FqPaGLO0wAe7FCvpxrgP3JVuyf9qiQLLaAf ahQC0F0jWmxlwpV9UqXLN3+Sk17peSI= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-v1N2VAuaN-SyBZ99h-ArTQ-1; Mon, 12 Apr 2021 10:08:01 -0400 X-MC-Unique: v1N2VAuaN-SyBZ99h-ArTQ-1 Received: by mail-qk1-f199.google.com with SMTP id p12so3345800qkg.21 for ; Mon, 12 Apr 2021 07:08:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=HTcpSq1zGOhEeBa9hsl3KO1A3Uftt0XI2Pr0NmWLNbI=; b=I7jHm01I6B8vDMu41us263cmtHdqB/yZunYkHWBc8WZF6ZTGTZrXyU/Q7nhM06Lu0X GNZIAZ+bZOADSVmkJRdO2GFVzZGRX4NfxnZnSmjOjLFjtHlPoV9VKP7yeF1F3Eiy2oPO M+3zYWv+p3c/b6eySnfhtQH767+Cy0XE6bVOJQuQl3W8BXDLzIutP8qsPQMFcv8Husx3 Sr666GWvKwvSs8eTaJ8LKUVtRRckN+5QA7F8ZGAOZoXmetH8ylN+imoEvjR5ITytY4z4 8bLif1EoVEpaOielH7bHyjKT10qSIJzQu37HIIFtncgCMzF7/DPE8hiv2uofeLm7QBAC LFLg== X-Gm-Message-State: AOAM532b+CKDJ25nwHn2OFTEHwXgMXfHVvlFaProTOi4KbcJAZ+R1YKC uWjTkpndndX/sED6iZIQMABqbWAVZ+cYVZBA0ecMGlIV1g6GTZBSQ8gS9iFSn+r5FzwTpOhlXuf WoJQhTZTb5BmSv+XLwCsB0CLKQS83qUEJvjKppi7pijvgAE8scn6oqbx+Pkc= X-Received: by 2002:a05:622a:148f:: with SMTP id t15mr25286444qtx.106.1618236479355; Mon, 12 Apr 2021 07:07:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxr0O4E7acAMR6LDOfgLpPjO2teOyQ6l80BWhnx6x380xf49cPIGaibFXUo7eSsplSnRwtvVA== X-Received: by 2002:a05:622a:148f:: with SMTP id t15mr25286405qtx.106.1618236478996; Mon, 12 Apr 2021 07:07:58 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id i5sm1847951qka.126.2021.04.12.07.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 07:07:58 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH 5/5] mm/memcg: Optimize user context object stock access To: kernel test robot , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List References: <20210409231842.8840-6-longman@redhat.com> <202104101336.WgwS18rl-lkp@intel.com> Message-ID: <6eb573b6-313e-6a3b-a37b-1df2ce55c58d@redhat.com> Date: Mon, 12 Apr 2021 10:07:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <202104101336.WgwS18rl-lkp@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=llong@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DAAC7600010E X-Stat-Signature: zwu1ptsqmg474k4jttbzcgcfyzw3g894 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618236494-705280 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/10/21 2:07 AM, kernel test robot wrote: > Hi Waiman, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on dennis-percpu/for-next] > [also build test WARNING on linus/master v5.12-rc6 next-20210409] > [cannot apply to hnaz-linux-mm/master] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Waiman-Long/mm-memcg-Reduce-kmemcache-memory-accounting-overhead/20210410-071958 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu.git for-next > config: arm64-randconfig-r031-20210409 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://github.com/0day-ci/linux/commit/1f4e22fce44599095a55535301ca83adc5d3a4fe > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Waiman-Long/mm-memcg-Reduce-kmemcache-memory-accounting-overhead/20210410-071958 > git checkout 1f4e22fce44599095a55535301ca83adc5d3a4fe > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> mm/memcontrol.c:3234:10: warning: variable 'stock' is uninitialized when used here [-Wuninitialized] > stock = get_obj_stock(flags); > ^~~~~~~~~~~~~~~~~~~~ > mm/memcontrol.c:2284:16: note: expanded from macro 'get_obj_stock' > obj_stock = &stock->task_obj; \ > ^~~~~ > mm/memcontrol.c:3234:10: note: variable 'stock' is declared here > mm/memcontrol.c:2278:2: note: expanded from macro 'get_obj_stock' > struct memcg_stock_pcp *stock; \ > ^ > mm/memcontrol.c:3329:2: warning: variable 'stock' is uninitialized when used here [-Wuninitialized] > get_obj_stock(flags); > ^~~~~~~~~~~~~~~~~~~~ > mm/memcontrol.c:2284:16: note: expanded from macro 'get_obj_stock' > obj_stock = &stock->task_obj; \ > ^~~~~ > mm/memcontrol.c:3329:2: note: variable 'stock' is declared here > mm/memcontrol.c:2278:2: note: expanded from macro 'get_obj_stock' > struct memcg_stock_pcp *stock; \ > ^ > mm/memcontrol.c:3371:2: warning: variable 'stock' is uninitialized when used here [-Wuninitialized] > get_obj_stock(flags); > ^~~~~~~~~~~~~~~~~~~~ > mm/memcontrol.c:2284:16: note: expanded from macro 'get_obj_stock' > obj_stock = &stock->task_obj; \ > ^~~~~ > mm/memcontrol.c:3371:2: note: variable 'stock' is declared here > mm/memcontrol.c:2278:2: note: expanded from macro 'get_obj_stock' > struct memcg_stock_pcp *stock; \ > ^ > mm/memcontrol.c:3426:2: warning: variable 'stock' is uninitialized when used here [-Wuninitialized] > get_obj_stock(flags); > ^~~~~~~~~~~~~~~~~~~~ > mm/memcontrol.c:2284:16: note: expanded from macro 'get_obj_stock' > obj_stock = &stock->task_obj; \ > ^~~~~ > mm/memcontrol.c:3426:2: note: variable 'stock' is declared here > mm/memcontrol.c:2278:2: note: expanded from macro 'get_obj_stock' > struct memcg_stock_pcp *stock; \ > ^ > 4 warnings generated. > > > vim +/stock +3234 mm/memcontrol.c > > 3227 > 3228 static bool consume_obj_stock(struct obj_cgroup *objcg, unsigned int nr_bytes) > 3229 { > 3230 struct obj_stock *stock; > 3231 unsigned long flags; > 3232 bool ret = false; > 3233 >> 3234 stock = get_obj_stock(flags); > 3235 > 3236 stock = current_obj_stock(); > 3237 if (objcg == stock->cached_objcg && stock->nr_bytes >= nr_bytes) { > 3238 stock->nr_bytes -= nr_bytes; > 3239 ret = true; > 3240 } > 3241 > 3242 put_obj_stock(flags); > 3243 > 3244 return ret; > 3245 } > 3246 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org My bad, I somehow missed it. I will fix that in the version. Thanks, Longman