From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BDDECE59E for ; Wed, 16 Oct 2019 05:11:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B90752054F for ; Wed, 16 Oct 2019 05:11:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B90752054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E0F018E0005; Wed, 16 Oct 2019 01:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC0D38E0001; Wed, 16 Oct 2019 01:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD4DF8E0005; Wed, 16 Oct 2019 01:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id A78B68E0001 for ; Wed, 16 Oct 2019 01:11:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 4C9FC824556B for ; Wed, 16 Oct 2019 05:11:09 +0000 (UTC) X-FDA: 76048473858.01.bean03_614fb75733e00 X-HE-Tag: bean03_614fb75733e00 X-Filterd-Recvd-Size: 2425 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 05:11:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C1428B38A; Wed, 16 Oct 2019 05:11:06 +0000 (UTC) Subject: Re: [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER To: Jason Gunthorpe , Felix.Kuehling@amd.com, John Hubbard , Ralph Campbell , Jerome Glisse Cc: Oleksandr Andrushchenko , Stefano Stabellini , linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, Jason Gunthorpe , Boris Ostrovsky , Andrea Arcangeli , Ben Skeggs , linux-rdma@vger.kernel.org References: <20191015181242.8343-1-jgg@ziepe.ca> <20191015181242.8343-9-jgg@ziepe.ca> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6f60f558-20db-1749-044d-a46697258c39@suse.com> Date: Wed, 16 Oct 2019 07:11:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191015181242.8343-9-jgg@ziepe.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.10.19 20:12, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > DMA_SHARED_BUFFER can not be enabled by the user (it represents a library > set in the kernel). The kconfig convention is to use select for such > symbols so they are turned on implicitly when the user enables a kconfig > that needs them. > > Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. > > Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") > Cc: Oleksandr Andrushchenko > Cc: Boris Ostrovsky > Cc: xen-devel@lists.xenproject.org > Cc: Juergen Gross > Cc: Stefano Stabellini > Signed-off-by: Jason Gunthorpe Reviewed-by: Juergen Gross Juergen