From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C19C433F5 for ; Thu, 21 Apr 2022 09:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E503A6B0071; Thu, 21 Apr 2022 05:06:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E00D56B0073; Thu, 21 Apr 2022 05:06:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA1636B0074; Thu, 21 Apr 2022 05:06:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id BB0F86B0071 for ; Thu, 21 Apr 2022 05:06:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9939A26B4E for ; Thu, 21 Apr 2022 09:06:30 +0000 (UTC) X-FDA: 79380305340.30.A2F3822 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id DD78E20028 for ; Thu, 21 Apr 2022 09:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650531989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92MeHe1O2XEwswakE1YC1636cVBjLw+9Sy+IL3NtyVk=; b=OyskmkGBvqm2D1jUs23VQOOBVJhA44Fvr+GPjEDj+S8LBDKwiQIctwUk64ADfbRe9MYlEi U/EqxHVlf93cpSJIN30EBzkKhN8z+/viiUdVqztQ5sEoof7GCu4Kvg0oL0qwJXFAg+xu2g 1Q00hrSD63s84l/VLeqPZu8T/TW/jSo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-c1HfXCETMT-q6NPLEoU38Q-1; Thu, 21 Apr 2022 05:06:27 -0400 X-MC-Unique: c1HfXCETMT-q6NPLEoU38Q-1 Received: by mail-wr1-f71.google.com with SMTP id d16-20020adfa410000000b0020ab103f0daso905188wra.8 for ; Thu, 21 Apr 2022 02:06:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=92MeHe1O2XEwswakE1YC1636cVBjLw+9Sy+IL3NtyVk=; b=2Ad0VHJelbipBp5EL9dBLxqNWkp29njCbGZeeXkv/7mspwhb4Y+2bKTxLoE0UB7b89 qGkvXXEjQnY0614+kmdH5aBkqWC2GXSA3GR0OzdcQhTQeDaPrzxleVx28jKTmj89Larm 9rBT+QZJ0vHcTiSLNf5LBGIlz8qY2Lx2FgnVQLcnKi7RTfA4nm3jUGvgDhZBKBDZ+Efg a9RnZmHdIQvx8GoGwdwf+ZAQc6xYacFR/AGXe5TxN1zUaXDTPbGRyFu4gawqBeOzSDgf t/BRoICpFKSCRfuoFGmN+Klil0GtHjeoSQ26cyDRmguff9o5CwzlXLcfoCKTU8OKZyZY P0zA== X-Gm-Message-State: AOAM533YSP3Fh00dagg8lUJJlBroaB9xZh1bDnmw6xMq5QsK3jwWtY9y moc6maaBcWDRYmvnXVx4bybbKLhxugtO47Iss1fgnt2i2za0/2aCt4qCLdmR1sajiSeNW/PzxWp Nf3mCFld44oE= X-Received: by 2002:a7b:c5d0:0:b0:389:fe85:3d79 with SMTP id n16-20020a7bc5d0000000b00389fe853d79mr7663487wmk.77.1650531986433; Thu, 21 Apr 2022 02:06:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwll6X4aclR/cAp2Q5uSbwuZ7wO3cz51c3cWWvwaJIW1wrvG5E24IeLoGyMjdGjZ/7adpFcg== X-Received: by 2002:a7b:c5d0:0:b0:389:fe85:3d79 with SMTP id n16-20020a7bc5d0000000b00389fe853d79mr7663463wmk.77.1650531986214; Thu, 21 Apr 2022 02:06:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:de00:711b:76af:b335:9b70? (p200300cbc702de00711b76afb3359b70.dip0.t-ipconnect.de. [2003:cb:c702:de00:711b:76af:b335:9b70]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b0037c91e085ddsm1798885wmq.40.2022.04.21.02.06.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 02:06:24 -0700 (PDT) Message-ID: <707ad285-349c-9788-51dc-12f7caf77f11@redhat.com> Date: Thu, 21 Apr 2022 11:06:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v6 1/2] selftests: vm: bring common functions to a new file To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, krisman@collabora.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20220420084036.4101604-1-usama.anjum@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220420084036.4101604-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ciq7xhpgz1wapttmcyjpdnxx9tx69uso X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OyskmkGB; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DD78E20028 X-HE-Tag: 1650531987-609040 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.04.22 10:40, Muhammad Usama Anjum wrote: > Bring common functions to a new file while keeping code as much same as > possible. These functions can be used in the new tests. This helps in > avoiding code duplication. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes in V6: > - Correct header files inclusion > > Changes in V5: > Keep moved code as same as possible > - Updated macros names > - Removed macro used to show bit number of dirty bit, added a comment > instead > - Corrected indentation > --- > tools/testing/selftests/vm/Makefile | 7 +- > tools/testing/selftests/vm/madv_populate.c | 34 +----- > .../selftests/vm/split_huge_page_test.c | 79 +------------ > tools/testing/selftests/vm/vm_util.c | 108 ++++++++++++++++++ > tools/testing/selftests/vm/vm_util.h | 9 ++ > 5 files changed, 124 insertions(+), 113 deletions(-) > create mode 100644 tools/testing/selftests/vm/vm_util.c > create mode 100644 tools/testing/selftests/vm/vm_util.h > > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile > index 5e43f072f5b76..4e68edb26d6b6 100644 > --- a/tools/testing/selftests/vm/Makefile > +++ b/tools/testing/selftests/vm/Makefile > @@ -34,7 +34,7 @@ TEST_GEN_FILES += hugepage-mremap > TEST_GEN_FILES += hugepage-shm > TEST_GEN_FILES += hugepage-vmemmap > TEST_GEN_FILES += khugepaged > -TEST_GEN_FILES += madv_populate > +TEST_GEN_PROGS = madv_populate > TEST_GEN_FILES += map_fixed_noreplace > TEST_GEN_FILES += map_hugetlb > TEST_GEN_FILES += map_populate > @@ -47,7 +47,7 @@ TEST_GEN_FILES += on-fault-limit > TEST_GEN_FILES += thuge-gen > TEST_GEN_FILES += transhuge-stress > TEST_GEN_FILES += userfaultfd > -TEST_GEN_FILES += split_huge_page_test > +TEST_GEN_PROGS += split_huge_page_test > TEST_GEN_FILES += ksm_tests > > ifeq ($(MACHINE),x86_64) > @@ -91,6 +91,9 @@ TEST_FILES := test_vmalloc.sh > KSFT_KHDR_INSTALL := 1 > include ../lib.mk > Acked-by: David Hildenbrand BTW, I realized that my madv_populate test fails when run without softdirty support in the kernel. Eventually we should sense support somehow and skip softdirty tests. Maybe we can sense by writing to some page and then testing if the page is reported as softdirty. If it isn't, we know the kernel doesn't support it (or is extremely buggy :D ). Such a sense check would be common functionality in the helper file as well. -- Thanks, David / dhildenb