From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
broonie@kernel.org, christophe.leroy@c-s.fr,
dan.j.williams@intel.com, dave.hansen@intel.com,
davem@davemloft.net, gerald.schaefer@de.ibm.com,
gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com,
jgg@ziepe.ca, jhogan@kernel.org, keescook@chromium.org,
kirill@shutemov.name, linux@armlinux.org.uk,
mark.rutland@arm.com, mm-commits@vger.kernel.org,
mpe@ellerman.id.au, paul.burton@mips.com, paulus@samba.org,
penguin-kernel@i-love.sakura.ne.jp, peterz@infradead.org,
ralf@linux-mips.org, rppt@linux.vnet.ibm.com,
schowdary@nvidia.com, schwidefsky@de.ibm.com,
Steven.Price@arm.com, tglx@linutronix.de, vbabka@suse.cz,
vgupta@synopsys.com, willy@infradead.org,
yamada.masahiro@socionext.com, linux-mm@kvack.org
Subject: Re: + mm-hugetlb-make-alloc_gigantic_page-available-for-general-use.patch added to -mm tree
Date: Tue, 15 Oct 2019 16:04:42 +0530 [thread overview]
Message-ID: <709199af-c2b9-33df-bbaf-3de9cd6bc39e@arm.com> (raw)
In-Reply-To: <20191015103100.GV317@dhcp22.suse.cz>
On 10/15/2019 04:01 PM, Michal Hocko wrote:
> On Tue 15-10-19 15:27:46, Anshuman Khandual wrote:
>>
>>
>> On 10/14/2019 10:22 PM, Mike Kravetz wrote:
>>> On 10/14/19 6:08 AM, Anshuman Khandual wrote:
>>>> On 10/14/2019 06:30 PM, Michal Hocko wrote:
>>>>>
>>>>> OK, thanks for the clarification. This all means that this patch is not
>>>>> the right approach. If you need a more generic alloc_contig_range then
>>>>> add it to page_alloc.c and make it completely independent on the hugetlb
>>>>> config and the code. Hugetlb allocator can reuse that helper.
>>>
>>> Should we revisit this previous attempt at such an interface?
>>>
>>> https://lkml.org/lkml/2018/4/16/1072
>>>
>>> This looks like another use case.
>>>
>>
>> The current proposal [v6] does not go far enough to unify all callers
>> of alloc_contig_range() looking for contiguous pages of certain size,
>> but instead it just tries not to duplicate HugeTLB gigantic allocation
>> code in the test case for it's purpose.
>
> Please go and extract that functionality to a commonly usable helper.
> Dependency on hugetlb is just ugly as hell.
I did that in V6 and posted some time back. Could you please review that
and let me know if anything needs to be improved.
- Anshuman
next prev parent reply other threads:[~2019-10-15 10:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191011202932.GZoUOoURm%akpm@linux-foundation.org>
2019-10-14 12:17 ` + mm-hugetlb-make-alloc_gigantic_page-available-for-general-use.patch added to -mm tree Michal Hocko
2019-10-14 12:53 ` Anshuman Khandual
2019-10-14 13:00 ` Michal Hocko
2019-10-14 13:08 ` Anshuman Khandual
2019-10-14 13:21 ` Michal Hocko
2019-10-14 16:52 ` Mike Kravetz
2019-10-15 9:57 ` Anshuman Khandual
2019-10-15 10:31 ` Michal Hocko
2019-10-15 10:34 ` Anshuman Khandual [this message]
2019-10-14 20:29 ` Matthew Wilcox
2019-10-15 9:30 ` Anshuman Khandual
2019-10-15 11:24 ` Matthew Wilcox
2019-10-15 11:36 ` Michal Hocko
2019-10-15 12:14 ` Anshuman Khandual
2019-10-16 8:55 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709199af-c2b9-33df-bbaf-3de9cd6bc39e@arm.com \
--to=anshuman.khandual@arm.com \
--cc=Steven.Price@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=davem@davemloft.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jhogan@kernel.org \
--cc=keescook@chromium.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mm-commits@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=schowdary@nvidia.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=vgupta@synopsys.com \
--cc=willy@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).