From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688EFC28D13 for ; Thu, 25 Aug 2022 12:41:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2166940008; Thu, 25 Aug 2022 08:41:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD137940007; Thu, 25 Aug 2022 08:41:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBFB7940008; Thu, 25 Aug 2022 08:41:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BDB0A940007 for ; Thu, 25 Aug 2022 08:41:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9C50EC04B0 for ; Thu, 25 Aug 2022 12:41:22 +0000 (UTC) X-FDA: 79838075604.30.18B59D7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 30A51C0006 for ; Thu, 25 Aug 2022 12:41:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CA5873521B; Thu, 25 Aug 2022 12:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661431280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WE3l8SpbQubCqTnprHNf64iLxlAYZ3VW4URwEZ7dkAw=; b=VgH3AbfITmx6wQMxlWCPSLT0AjNmNISjVeNl2Kcd9py76MswPMmYt/laVniLUjLFRjFEG2 FfQkd9YPrMxxRIYTCBXCQZaWdAUheigYZS8BC4Q4MDthnt+t8h5oLf/Bq6HOGxCdddaF71 JMSg0YPSF4BYgC0tLCuVkIaNG/P9w10= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661431280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WE3l8SpbQubCqTnprHNf64iLxlAYZ3VW4URwEZ7dkAw=; b=CifZsj2JZ8guNd7ZUibwyynfjProtZ7cSFsWiJrBUp2ivGn2gFMUIzdhWcMH4soK8vJK9p Gv2mGY8u5c8KzSBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 98F1713A8E; Thu, 25 Aug 2022 12:41:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1F+bJPBtB2MoGwAAMHmgww (envelope-from ); Thu, 25 Aug 2022 12:41:20 +0000 Message-ID: <71934a8c-4a11-ae26-8c8b-c54f99182e73@suse.cz> Date: Thu, 25 Aug 2022 14:41:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2 5/5] mm/slub: simplify __cmpxchg_double_slab() and slab_[un]lock() Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Rongwei Wang , Christoph Lameter , Joonsoo Kim , David Rientjes , Pekka Enberg , Roman Gushchin , linux-mm@kvack.org, Sebastian Andrzej Siewior , Thomas Gleixner , Mike Galbraith References: <20220823170400.26546-1-vbabka@suse.cz> <20220823170400.26546-6-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661431282; a=rsa-sha256; cv=none; b=GCVLDZB/6Uo6JFA1WXewaLunQ196qhr29xsJMVba+JPUONymAm/KnGHuaO8dKyhckyF6io HHM1xDvtwa79djD2cYLvCOhe5XTk7U9uB8jW+djQqLYLsfIVtRx9QjaW3eYsdOhPCSHSWd f4sx6X04WF8uT8XAkl6kAeNjkvEMJ2M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VgH3AbfI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CifZsj2J; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661431282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WE3l8SpbQubCqTnprHNf64iLxlAYZ3VW4URwEZ7dkAw=; b=OFQ1GFuKgd2YVPe40XMAYv7w3Iioyp0mxh01eOy5lHYXOx2Ksp29bkW1g+DynvIXoGMnPZ oKceEKrGU4TxB7eb4pU7/iN2PjVOOwkeh15IpvQVLvDDL0y+j63VDBHzd2pxrd/VHEp3ts +YkHHJdIumdFEgZ+JYel7XHONT1tpZk= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VgH3AbfI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CifZsj2J; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: he7fb4sqr64huzmmkskr7feima9woaeh X-Rspamd-Queue-Id: 30A51C0006 X-HE-Tag: 1661431282-69317 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/24/22 15:04, Hyeonggon Yoo wrote: > On Tue, Aug 23, 2022 at 07:04:00PM +0200, Vlastimil Babka wrote: >> The PREEMPT_RT specific disabling of irqs in __cmpxchg_double_slab() >> (through slab_[un]lock()) is unnecessary as bit_spin_lock() disables >> preemption and that's sufficient on RT where interrupts are threaded. >> >> That means we no longer need the slab_[un]lock() wrappers, so delete >> them and rename the current __slab_[un]lock() to slab_[un]lock(). >> >> Signed-off-by: Vlastimil Babka >> Acked-by: David Rientjes >> - >> /* >> * Interrupts must be disabled (for the fallback code to work right), typically >> - * by an _irqsave() lock variant. Except on PREEMPT_RT where locks are different >> - * so we disable interrupts as part of slab_[un]lock(). >> + * by an _irqsave() lock variant. Except on PREEMPT_RT where these variants do >> + * not actually disable interrupts. On the other hand the migrate_disable() > > You mean preempt_disable()? I did, thanks for catching it. > migrate_disable() will not be enough. > >> -- >> 2.37.2 > > Otherwise looks good to me. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks!