From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FB4C4338F for ; Wed, 28 Jul 2021 23:54:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B424F6103B for ; Wed, 28 Jul 2021 23:54:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B424F6103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 05B498D0001; Wed, 28 Jul 2021 19:54:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0094E6B005D; Wed, 28 Jul 2021 19:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3A308D0001; Wed, 28 Jul 2021 19:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id CE4856B0036 for ; Wed, 28 Jul 2021 19:54:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8558A231DE for ; Wed, 28 Jul 2021 23:54:04 +0000 (UTC) X-FDA: 78413652408.12.5DA6A89 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 226BFE0085CC for ; Wed, 28 Jul 2021 23:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627516443; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1h6+SGK2Sn0dPBpEs5XgMlwlQ2+yF6kyESThFa4UTD8=; b=R1HsExfcL9sgmzLY368m0/gVBm6lJRKcoEX7tqQ/F0XG4FZNJu0V2eaBnx5Mb9rAc/VV3j zpYWa/tOTQfDOjqekGHuwLPPtnJpuIJXsjE8bcp8kksJEpVPKG0WPDq7aOM6GNsAul+Vir z0In9pXe3fIhPVgk6cttqOZxOftXvYE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-aN550gYzOSiH0LMnfBhrdA-1; Wed, 28 Jul 2021 19:53:59 -0400 X-MC-Unique: aN550gYzOSiH0LMnfBhrdA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F403C101C8B9; Wed, 28 Jul 2021 23:53:57 +0000 (UTC) Received: from [10.64.54.184] (vpn2-54-184.bne.redhat.com [10.64.54.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1471569CBA; Wed, 28 Jul 2021 23:53:52 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v4 06/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests To: Anshuman Khandual , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, gerald.schaefer@linux.ibm.com, aneesh.kumar@linux.ibm.com, christophe.leroy@csgroup.eu, cai@lca.pw, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com References: <20210727061401.592616-1-gshan@redhat.com> <20210727061401.592616-7-gshan@redhat.com> <39de75d2-744a-9194-cbc2-14926b60e68e@arm.com> From: Gavin Shan Message-ID: <7205bb91-4940-e625-1641-210a6ee767c8@redhat.com> Date: Thu, 29 Jul 2021 09:54:06 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <39de75d2-744a-9194-cbc2-14926b60e68e@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 226BFE0085CC Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R1HsExfc; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com X-Stat-Signature: p49w8ta8m7ca1m5xinauq778bszcrf4r X-HE-Tag: 1627516443-489732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, On 7/28/21 9:08 PM, Anshuman Khandual wrote: > On 7/27/21 11:43 AM, Gavin Shan wrote: >> This uses struct pgtable_debug_args in the migration and thp test >> functions. It's notable that the pre-allocated page is used in >> swap_migration_tests() as set_pte_at() is used there. >> >> Signed-off-by: Gavin Shan >> --- >> mm/debug_vm_pgtable.c | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index bc153cad9045..9136195efde3 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -845,7 +845,7 @@ static void __init pmd_swap_tests(struct pgtable_debug_args *args) >> static void __init pmd_swap_tests(struct pgtable_debug_args *args) { } >> #endif /* CONFIG_ARCH_ENABLE_THP_MIGRATION */ >> >> -static void __init swap_migration_tests(void) >> +static void __init swap_migration_tests(struct pgtable_debug_args *args) >> { >> struct page *page; >> swp_entry_t swp; >> @@ -861,9 +861,10 @@ static void __init swap_migration_tests(void) >> * problematic. Lets allocate a dedicated page explicitly for this >> * purpose that will be freed subsequently. >> */ >> - page = alloc_page(GFP_KERNEL); >> + page = (args->pte_pfn != ULONG_MAX) ? >> + pfn_to_page(args->pte_pfn) : NULL; >> if (!page) { >> - pr_err("page allocation failed\n"); >> + pr_err("no page available\n"); >> return; >> } > > Please check for a valid page earlier in the function and return. Otherwise > this calls out the page unavailability (after starting the test), which is > inconsistent with all other functions like pxx_advanced_tests(). > > [ 1.051633] debug_vm_pgtable: [pte_swap_tests ]: Validating PTE swap > [ 1.052697] debug_vm_pgtable: [pmd_swap_tests ]: Validating PMD swap > [ 1.053765] debug_vm_pgtable: [swap_migration_tests ]: Validating swap migration <===== > [ 1.054900] debug_vm_pgtable: [swap_migration_tests ]: no page available <===== > > Should do this just before pr_info("Validating swap migration\n"). > > ...... > page = (args->pte_pfn != ULONG_MAX) ? pfn_to_page(args->pte_pfn) : NULL; > if (!page) > return; > ..... > Yes. The order of error messages are sticky to original implementation, but it'd better to be consistent with the new order we have in this series. I will adjust in v5. Thanks, Gavin