From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D81C433E3 for ; Wed, 29 Jul 2020 17:30:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B3772082E for ; Wed, 29 Jul 2020 17:30:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MuxK+0p9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B3772082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0296D6B0003; Wed, 29 Jul 2020 13:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1BE06B0006; Wed, 29 Jul 2020 13:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE3C36B0007; Wed, 29 Jul 2020 13:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id C5E5A6B0003 for ; Wed, 29 Jul 2020 13:30:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8377A824934B for ; Wed, 29 Jul 2020 17:30:04 +0000 (UTC) X-FDA: 77091801528.02.shame60_510a22326f74 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 5C63610097AA5 for ; Wed, 29 Jul 2020 17:30:04 +0000 (UTC) X-HE-Tag: shame60_510a22326f74 X-Filterd-Recvd-Size: 3870 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jul 2020 17:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Qf4hOLrKqti/BrcIwmN2iDHq4yG0O43FA9u3ufNSp0k=; b=MuxK+0p92B5ZlzJuIQLJjB9DmL So3A2s7hmsfeI84gIlQa72xri1ADO0LzN1Hk3due0uygnNhWE432G1UOP+fvLTIMBTOmVcNum2nEC Z1JZ9ID76JhZRghZDrrJ/OW2NvVpaPMBuVXJ1fcleZ57884XO/zZZe14cwaKA1Hbqm9eUJjwxpxsv oKEudhpSPNYuByEMGfoOnRnnr22U0H0h0fRxK924AFTH+WUNI/rBiPvQjt0s+nOBUByytfHrNSWv6 mlBwYLWJcwviYi4nLrRQIqHMqsqbFswEwETiA8BQbiUS3TNqL1MoN2LYUEN+HZeazVm/gAN7eGs9A /r8viR3A==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0ptt-0003Q1-Pr; Wed, 29 Jul 2020 17:29:58 +0000 Subject: Re: mmotm 2020-07-27-18-18 uploaded (mm/page_alloc.c) To: David Hildenbrand , "Michael S. Tsirkin" , Andrew Morton Cc: Stephen Rothwell , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, Jason Wang References: <20200728011914.S-8vAYUK0%akpm@linux-foundation.org> <20200728145553.2a69fa2080de01922b3a74e0@linux-foundation.org> <20200729082053.6c2fb654@canb.auug.org.au> <20200728153143.c94d5af061b20db609511bf3@linux-foundation.org> <20200729101807-mutt-send-email-mst@kernel.org> <8271d9b6-431a-c8da-8591-4023ab6c8963@redhat.com> From: Randy Dunlap Message-ID: <731f96d9-c780-5c5d-e338-e647b71fc677@infradead.org> Date: Wed, 29 Jul 2020 10:29:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8271d9b6-431a-c8da-8591-4023ab6c8963@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5C63610097AA5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/29/20 9:14 AM, David Hildenbrand wrote: > On 29.07.20 16:38, David Hildenbrand wrote: >> On 29.07.20 16:18, Michael S. Tsirkin wrote: >>> On Tue, Jul 28, 2020 at 03:31:43PM -0700, Andrew Morton wrote: >>>> On Wed, 29 Jul 2020 08:20:53 +1000 Stephen Rothwell wrote: >>>> >>>>> Hi Andrew, >>>>> >>>>> On Tue, 28 Jul 2020 14:55:53 -0700 Andrew Morton wrote: >>>>>> config CONTIG_ALLOC >>>>>> def_bool (MEMORY_ISOLATION && COMPACTION) || CMA >>>>>> >>>>>> says this is an improper combination. And `make oldconfig' fixes it up. >>>>>> >>>>>> What's happening here? >>>>> >>>>> CONFIG_VIRTIO_MEM selects CONFIG_CONTIG_ALLOC ... >>>> >>>> Argh, select strikes again. >>>> >>>> So I guess VIRTIO_MEM should also select COMPACTION? >>> >>> +Cc the maintainer. >>> >> >> We had select CONFIG_CONTIG_ALLOC before and that seemed to be wrong. I >> was told select might be the wrong approach. >> >> We want memory isolation and contig_alloc with virtio-mem (which depends >> on memory hot(un)plug). What would be the right way to achieve this? >> > > Okay, I think I am confused. I thought we had that already fixed. @mst > what happened to > > https://lkml.kernel.org/r/d03c88ea-200d-54ab-d7f3-f3e5b7a0a9dd@redhat.com > > That patch is almost a month old, can you pick it, I already acked it. That patch works for me. Acked-by: Randy Dunlap # build-tested thanks. -- ~Randy