From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE786C432C3 for ; Mon, 25 Nov 2019 23:45:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8124E20733 for ; Mon, 25 Nov 2019 23:45:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="f8JuR9ii" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8124E20733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2437B6B02B5; Mon, 25 Nov 2019 18:45:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CC876B02B6; Mon, 25 Nov 2019 18:45:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 094756B02B7; Mon, 25 Nov 2019 18:45:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id E2D436B02B5 for ; Mon, 25 Nov 2019 18:45:19 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id A444F4845 for ; Mon, 25 Nov 2019 23:45:19 +0000 (UTC) X-FDA: 76196433558.11.crowd77_4b898560b1c56 X-HE-Tag: crowd77_4b898560b1c56 X-Filterd-Recvd-Size: 4079 Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 23:45:18 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 15:45:21 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 15:45:18 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 15:45:18 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 23:45:17 +0000 Subject: Re: [PATCH] bpf: fix a no-mmu build failure by providing a stub allocator To: Daniel Borkmann , Andrii Nakryiko CC: Song Liu , John Fastabend , Johannes Weiner , Linux Next Mailing List , , , , LKML , kbuild test robot References: <20191125234103.1699950-1-jhubbard@nvidia.com> <20191125234103.1699950-2-jhubbard@nvidia.com> <8c4d892a-73b5-b4d5-be15-bc81e8297de9@iogearbox.net> X-Nvconfidentiality: public From: John Hubbard Message-ID: <735f27ed-65dd-d132-e6b4-20ba5749876c@nvidia.com> Date: Mon, 25 Nov 2019 15:45:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <8c4d892a-73b5-b4d5-be15-bc81e8297de9@iogearbox.net> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574725521; bh=WMDeAcbZMWSPJMBANRYNfknq2XJvnNPf3T3fbDniwfE=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=f8JuR9ii0ljL+Rl9x2Epbdw3yXw2DiLEhV4ImlGOXOb2aEMhIxpnhMyxcOodL7KKS 3sCS/OSXJ5rBN910/7NLXae6d1kMXDHY5I8Kp9T/grvpttQkqodE1Gyf+ocjE0qbm/ pt8XKSvPtWYzQYmRMdGFjJUZ7I8S8qcMXcq0UmLVrSuhdPGoDnXt4HIkned6uY3L5k m9LPTdpvBxb5/wUWAmik2+rrxlN1Nnohx+fIREjzS3SOYZkLw3J8qLVSLmrswxvmDU PBFALk1N8P/TjfFzmIP09qtwosruAeG9YZTGaW4P455xmvL07vLGmhaDZ5PMqTLN6c 8MyrithA3laFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/25/19 3:43 PM, Daniel Borkmann wrote: > On 11/26/19 12:41 AM, John Hubbard wrote: >> Commit fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY") >> added code that calls vmalloc_user_node_flags() and therefore requires >> mm/vmalloc.c. However, that file is not built for the !CONFIG_MMU case. >> This leads to a build failure when using ARM with the config provided >> by at least one particular kbuild test robot report [1]. >> >> [1] https://lore/kernel.org/r/201911251639.UWS3hE3Y%lkp@intel.com >> >> Fix the build by providing a stub function for __bpf_map_area_alloc(). >> >> Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY") >> Reported-by: kbuild test robot >> Cc: Andrii Nakryiko >> Cc: Daniel Borkmann >> Cc: Song Liu >> Cc: John Fastabend >> Cc: Johannes Weiner >> Signed-off-by: John Hubbard > > Thanks for the patch, already fixed via: > > https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=ed81745a4c96841937f1da35c0eb66ac312e1480 OK, good, that's a better fix, too. Appreciate the quick answers! thanks, -- John Hubbard NVIDIA