From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5701C33C9E for ; Wed, 15 Jan 2020 02:33:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CD6424671 for ; Wed, 15 Jan 2020 02:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CD6424671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED3628E0005; Tue, 14 Jan 2020 21:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E83C38E0003; Tue, 14 Jan 2020 21:33:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B818E0005; Tue, 14 Jan 2020 21:33:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id C532E8E0003 for ; Tue, 14 Jan 2020 21:33:34 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 8637C180AD822 for ; Wed, 15 Jan 2020 02:33:34 +0000 (UTC) X-FDA: 76378297548.19.tail15_594ed2a962513 X-HE-Tag: tail15_594ed2a962513 X-Filterd-Recvd-Size: 1848 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 02:33:33 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Tnlx2xO_1579055609; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Tnlx2xO_1579055609) by smtp.aliyun-inc.com(127.0.0.1); Wed, 15 Jan 2020 10:33:30 +0800 Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page To: Qian Cai Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1579006500-127143-1-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: <739f4470-8dfe-bb2f-8100-2134f48868b6@linux.alibaba.com> Date: Wed, 15 Jan 2020 10:31:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.231326, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/1/14 =CF=C2=CE=E79:46, Qian Cai =D0=B4=B5=C0: >=20 >=20 >> On Jan 14, 2020, at 7:55 AM, Alex Shi wro= te: >> >> This macro are never used in git history. So better to remove. >=20 > When removing unused thingy, it is important to figure out which commit= introduced it in the first place and Cc the relevant people in that comm= it. >=20 Thanks fore reminder, Qian! This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or = commiter could be found. Thanks Alex