From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D79C47082 for ; Tue, 8 Jun 2021 11:19:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D01461359 for ; Tue, 8 Jun 2021 11:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D01461359 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF71D6B006C; Tue, 8 Jun 2021 07:19:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA63B6B0070; Tue, 8 Jun 2021 07:19:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1436B0071; Tue, 8 Jun 2021 07:19:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 76A756B006C for ; Tue, 8 Jun 2021 07:19:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1B9B98249980 for ; Tue, 8 Jun 2021 11:19:01 +0000 (UTC) X-FDA: 78230309682.18.0D7CFB4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf23.hostedemail.com (Postfix) with ESMTP id E513AA000151 for ; Tue, 8 Jun 2021 11:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623151140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CBLtrFhiRKeFc7Q7qn/8AZzS8tEb5Usg8INInZ6WYCs=; b=NCgNublPpUc65Nv9VMJ1ZXh7G8ulTDOg+GeMHxs5AdLA5wdvFcVbC1riX+BPiVNsB1FrsM bnC+0xwjq5QRyorxATrmLJeJ+9atPcJONYGUkeK4ty51NCsaD10GHwoNsQYLa0rZLMLaHb stXbO8E4RkU/aCKdNnYhnSeQhE4W4a0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-Hhv5oas-O9ycW04TGhSblQ-1; Tue, 08 Jun 2021 07:18:58 -0400 X-MC-Unique: Hhv5oas-O9ycW04TGhSblQ-1 Received: by mail-wr1-f69.google.com with SMTP id k11-20020adfe3cb0000b0290115c29d165cso9285033wrm.14 for ; Tue, 08 Jun 2021 04:18:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=CBLtrFhiRKeFc7Q7qn/8AZzS8tEb5Usg8INInZ6WYCs=; b=gPofFbwnvCVznuLTrwU40+jt0zt2QfkN2sSn4gfZsutRANQJEWQ7UhKvXGsNzepJYH fsZc9kLECxjp/p+hZwdhBJmJaNKPBJKnRyD0LFOt8Hzi5kmemPZ/vpgOnSPnj4XQz83y bAWT7ikXY8Yk/PDFFEC5NJvVV+USO1PNJ2OD9t1d5XJOUfTC+yOf4k3YwDOkZLDOKhG/ 0Vuq7pUOUcqy/FGbtO+QBWdCVR194ErlmAHBALkl6kAezT2Azr3g6Ptz3AFqF7LWjIu3 jMGvTjApzfduh+ukzKG3fYf+6/vKNCVhcoDjq/1/gyngsBYIVGpWTI1ljMpgCP/EV9BP 4t5w== X-Gm-Message-State: AOAM533ulPnwVqQRBR9S1dyHuQYNoAF5N9mZYHuiN5pGfdNdDd2EFCdI 5maM/U5jGp8AyB/4twmM2OeJvBWmvtY5iEfnQ4HTYVSLV/JVE/jDPpzcu/Vf6rygRIpMHWl7PyQ xEwGCkgsn1xo= X-Received: by 2002:adf:df86:: with SMTP id z6mr22061244wrl.255.1623151137784; Tue, 08 Jun 2021 04:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrB9z1bqXKLNgH1xZgLenFDxAm/18wrzcUUIce09tn+BporQC3UeSbXcvGrkz4TceLSHiMMw== X-Received: by 2002:adf:df86:: with SMTP id z6mr22061199wrl.255.1623151137577; Tue, 08 Jun 2021 04:18:57 -0700 (PDT) Received: from [192.168.3.132] (p5b0c61cf.dip0.t-ipconnect.de. [91.12.97.207]) by smtp.gmail.com with ESMTPSA id u2sm19236473wrn.38.2021.06.08.04.18.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 04:18:57 -0700 (PDT) Subject: Re: [PATCH v1 05/12] mm/memory_hotplug: remove nid parameter from remove_memory() and friends To: Michael Ellerman , linux-kernel@vger.kernel.org Cc: Andrew Morton , Vitaly Kuznetsov , "Michael S. Tsirkin" , Jason Wang , Marek Kedzierski , Hui Zhu , Pankaj Gupta , Wei Yang , Oscar Salvador , Michal Hocko , Dan Williams , Anshuman Khandual , Dave Hansen , Vlastimil Babka , Mike Rapoport , "Rafael J. Wysocki" , Len Brown , Pavel Tatashin , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Vishal Verma , Dave Jiang , Nathan Lynch , Laurent Dufour , "Aneesh Kumar K.V" , Scott Cheloha , Anton Blanchard , linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev References: <20210607195430.48228-1-david@redhat.com> <20210607195430.48228-6-david@redhat.com> <87y2bkehky.fsf@mpe.ellerman.id.au> From: David Hildenbrand Organization: Red Hat Message-ID: <7463b3ed-07d3-7157-629d-a85a3ff558d6@redhat.com> Date: Tue, 8 Jun 2021 13:18:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87y2bkehky.fsf@mpe.ellerman.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NCgNublP; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E513AA000151 X-Stat-Signature: kpb6s7kiozzei19bypm8koptztaq64n5 X-HE-Tag: 1623151137-451429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.06.21 13:11, Michael Ellerman wrote: > David Hildenbrand writes: >> There is only a single user remaining. We can simply try to offline all >> online nodes - which is fast, because we usually span pages and can skip >> such nodes right away. > > That makes me slightly nervous, because our big powerpc boxes tend to > trip on these scaling issues before others. > > But the spanned pages check is just: > > void try_offline_node(int nid) > { > pg_data_t *pgdat = NODE_DATA(nid); > ... > if (pgdat->node_spanned_pages) > return; > > So I guess that's pretty cheap, and it's only O(nodes), which should > never get that big. Exactly. And if it does turn out to be a problem, we can walk all memory blocks before removing them, collecting the nid(s). -- Thanks, David / dhildenb