From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks
Date: Fri, 1 Sep 2017 14:32:25 +0200 [thread overview]
Message-ID: <74a33b7b-0586-c08a-cb2e-1c3d2872815d@suse.cz> (raw)
In-Reply-To: <fa162335-a36d-153a-7b5d-1d9c2d57aebc@suse.cz>
On 08/23/2017 10:41 AM, Vlastimil Babka wrote:
> On 08/16/2017 01:39 AM, David Rientjes wrote:
>> It is pointless to migrate hugetlb memory as part of memory compaction if
>> the hugetlb size is equal to the pageblock order. No defragmentation is
>> occurring in this condition.
>>
>> It is also pointless to for the freeing scanner to scan a pageblock where
>> a hugetlb page is pinned. Unconditionally skip these pageblocks, and do
>> so peristently so that they are not rescanned until it is observed that
>> these hugepages are no longer pinned.
>>
>> It would also be possible to do this by involving the hugetlb subsystem
>> in marking pageblocks to no longer be skipped when they hugetlb pages are
>> freed. This is a simple solution that doesn't involve any additional
>> subsystems in pageblock skip manipulation.
>>
>> Signed-off-by: David Rientjes <rientjes@google.com>
>> ---
>> mm/compaction.c | 48 +++++++++++++++++++++++++++++++++++++-----------
>> 1 file changed, 37 insertions(+), 11 deletions(-)
>>
>> diff --git a/mm/compaction.c b/mm/compaction.c
>> --- a/mm/compaction.c
>> +++ b/mm/compaction.c
>> @@ -217,6 +217,20 @@ static void reset_cached_positions(struct zone *zone)
>> pageblock_start_pfn(zone_end_pfn(zone) - 1);
>> }
>>
>> +/*
>> + * Hugetlbfs pages should consistenly be skipped until updated by the hugetlb
>> + * subsystem. It is always pointless to compact pages of pageblock_order and
>> + * the free scanner can reconsider when no longer huge.
>> + */
>> +static bool pageblock_skip_persistent(struct page *page, unsigned int order)
>> +{
>> + if (!PageHuge(page))
>> + return false;
>> + if (order != pageblock_order)
>> + return false;
>> + return true;
>
> Why just HugeTLBfs? There's also no point in migrating/finding free
> pages in THPs. Actually, any compound page of pageblock order?
>
>> +}
>> +
>> /*
>> * This function is called to clear all cached information on pageblocks that
>> * should be skipped for page isolation when the migrate and free page scanner
>> @@ -241,6 +255,8 @@ static void __reset_isolation_suitable(struct zone *zone)
>> continue;
>> if (zone != page_zone(page))
>> continue;
>> + if (pageblock_skip_persistent(page, compound_order(page)))
>> + continue;
>
> I like the idea of how persistency is achieved by rechecking in the reset.
>
>>
>> clear_pageblock_skip(page);
>> }
>> @@ -448,13 +464,15 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
>> * and the only danger is skipping too much.
>> */
>> if (PageCompound(page)) {
>> - unsigned int comp_order = compound_order(page);
>> -
>> - if (likely(comp_order < MAX_ORDER)) {
>> - blockpfn += (1UL << comp_order) - 1;
>> - cursor += (1UL << comp_order) - 1;
>> + const unsigned int order = compound_order(page);
>> +
>> + if (pageblock_skip_persistent(page, order)) {
>> + set_pageblock_skip(page);
>> + blockpfn = end_pfn;
>> + } else if (likely(order < MAX_ORDER)) {
>> + blockpfn += (1UL << order) - 1;
>> + cursor += (1UL << order) - 1;
>> }
>
> Is this new code (and below) really necessary? The existing code should
> already lead to skip bit being set via update_pageblock_skip()?
Ok, here's a patch implementing my suggestions.
----8<----
next prev parent reply other threads:[~2017-09-01 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 23:39 [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip David Rientjes
2017-08-15 23:39 ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks David Rientjes
2017-08-18 8:49 ` Michal Hocko
2017-08-21 0:36 ` [patch -mm] mm, compaction: persistently skip hugetlbfs pageblocks fix David Rientjes
2017-08-21 6:37 ` Michal Hocko
2017-08-23 8:41 ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks Vlastimil Babka
2017-09-01 12:32 ` Vlastimil Babka [this message]
2017-09-11 1:13 ` David Rientjes
2017-09-11 1:12 ` David Rientjes
2017-09-11 6:50 ` Vlastimil Babka
2017-09-11 21:11 ` David Rientjes
2017-08-23 8:23 ` [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip Vlastimil Babka
2017-09-11 1:07 ` David Rientjes
2017-09-11 6:34 ` Vlastimil Babka
2017-09-11 21:13 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74a33b7b-0586-c08a-cb2e-1c3d2872815d@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).