From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD1DCD1283 for ; Fri, 29 Mar 2024 04:54:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9EC86B00A0; Fri, 29 Mar 2024 00:54:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4F196B00A4; Fri, 29 Mar 2024 00:54:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3EF96B00C8; Fri, 29 Mar 2024 00:54:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A6EDE6B00A0 for ; Fri, 29 Mar 2024 00:54:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6023FA1121 for ; Fri, 29 Mar 2024 04:54:39 +0000 (UTC) X-FDA: 81948861078.24.507B7DA Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf04.hostedemail.com (Postfix) with ESMTP id 4EBE840004 for ; Fri, 29 Mar 2024 04:54:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711688077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5jUIaE+cHoeye63pZD0IB0uMTGlQCbBZIT8/OBfkLEw=; b=01knCKTqlhWg77Is5afUOk5a/tfOVmzFIGoWofhQzVVaxq7oPtql6WgrNRXU2fzg1xpYVX +I91QmDeQ7dOx4zBfEENZSTUIZlvNO2tHUkzdPZJn/0Rqbbc0APhuncqqN2M0JvepcPAbo b13GN24sImbLQf5U6G17+QUyX94L/tg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711688077; a=rsa-sha256; cv=none; b=gliwDa10TjdIoxl7pVcMLXxDLtZFW9oMxFDotBxQk1NCrqTkZROruPvnSq6nWb1vjcgXQR dktyB6ClYfo+UigPJBxYRthHem/0GZIRq02M9YhIB48jjBRfK28+jCgjUmTWKLfs3oijZ2 AjMR+LFcM03sRYZ5isCbwPi5wD0hZb0= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V5SgC0MnKz1h4QJ; Fri, 29 Mar 2024 12:51:51 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id EBE65140336; Fri, 29 Mar 2024 12:54:31 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 29 Mar 2024 12:54:31 +0800 Message-ID: <74b147b0-718d-4d50-be75-d6afc801cd24@huawei.com> Date: Fri, 29 Mar 2024 12:54:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] page_owner: Fix refcount imbalance Content-Language: en-US To: Oscar Salvador , Andrew Morton CC: , , Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240326063036.6242-1-osalvador@suse.de> From: Kefeng Wang In-Reply-To: <20240326063036.6242-1-osalvador@suse.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 4EBE840004 X-Rspam-User: X-Stat-Signature: b5jzoxazfuwawgrg94hoc7ssqxbhz1pz X-Rspamd-Server: rspam01 X-HE-Tag: 1711688075-403037 X-HE-Meta: U2FsdGVkX1/+txh2tpWcvultVPeZjM3DlmMdUP3tlDMQ9PaXVyf5uWxsE2ky9W/73HY2iI4PUZWj/1J/z6VXDsqInCj+Ej4WphwEumzZEK0gU39/WGT4MdPEX/ZtxfF3/zCPGKIBOt3Pf9RtWTfgoQqKQzk4PWeljwarUQgEf/5yv3fwhzlVNDS9jz7D63b473hs4YoFlMf4zQZFMumALgmC/oZ799ImmOQ8La+ppz3ZVSM7nIPPDcNuLaKeR7tjp0i6FFxNcAkBy2BL9TCeXlfp0OaSRf9sun12Xu/AZgCxV1ZULCMsH8myTLp9XhnlCwV9Dvqa4OxT9HtHdcLvqDsnv+H5u0RXC7Oqqvl9UTupSoumrFTWjtOjbwwSZAXGp1Bc2mtNsK6d6RFnooczPbAIMQ47nsx5FydG9Rf3iuKBjJv9DScHMyo8Z5JScHN+fuUiK6hLRk1GAfdNTO60klSW7YCiQpW/YFj4hqLr4RKEJEL7Oe21zdelAqclCpiIlXuM/8U3TW0Cgk6aBIXs4w7UxrRYCvzNcCaezrcWgb7QK5XB7RZGRZLuYbc9mHuntYCFQ3MZm00MfAkR20MIbCNW1uuKJMKcSHw+gmrC2Uk6glWoxSohVzB0yKTu/+pb3uMCu5OU4f6FtOA7xqU/bNqFm8Bg2FuVgv3yvjjGezGyU4COTpnT4w8Y1fHdNGGRdYKf2wEeeu+ttGsXjZehBGe9MQMgHFoOiiCsXhaSck0bMEo1tCqFjcw8qfyAK+iTknq3Od0nIJt7FMq33Pumjbs4i33SWBa9eNSNrKjzOlqtD9XZK81zk+K7U+lYVuRVcnRAqEjBSplnYlcynyRKwQmSZlWi/iEElYhMNZ59UOGwxMz+wu9KHuXD1VYYPD2olxL/uc4dQtE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/26 14:30, Oscar Salvador wrote: > This series consists of a refactoring/correctness of updating the metadata > of tail pages and a couple of fixups for the refcounting part. > >>>From this series on, instead of counting the stacks, we count the outstanding > nr_base_pages each stack has, which gives us a much better memory overview. > The other fixup is for the migration part. > > A more detailed explanation can be found in the changelog of the respective > patches. Hi Oscar, this patchset fix the following issue when I test my migration changes, but [ 31.478715] ------------[ cut here ]------------ [ 31.480491] refcount_t: decrement hit 0; leaking memory. [ 31.482724] WARNING: CPU: 7 PID: 113 at lib/refcount.c:31 refcount_warn_saturate+0x13c/0x148 [ 31.485390] Modules linked in: [ 31.486800] CPU: 7 PID: 113 Comm: sh Not tainted 6.9.0-rc1-00178-g317c7bc0ef03 #139 [ 31.487883] Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015 [ 31.489066] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 31.489872] pc : refcount_warn_saturate+0x13c/0x148 [ 31.490350] lr : refcount_warn_saturate+0x13c/0x148 [ 31.490829] sp : ffff800087913650 [ 31.491182] x29: ffff800087913650 x28: ffff00020624d010 x27: 0000000000000000 [ 31.492419] x26: 0000000000000001 x25: ffff800082dd0d60 x24: 0000000000000000 [ 31.493006] x23: 0000000754405c20 x22: ffff800082ec0000 x21: 00000000028c008e [ 31.493527] x20: ffff0000d1638208 x19: ffff0000d1638200 x18: 0000000000000010 [ 31.493984] x17: 0000000000000006 x16: 0000000000000000 x15: ffff0000c6253c18 [ 31.494330] x14: 0000000000000000 x13: 0000000000000002 x12: ffff800082dff318 [ 31.494669] x11: ffff800082e6f640 x10: ffff800082e57600 x9 : ffff80008015869c [ 31.495056] x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 : 0000000000000001 [ 31.495383] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 : 0000000000000000 [ 31.495756] x2 : ffff800082dff228 x1 : 0000000000000000 x0 : 0000000000000000 [ 31.496367] Call trace: [ 31.496528] refcount_warn_saturate+0x13c/0x148 [ 31.496760] __reset_page_owner+0x124/0x158 [ 31.496965] free_unref_page_prepare+0x2a4/0x440 [ 31.497183] free_unref_folios+0x118/0x460 [ 31.497368] folios_put_refs+0x11c/0x250 [ 31.497559] free_pages_and_swap_cache+0xd4/0x160 [ 31.497772] tlb_flush_mmu+0x8c/0x188 [ 31.497952] tlb_finish_mmu+0x54/0x160 [ 31.498123] exit_mmap+0x174/0x4e8 [ 31.498295] mmput+0xb4/0x1a0 [ 31.498429] begin_new_exec+0x474/0xd30 [ 31.498606] load_elf_binary+0x378/0x1488 [ 31.498792] bprm_execve+0x2a0/0x7e0 [ 31.498956] do_execveat_common.isra.0+0x19c/0x240 [ 31.499174] __arm64_sys_execve+0x48/0x68 [ 31.499358] invoke_syscall+0x4c/0x118 [ 31.499534] el0_svc_common.constprop.0+0x48/0xf0 [ 31.499816] do_el0_svc+0x24/0x38 [ 31.500063] el0_svc+0x4c/0x120 [ 31.500314] el0t_64_sync_handler+0xc0/0xc8 [ 31.500584] el0t_64_sync+0x190/0x198 I still see the following memory leak, could you check it? /mnt/arm64 # cat /sys//kernel/debug/kmemleak unreferenced object 0xffff000200d91000 (size 16): comm "kworker/4:0", pid 42, jiffies 4294892753 hex dump (first 16 bytes): 60 37 57 c1 00 00 ff ff 00 00 00 00 00 00 00 00 `7W............. backtrace (crc 4458f477): [<(____ptrval____)>] kmemleak_alloc+0x3c/0x50 [<(____ptrval____)>] kmalloc_trace+0x20c/0x2e0 [<(____ptrval____)>] __set_page_owner+0x1d0/0x2a0 [<(____ptrval____)>] prep_new_page+0x108/0x138 [<(____ptrval____)>] get_page_from_freelist+0x79c/0x16b8 [<(____ptrval____)>] __alloc_pages+0x1bc/0x440 [<(____ptrval____)>] new_slab+0x104/0x3c8 [<(____ptrval____)>] ___slab_alloc+0x368/0xb20 [<(____ptrval____)>] __slab_alloc.isra.0+0x3c/0x88 [<(____ptrval____)>] kmalloc_trace+0x280/0x2e0 [<(____ptrval____)>] __set_page_owner+0x1d0/0x2a0 [<(____ptrval____)>] prep_new_page+0x108/0x138 [<(____ptrval____)>] get_page_from_freelist+0x79c/0x16b8 [<(____ptrval____)>] __alloc_pages+0x1bc/0x440 [<(____ptrval____)>] new_slab+0x104/0x3c8 [<(____ptrval____)>] ___slab_alloc+0x368/0xb20 unreferenced object 0xffff000200d90000 (size 16): comm "kworker/4:0", pid 42, jiffies 4294892753 hex dump (first 16 bytes): 20 38 57 c1 00 00 ff ff 00 10 d9 00 02 00 ff ff 8W............. backtrace (crc 786eca4d): [<(____ptrval____)>] kmemleak_alloc+0x3c/0x50 [<(____ptrval____)>] kmalloc_trace+0x20c/0x2e0 [<(____ptrval____)>] __set_page_owner+0x1d0/0x2a0 [<(____ptrval____)>] prep_new_page+0x108/0x138 [<(____ptrval____)>] get_page_from_freelist+0x79c/0x16b8 [<(____ptrval____)>] __alloc_pages+0x1bc/0x440 [<(____ptrval____)>] new_slab+0x104/0x3c8 [<(____ptrval____)>] ___slab_alloc+0x368/0xb20 [<(____ptrval____)>] __slab_alloc.isra.0+0x3c/0x88 [<(____ptrval____)>] kmalloc_node_trace+0x274/0x2f0 [<(____ptrval____)>] alloc_worker+0x2c/0x70 [<(____ptrval____)>] create_worker+0x58/0x278 [<(____ptrval____)>] worker_thread+0x260/0x320 [<(____ptrval____)>] kthread+0x130/0x148 [<(____ptrval____)>] ret_from_fork+0x10/0x20 unreferenced object 0xffff000200d90010 (size 16): comm "kworker/4:0", pid 42, jiffies 4294892753 hex dump (first 16 bytes): e0 39 57 c1 00 00 ff ff 00 00 d9 00 02 00 ff ff .9W............. backtrace (crc d4c89665): [<(____ptrval____)>] kmemleak_alloc+0x3c/0x50 [<(____ptrval____)>] kmalloc_trace+0x20c/0x2e0 [<(____ptrval____)>] __set_page_owner+0x1d0/0x2a0 [<(____ptrval____)>] prep_new_page+0x108/0x138 [<(____ptrval____)>] get_page_from_freelist+0x79c/0x16b8 [<(____ptrval____)>] __alloc_pages+0x1bc/0x440 [<(____ptrval____)>] new_slab+0x104/0x3c8 [<(____ptrval____)>] ___slab_alloc+0x368/0xb20 [<(____ptrval____)>] __slab_alloc.isra.0+0x3c/0x88 [<(____ptrval____)>] kmalloc_trace+0x280/0x2e0 [<(____ptrval____)>] __kthread_create_on_node+0x7c/0x190 [<(____ptrval____)>] kthread_create_on_node+0x60/0x90 [<(____ptrval____)>] create_worker+0xd0/0x278 [<(____ptrval____)>] worker_thread+0x260/0x320 [<(____ptrval____)>] kthread+0x130/0x148 [<(____ptrval____)>] ret_from_fork+0x10/0x20 Thanks. > > Oscar Salvador (3): > mm,page_owner: Update metada for tail pages > mm,page_owner: Fix refcount imbalance > mm,page_owner: Fix accounting of pages when migrating > > Documentation/mm/page_owner.rst | 73 +++++++------ > mm/page_owner.c | 184 +++++++++++++++++++------------- > 2 files changed, 146 insertions(+), 111 deletions(-) >