From: Miaohe Lin <linmiaohe@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/pgtable-generic.c: optimize the VM_BUG_ON condition in pmdp_huge_clear_flush()
Date: Fri, 5 Feb 2021 11:22:17 +0800 [thread overview]
Message-ID: <74f9fda6-b4f5-487d-67c3-788ae0c22fff@huawei.com> (raw)
In-Reply-To: <20210204123605.GD308988@casper.infradead.org>
Hi:
On 2021/2/4 20:36, Matthew Wilcox wrote:
> On Wed, Feb 03, 2021 at 03:41:37AM -0500, Miaohe Lin wrote:
>> The developer will have trouble figuring out why the BUG actually triggered
>> when there is a complex expression in the VM_BUG_ON. Because we can only
>> identify the condition triggered BUG via line number provided by VM_BUG_ON.
>> Optimize this by spliting such a complex expression into two simple
>> conditions.
>
>> pmd_t pmd;
>> VM_BUG_ON(address & ~HPAGE_PMD_MASK);
>> - VM_BUG_ON(!pmd_present(*pmdp) || (!pmd_trans_huge(*pmdp) &&
>> - !pmd_devmap(*pmdp)));
>> + VM_BUG_ON(!pmd_present(*pmdp));
>> + /* Below assumes pmd_present() is true */
>> + VM_BUG_ON(!pmd_trans_huge(*pmdp) && !pmd_devmap(*pmdp));
>
> This is not a complex condition. We're in the huge PMD handling case
> and we're looking at a PMD which either isn't present or isn't huge.
> It might be useful to print out the PMD in such a case, but splitting
> this into the two cases of pmd-not-present and pmd-isn't-huge isn't
> particularly useful.
>
Many thanks for your time. You are right that it would be more helpful if we
had a VM_BUG_ON_PMD() that we could print the pmd's value and permit diagnosis
from that. I think splitting this into the two cases is the best we can do now
while lacking of such helper.
> I think you know that, or you wouldn't feel the need to put in a
> comment explaining it!
> .
>
Thanks again.
prev parent reply other threads:[~2021-02-05 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:41 [PATCH] mm/pgtable-generic.c: optimize the VM_BUG_ON condition in pmdp_huge_clear_flush() Miaohe Lin
2021-02-04 12:36 ` Matthew Wilcox
2021-02-05 3:22 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74f9fda6-b4f5-487d-67c3-788ae0c22fff@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).