From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51140C5519A for ; Mon, 27 Apr 2020 05:04:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A1FF2075B for ; Mon, 27 Apr 2020 05:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bT29SBfO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A1FF2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B11BE8E0006; Mon, 27 Apr 2020 01:04:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9AFC8E0001; Mon, 27 Apr 2020 01:04:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9638F8E0006; Mon, 27 Apr 2020 01:04:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 7A8638E0001 for ; Mon, 27 Apr 2020 01:04:50 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 35BCD180AD804 for ; Mon, 27 Apr 2020 05:04:50 +0000 (UTC) X-FDA: 76752445140.18.girls54_817f464623f3b X-HE-Tag: girls54_817f464623f3b X-Filterd-Recvd-Size: 6580 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 05:04:49 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id y6so7009178pjc.4 for ; Sun, 26 Apr 2020 22:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RpEFDruZhhlXBhX9QpFVEyfUVGVZWtywwb585yNz+7Y=; b=bT29SBfOK96SESehhTW4BCxtsJFVttVeoi/t0urpRpj0AFJ020vN2h1/7jbZohDiWY G+7rYY/cyjMWRX2nWM1nQUHRK5DYY0Z3Re/LQsmmL5pheEmdu3Z1rJ7IPvBhUWW1vcYA rRAUC3qAszhg7SieSVaXNxX3irqWsJ185lS+6xxGA+5B6PInlCzT3e4IzLqCdgG84LZT 0O5T2gDAaSxEEY9ruwlPztv5j6dMcOK3Fxvpnkz0f3/jF7y8KJINeGHpr20aF1GemJoJ vZnP/QcZkHuVdvvx0xYhq+BbBscy9ve367kNA6XTMOpJq4QXGHxO/ZNnzNN5zxO0WihD fgVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RpEFDruZhhlXBhX9QpFVEyfUVGVZWtywwb585yNz+7Y=; b=XH0MjdeHCxUvSGwOkhaBEpfPr/aJjAEVUEZCyr3Ecbxp8TB+12NV21FFTOX2fteYWH qaADSeB9RVH6fjkNXcKZ6rZlYx+iFKRDD1Hy5dZT+Zng5chXQUVkdPmyP2gOMrXQXPz0 wcVdM/QrVC6W2JYiQK9445RP7FvxxaQKofknU2BGi/2PYncaV6VgVQdWrQ+xYvDvqaC2 y3m6hjA480yDuYhk6L2TzDf+bBt0Pb/QjFslrC4+UesCPRhSS9B0hLF56nwFOv39lj+L Hg6jLGIKsu4jNuS1dOTuJXAWuLbZKenPYvr87kT8r93uZl3iu9Q4+9mZBIukAzdbwCx7 Ke7Q== X-Gm-Message-State: AGi0PuYT8ZoMK7Lya1XZxJdGOVxBGgcGkzbzVLkTMcYNTIOvOX7Ez9iC jdjic2cpk0cM6ah38JEoP2o= X-Google-Smtp-Source: APiQypIf/qo/TUxxXd3N0x5q5i+APW/p3XTbnR6PLJskh1YyRzL4PAyXKe0dL0wTZKlCFIs0r3ai3g== X-Received: by 2002:a17:90a:3f8e:: with SMTP id m14mr20357937pjc.92.1587963888745; Sun, 26 Apr 2020 22:04:48 -0700 (PDT) Received: from [192.168.0.102] ([49.205.220.192]) by smtp.gmail.com with ESMTPSA id o21sm9822670pgk.16.2020.04.26.22.04.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2020 22:04:48 -0700 (PDT) Subject: Re: [PATCH v3 2/4] hugetlbfs: move hugepagesz= parsing to arch independent code To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Randy Dunlap , Mina Almasry , Peter Xu , Nitesh Narayan Lal , Andrew Morton References: <20200417185049.275845-1-mike.kravetz@oracle.com> <20200417185049.275845-3-mike.kravetz@oracle.com> From: Sandipan Das Message-ID: <7583dfcc-62d8-2a54-6eef-bcb4e01129b3@gmail.com> Date: Mon, 27 Apr 2020 10:34:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200417185049.275845-3-mike.kravetz@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 18/04/20 12:20 am, Mike Kravetz wrote: > Now that architectures provide arch_hugetlb_valid_size(), parsing > of "hugepagesz=" can be done in architecture independent code. > Create a single routine to handle hugepagesz= parsing and remove > all arch specific routines. We can also remove the interface > hugetlb_bad_size() as this is no longer used outside arch independent > code. > > This also provides consistent behavior of hugetlbfs command line > options. The hugepagesz= option should only be specified once for > a specific size, but some architectures allow multiple instances. > This appears to be more of an oversight when code was added by some > architectures to set up ALL huge pages sizes. > > [...] > > diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c > index de54d2a37830..2c3fa0a7787b 100644 > --- a/arch/powerpc/mm/hugetlbpage.c > +++ b/arch/powerpc/mm/hugetlbpage.c > @@ -589,21 +589,6 @@ static int __init add_huge_page_size(unsigned long long size) > return 0; > } > > -static int __init hugepage_setup_sz(char *str) > -{ > - unsigned long long size; > - > - size = memparse(str, &str); > - > - if (add_huge_page_size(size) != 0) { > - hugetlb_bad_size(); > - pr_err("Invalid huge page size specified(%llu)\n", size); > - } > - > - return 1; > -} > -__setup("hugepagesz=", hugepage_setup_sz); > - > [...] This isn't working as expected on powerpc64. [ 0.000000] Kernel command line: root=UUID=dc7b49cf-95a2-4996-8e7d-7c64ddc7a6ff hugepagesz=16G hugepages=2 [ 0.000000] HugeTLB: huge pages not supported, ignoring hugepagesz = 16G [ 0.000000] HugeTLB: huge pages not supported, ignoring hugepages = 2 [ 0.284177] HugeTLB registered 16.0 MiB page size, pre-allocated 0 pages [ 0.284182] HugeTLB registered 16.0 GiB page size, pre-allocated 0 pages [ 2.585062] hugepagesz=16G [ 2.585063] hugepages=2 The "huge pages not supported" messages are under a !hugepages_supported() condition which checks if HPAGE_SHIFT is non-zero. On powerpc64, HPAGE_SHIFT comes from the hpage_shift variable. At this point, it is still zero and yet to be set. Hence the check fails. The reason being hugetlbpage_init_default(), which sets hpage_shift, it now called after hugepage_setup_sz(). - Sandipan