From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51179C433E0 for ; Wed, 24 Feb 2021 16:53:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C786564F06 for ; Wed, 24 Feb 2021 16:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C786564F06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E2C36B0005; Wed, 24 Feb 2021 11:53:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 291BD6B0006; Wed, 24 Feb 2021 11:53:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181506B006C; Wed, 24 Feb 2021 11:53:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 038826B0005 for ; Wed, 24 Feb 2021 11:53:05 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B01EA87E6 for ; Wed, 24 Feb 2021 16:53:05 +0000 (UTC) X-FDA: 77853756330.05.7A268AE Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf13.hostedemail.com (Postfix) with ESMTP id 68CDFE0011FD for ; Wed, 24 Feb 2021 16:53:02 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id z13so2685495iox.8 for ; Wed, 24 Feb 2021 08:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lkgf2NqealUW3pQjVN+lec9asYNfPi8RpEWally8zeE=; b=t4Bhc4RGwJM5Y6LB5l6RgQMro1eSjb8Lebn+rYoYG2GNiMW9NOXKPHcNDLabVNdmC+ ZVLz7dvMl7OpxDefHSyqw2zBm8gMS9QnULN+9dsokYxbR6sEPTOI/iAt/B1oHsndBtlf eC1ndp0SL5ONMB717gmqAc+X+bUBvC8792wQL51cmJr58RsAFxcAJ4ZL8vxF0yRjxoBs a0WZ6MP1RqbNsPoWGjSx1fFJo/rzEJ56/oD4+WA/szkvNYYvNQRNtyEMbfLmhYOdRp8g eSaqtdwzFrnWknYSIB/sfp/A9zA2uAcnmP3GfYWHs5vWMx3UUimseFLkMDwjvDgpTH9b 8bLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lkgf2NqealUW3pQjVN+lec9asYNfPi8RpEWally8zeE=; b=BQoyXbpGcmwaCk1mUS4Y0TwVhMUrmhgtTw3fJvClF6oDLr5t7X18bme8W4fbSq7QSd rg+Sskv7J5Tvsqxi6V79gyDs78cUn5WzL1ZR728XfLe/MGvmtuV1/jV8NSjH8IpfLdfS KNX+gh+omtff3BXDRX0jFLLUCwMnc7GZfijMXyGt/2YHvvlsqjr4riPCpFfm3pLDlkh5 4SMNtTdCH+jfDiik4WbjpBqz0xxa3sikBgQPwrQd14UqhIar2EVQwVaK8mygNHYEcD35 ozdh5DPFOfU6IYLaLF0cLU2w5C0cod/UcrQVVRQes3rb4/MVPGjKAOr1jc5n5yyAxe28 XC3A== X-Gm-Message-State: AOAM531d4JsgS4uHqNMrvUKM83qCUtvmeWkl/wJnHQQ6DIMihhY9xcyz lPv5Q1kjrKBHlZ3jkn5i01lSBzF1qJvWRJEP X-Google-Smtp-Source: ABdhPJwUIZ/sQcfJGBQzkwZD3VOnSClO8vLiL2SgI1eMZbKRG21TsnjPHUiXTYFzV3F/MJuSSJMCGA== X-Received: by 2002:a05:6638:350:: with SMTP id x16mr17808007jap.119.1614185582871; Wed, 24 Feb 2021 08:53:02 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id q15sm1857857ilt.30.2021.02.24.08.53.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 08:53:02 -0800 (PST) Subject: Re: [PATCH 1/3] mm: provide filemap_range_needs_writeback() helper To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org References: <20210224164455.1096727-1-axboe@kernel.dk> <20210224164455.1096727-2-axboe@kernel.dk> <20210224165054.GR2858050@casper.infradead.org> From: Jens Axboe Message-ID: <75e6dc0b-ca95-cc84-ef3b-81d8fe6c5833@kernel.dk> Date: Wed, 24 Feb 2021 09:53:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210224165054.GR2858050@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: qz9zipnkno6f4n13kbbexf3otuixo33k X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 68CDFE0011FD Received-SPF: none (kernel.dk>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-io1-f41.google.com; client-ip=209.85.166.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614185582-582934 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/24/21 9:50 AM, Matthew Wilcox wrote: > On Wed, Feb 24, 2021 at 09:44:53AM -0700, Jens Axboe wrote: >> +++ b/include/linux/fs.h >> @@ -2633,6 +2633,8 @@ static inline int filemap_fdatawait(struct address_space *mapping) >> >> extern bool filemap_range_has_page(struct address_space *, loff_t lstart, >> loff_t lend); >> +extern bool filemap_range_needs_writeback(struct address_space *, >> + loff_t lstart, loff_t lend); >> extern int filemap_write_and_wait_range(struct address_space *mapping, >> loff_t lstart, loff_t lend); >> extern int __filemap_fdatawrite_range(struct address_space *mapping, > > These prototypes should all be in pagemap.h, not fs.h. I can do > a followup patch if you don't want to do it as part of this set. > Also we're deprecating the use of 'extern' for prototypes. Agree on both of those, but that should probably be a separate patch for both of those. extern is just following the existing style, and fs.h is the existing location... > Reviewed-by: Matthew Wilcox (Oracle) Thanks! -- Jens Axboe