From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34BDC433F5 for ; Tue, 5 Oct 2021 08:48:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB0896136F for ; Tue, 5 Oct 2021 08:48:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AB0896136F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3A1AC900002; Tue, 5 Oct 2021 04:48:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352176B0071; Tue, 5 Oct 2021 04:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21964900002; Tue, 5 Oct 2021 04:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 12A346B006C for ; Tue, 5 Oct 2021 04:48:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ADA032BA85 for ; Tue, 5 Oct 2021 08:48:13 +0000 (UTC) X-FDA: 78661756866.12.596062B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 4BAD97002CBB for ; Tue, 5 Oct 2021 08:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633423692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W8cSRh/BjNtkm1NdF8EnGpvtcrgUBRBEv5AvyROV31o=; b=h2+8uOUn1O6W/hQu5sDEmkRyH2IZehVmOu4ZJkr6MscRQp0cRJ/01GyGpcxuStW1p/sdel /Lia3OWi61VyxgZc8bSnuXtcm8mpe02OQ86LF/aqDC7Gwyc4N7ypaPV4/NHCYGUnekA9B9 a7ZegmKULkPvLyzJaNX+U8Gh5z7sljg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412--mq9KojZNjSuudJ6JmZvqA-1; Tue, 05 Oct 2021 04:48:11 -0400 X-MC-Unique: -mq9KojZNjSuudJ6JmZvqA-1 Received: by mail-wr1-f70.google.com with SMTP id x2-20020a5d54c2000000b0015dfd2b4e34so5474657wrv.6 for ; Tue, 05 Oct 2021 01:48:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W8cSRh/BjNtkm1NdF8EnGpvtcrgUBRBEv5AvyROV31o=; b=X9ONrWw1qPdXD1DCwtvfgwGoJLx6Ou0YMEafuOMmXZj1NoGEx1zoFbEo7y1BvI8CFY sNDuDcrHgwn2sMJjwqevI1YzUsCrsjXcwa70k01KJFjd8OHLG+SoQEBmST5yFnPoCoHb lUOjgYDfvqiQ2siF30o71ISS/rKeiA29eF1VfpA4JLAoCngbetSyRyn2PmowjRqUNgx0 bw1IWvEtjpRsbeL0lrq78OX5pJinsM6wiWhrdzGQWXGN2/x+uEl4UiKLzM0gJ9esPURU d/54gbw/Q5TodXvBBJLpozqDjwLBXqO69imcqolT3w/KAmPzwujtN5V9xlyAF73cQOBW /NdA== X-Gm-Message-State: AOAM533iN33JqNyAanqn9Ac8WKCnM46RVpyab9RUaHGPV5WsfOdztMSy MukSBvkDn7O8M2E5QNedMT9b9NfYHyxbjZs2Z1yQsiuEKBSihbmjStyZ0DzTkopsRPkiREUOZDQ D6u2kdMBAm0w= X-Received: by 2002:a05:600c:378c:: with SMTP id o12mr2070260wmr.93.1633423690548; Tue, 05 Oct 2021 01:48:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEZ2KAbpgcJ1IlPi4jbyBeg9+JeFFqby0fNl4f9gDDYMG97/VkdZUl0OT/2Az0sxYyor8blQ== X-Received: by 2002:a05:600c:378c:: with SMTP id o12mr2070227wmr.93.1633423690349; Tue, 05 Oct 2021 01:48:10 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6741.dip0.t-ipconnect.de. [91.12.103.65]) by smtp.gmail.com with ESMTPSA id h18sm16485251wrs.75.2021.10.05.01.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 01:48:09 -0700 (PDT) Subject: Re: [PATCH v3 2/5] mm/cma: add cma_pages_valid to determine if pages are in CMA To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Michal Hocko , Oscar Salvador , Zi Yan , Muchun Song , Naoya Horiguchi , David Rientjes , "Aneesh Kumar K . V" , Andrew Morton References: <20211001175210.45968-1-mike.kravetz@oracle.com> <20211001175210.45968-3-mike.kravetz@oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: <7649db4a-fd21-46c4-efbc-a98893b72104@redhat.com> Date: Tue, 5 Oct 2021 10:48:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211001175210.45968-3-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4BAD97002CBB X-Stat-Signature: omeskfh3qg1548mw1ko4cggui9wftait Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h2+8uOUn; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1633423693-857338 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.21 19:52, Mike Kravetz wrote: > Add new interface cma_pages_valid() which indicates if the specified > pages are part of a CMA region. This interface will be used in a > subsequent patch by hugetlb code. > > Signed-off-by: Mike Kravetz > --- > include/linux/cma.h | 1 + > mm/cma.c | 21 +++++++++++++++++---- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 53fd8c3cdbd0..bd801023504b 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -46,6 +46,7 @@ extern int cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > struct cma **res_cma); > extern struct page *cma_alloc(struct cma *cma, unsigned long count, unsigned int align, > bool no_warn); > +extern bool cma_pages_valid(struct cma *cma, const struct page *pages, unsigned long count); > extern bool cma_release(struct cma *cma, const struct page *pages, unsigned long count); > > extern int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data); > diff --git a/mm/cma.c b/mm/cma.c > index 995e15480937..960994b88c7f 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -524,6 +524,22 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > return page; > } > > +bool cma_pages_valid(struct cma *cma, const struct page *pages, > + unsigned long count) > +{ > + unsigned long pfn; > + > + if (!cma || !pages) > + return false; > + > + pfn = page_to_pfn(pages); > + > + if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count) > + return false; > + > + return true; > +} > + > /** > * cma_release() - release allocated pages > * @cma: Contiguous memory region for which the allocation is performed. > @@ -539,16 +555,13 @@ bool cma_release(struct cma *cma, const struct page *pages, > { > unsigned long pfn; > > - if (!cma || !pages) > + if (!cma_pages_valid(cma, pages, count)) > return false; > > pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count); > > pfn = page_to_pfn(pages); > > - if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count) > - return false; > - > VM_BUG_ON(pfn + count > cma->base_pfn + cma->count); > > free_contig_range(pfn, count); > Agreed that we might want to perform the pr_debug() now earlier, or do another pr_warn before returning false. Acked-by: David Hildenbrand -- Thanks, David / dhildenb