From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
jglisse@redhat.com, mike.kravetz@oracle.com, riel@surriel.com,
cai@lca.pw, shakeelb@google.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v4 1/2] mm/rmap.c: don't reuse anon_vma if we just want a copy
Date: Fri, 11 Oct 2019 11:04:16 +0300 [thread overview]
Message-ID: <77fb8811-2c95-55d2-de90-7e9ce01267a1@yandex-team.ru> (raw)
In-Reply-To: <20191011072256.16275-1-richardw.yang@linux.intel.com>
On 11/10/2019 10.22, Wei Yang wrote:
> Before commit 7a3ef208e662 ("mm: prevent endless growth of anon_vma
> hierarchy"), anon_vma_clone() doesn't change dst->anon_vma. While after
> this commit, anon_vma_clone() will try to reuse an exist one on forking.
>
> But this commit go a little bit further for the case not forking.
> anon_vma_clone() is called from __vma_split(), __split_vma(), copy_vma()
> and anon_vma_fork(). For the first three places, the purpose here is get
> a copy of src and we don't expect to touch dst->anon_vma even it is
> NULL. While after that commit, it is possible to reuse an anon_vma when
> dst->anon_vma is NULL. This is not we intend to have.
>
> This patch stop reuse anon_vma for non-fork cases.
>
> Fix commit 7a3ef208e662 ("mm: prevent endless growth of anon_vma
> hierarchy")
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Yes, reusing heuristic was designed for fork.
But this isn't strictly necessary - any vmas could share anon_vma.
For example all vmas in system could be linked with single anon_vma.
Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>
> ---
> v4:
> * check dst->anon_vma in each iteration
> v3:
> * use dst->anon_vma and src->anon_vma to get reuse state
> pointed by Konstantin Khlebnikov
> ---
> mm/rmap.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..c34414567474 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -250,13 +250,19 @@ static inline void unlock_anon_vma_root(struct anon_vma *root)
> * Attach the anon_vmas from src to dst.
> * Returns 0 on success, -ENOMEM on failure.
> *
> - * If dst->anon_vma is NULL this function tries to find and reuse existing
> - * anon_vma which has no vmas and only one child anon_vma. This prevents
> - * degradation of anon_vma hierarchy to endless linear chain in case of
> - * constantly forking task. On the other hand, an anon_vma with more than one
> - * child isn't reused even if there was no alive vma, thus rmap walker has a
> - * good chance of avoiding scanning the whole hierarchy when it searches where
> - * page is mapped.
> + * anon_vma_clone() is called by __vma_split(), __split_vma(), copy_vma() and
> + * anon_vma_fork(). The first three want an exact copy of src, while the last
> + * one, anon_vma_fork(), may try to reuse an existing anon_vma to prevent
> + * endless growth of anon_vma. Since dst->anon_vma is set to NULL before call,
> + * we can identify this case by checking (!dst->anon_vma && src->anon_vma).
> + *
> + * If (!dst->anon_vma && src->anon_vma) is true, this function tries to find
> + * and reuse existing anon_vma which has no vmas and only one child anon_vma.
> + * This prevents degradation of anon_vma hierarchy to endless linear chain in
> + * case of constantly forking task. On the other hand, an anon_vma with more
> + * than one child isn't reused even if there was no alive vma, thus rmap
> + * walker has a good chance of avoiding scanning the whole hierarchy when it
> + * searches where page is mapped.
> */
> int anon_vma_clone(struct vm_area_struct *dst, struct vm_area_struct *src)
> {
> @@ -286,8 +292,8 @@ int anon_vma_clone(struct vm_area_struct *dst, struct vm_area_struct *src)
> * will always reuse it. Root anon_vma is never reused:
> * it has self-parent reference and at least one child.
> */
> - if (!dst->anon_vma && anon_vma != src->anon_vma &&
> - anon_vma->degree < 2)
> + if (!dst->anon_vma && src->anon_vma &&
> + anon_vma != src->anon_vma && anon_vma->degree < 2)
> dst->anon_vma = anon_vma;
> }
> if (dst->anon_vma)
>
next prev parent reply other threads:[~2019-10-11 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 7:22 [Patch v4 1/2] mm/rmap.c: don't reuse anon_vma if we just want a copy Wei Yang
2019-10-11 7:22 ` [Patch v4 2/2] mm/rmap.c: reuse mergeable anon_vma as parent when fork Wei Yang
2019-10-11 8:10 ` Konstantin Khlebnikov
2019-10-11 8:04 ` Konstantin Khlebnikov [this message]
2019-10-11 8:39 ` [Patch v4 1/2] mm/rmap.c: don't reuse anon_vma if we just want a copy Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77fb8811-2c95-55d2-de90-7e9ce01267a1@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=richardw.yang@linux.intel.com \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).