From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5C5C433DB for ; Mon, 11 Jan 2021 15:06:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20CBD22795 for ; Mon, 11 Jan 2021 15:06:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20CBD22795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 862298D0040; Mon, 11 Jan 2021 10:06:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 811D78D0020; Mon, 11 Jan 2021 10:06:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727FF8D0040; Mon, 11 Jan 2021 10:06:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 5C8D38D0020 for ; Mon, 11 Jan 2021 10:06:57 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 19727824556B for ; Mon, 11 Jan 2021 15:06:57 +0000 (UTC) X-FDA: 77693821674.08.hose36_39020e32750d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id DFB531819E76F for ; Mon, 11 Jan 2021 15:06:56 +0000 (UTC) X-HE-Tag: hose36_39020e32750d X-Filterd-Recvd-Size: 6215 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 15:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610377615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g7CoqAv3+2DuhrWm4HZxfGTuv3YxRqKxge5jGqMOnw=; b=d95k9JOKyzP8xpDY79wwZzJ5hh7MxF8Im1NtM3Y/zVNg4qtX9A5fteOhADoMmwzW4rrg1J q6D9fUurIs6FG9/jBMvfXfDN1Hi+ZHJbi//u3ZONpis+4BueRd9ijvdPX0tTT1DPvswJwA V7xqwlpXGwEkXAGq7Ojy/CfNzzK08cI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-FIhTPNSeNnCUTrXgbggs3Q-1; Mon, 11 Jan 2021 10:06:51 -0500 X-MC-Unique: FIhTPNSeNnCUTrXgbggs3Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 261E715724; Mon, 11 Jan 2021 15:06:49 +0000 (UTC) Received: from ovpn-119-23.rdu2.redhat.com (ovpn-119-23.rdu2.redhat.com [10.10.119.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id A425219C59; Mon, 11 Jan 2021 15:06:43 +0000 (UTC) Message-ID: <782e710eac32b1ab3bf9713bcd6afcbc9483e16c.camel@redhat.com> Subject: Re: [PATCH v2 2/2] mm: fix initialization of struct page for holes in memory layout From: Qian Cai To: Mike Rapoport Cc: Andrew Morton , Andrea Arcangeli , Baoquan He , David Hildenbrand , Mel Gorman , Michal Hocko , Mike Rapoport , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Stephen Rothwell , Linux Next Mailing List Date: Mon, 11 Jan 2021 10:06:43 -0500 In-Reply-To: <20210110153956.GD1106298@kernel.org> References: <20201209214304.6812-1-rppt@kernel.org> <20201209214304.6812-3-rppt@kernel.org> <768cb57d6ef0989293b3f9fbe0af8e8851723ea1.camel@redhat.com> <20210105082403.GA1106298@kernel.org> <67ef893f27551f80ecf49ef78c0ebc05d3e41b46.camel@redhat.com> <20210106080553.GB1106298@kernel.org> <8171f5a5a8b407a1fcca56bab912555bde80d323.camel@redhat.com> <20210110153956.GD1106298@kernel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2021-01-10 at 17:39 +0200, Mike Rapoport wrote: > On Wed, Jan 06, 2021 at 04:04:21PM -0500, Qian Cai wrote: > > On Wed, 2021-01-06 at 10:05 +0200, Mike Rapoport wrote: > > > I think we trigger PF_POISONED_CHECK() in PageSlab(), then > > > fffffffffffffffe > > > is "accessed" from VM_BUG_ON_PAGE(). > > > > > > It seems to me that we are not initializing struct pages for holes at the > > > node > > > boundaries because zones are already clamped to exclude those holes. > > > > > > Can you please try to see if the patch below will produce any useful info: > > > > [ 0.000000] init_unavailable_range: spfn: 8c, epfn: 9b, zone: DMA, node: > > 0 > > [ 0.000000] init_unavailable_range: spfn: 1f7be, epfn: 1f9fe, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 28784, epfn: 288e4, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 298b9, epfn: 298bd, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 29923, epfn: 29931, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 29933, epfn: 29941, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 29945, epfn: 29946, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 29ff9, epfn: 2a823, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 33a23, epfn: 33a53, zone: > > DMA32, node: 0 > > [ 0.000000] init_unavailable_range: spfn: 78000, epfn: 100000, zone: > > DMA32, node: 0 > > ... > > [ 572.222563][ T2302] kpagecount_read: pfn 47f380 is poisoned > ... > > [ 590.570032][ T2302] kpagecount_read: pfn 47ffff is poisoned > > [ 604.268653][ T2302] kpagecount_read: pfn 87ff80 is poisoned > ... > > [ 604.611698][ T2302] kpagecount_read: pfn 87ffbc is poisoned > > [ 617.484205][ T2302] kpagecount_read: pfn c7ff80 is poisoned > ... > > [ 618.212344][ T2302] kpagecount_read: pfn c7ffff is poisoned > > [ 633.134228][ T2302] kpagecount_read: pfn 107ff80 is poisoned > ... > > [ 633.874087][ T2302] kpagecount_read: pfn 107ffff is poisoned > > [ 647.686412][ T2302] kpagecount_read: pfn 147ff80 is poisoned > ... > > [ 648.425548][ T2302] kpagecount_read: pfn 147ffff is poisoned > > [ 663.692630][ T2302] kpagecount_read: pfn 187ff80 is poisoned > ... > > [ 664.432671][ T2302] kpagecount_read: pfn 187ffff is poisoned > > [ 675.462757][ T2302] kpagecount_read: pfn 1c7ff80 is poisoned > ... > > [ 676.202548][ T2302] kpagecount_read: pfn 1c7ffff is poisoned > > [ 687.121605][ T2302] kpagecount_read: pfn 207ff80 is poisoned > ... > > [ 687.860981][ T2302] kpagecount_read: pfn 207ffff is poisoned > > The e820 map has a hole near the end of each node and these holes are not > initialized with init_unavailable_range() after it was interleaved with > memmap initialization because such holes are not accounted by > zone->spanned_pages. > > Yet, I'm still cannot really understand how this never triggered > > VM_BUG_ON_PAGE(!zone_spans_pfn(page_zone(page), pfn), page); > > before v5.7 as all the struct pages for these holes would have zone=0 and > node=0 ... > > @Qian, can you please boot your system with memblock=debug and share the > logs? > http://people.redhat.com/qcai/memblock.txt