From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA39BC433C1 for ; Fri, 19 Mar 2021 15:46:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C14B61954 for ; Fri, 19 Mar 2021 15:46:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C14B61954 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 817858D0005; Fri, 19 Mar 2021 11:46:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D99D8D0001; Fri, 19 Mar 2021 11:46:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61A088D0005; Fri, 19 Mar 2021 11:46:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 458E68D0001 for ; Fri, 19 Mar 2021 11:46:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F1B504DB7 for ; Fri, 19 Mar 2021 15:45:59 +0000 (UTC) X-FDA: 77937049638.17.7D2C609 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf09.hostedemail.com (Postfix) with ESMTP id CEF986009867 for ; Fri, 19 Mar 2021 15:38:03 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id u20so12471540lja.13 for ; Fri, 19 Mar 2021 08:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Jf57TUyTvZSa9yhzASEEIFzKPdOCKjXIr1XoPSFG8S4=; b=QRAIefYIOEXTF4OXlTA0vcyHwbml1t5N2cCxy7cInDOWHksDc5nCuyl9EO/CPG9BvV iwlvhSxYy6znZBNlSID/YT0AGej5231j3erF2uZHDfDTMkZCT8m3OaV/Z/caoaKIJ2Fs 0blij0eTp3zxv1sN5e+bJavnO6P35HOf07XFC9fx6xTjNGQisIX1vQT/6PvlPcB3k8lB waSCCJTyTOVVMQFNkIKTtu44Gqr4XSy6sYow5tjL4hfzV4Owu0ZDqWwUU5JzSzmWiWGJ r5/l/OKtz9Xb5ctLArl7ay+tWcUsOlPNNynK+RZmpOktiSyBoH6N6dHmNQY/edXZshSp fuLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jf57TUyTvZSa9yhzASEEIFzKPdOCKjXIr1XoPSFG8S4=; b=RQ2dSMOFXEMmSyDk16sVgihCIch6jlq2mMKLuGxcVrdalhLOtfe9KiPQdD27wHazHO eHi+SGhTwdB6yk4bJ1hAH+3BtPHo/Nbz7LxDchSJv3FyYo2jplSLlyppty/gLxsnr9QY PDyWJLgZKpPTj1jftZm9OSlIGj0ZNeXiIW6B72WHpWShjjIOsnfBeF/C7pIdYWh5O5CF i6bKpwrMKjCs5KRijQP43mSQ0zPC/3GTP8p9ZnxlaPVzN7qx6Rwn4H7ocUlQi5/hV7q3 9vxkIahC+RpeCh8HCdwtf6hM8bX8QjKqYGRwC8mDePOCujU+UX39QKPsSsI8f7KBVxw0 3F1Q== X-Gm-Message-State: AOAM532BUkHzv80j4gW51/Ib9eyXk+yRVbNad2P5fNq9f1LgXWcjYtOO ovSI5cco+upwo8QRLHx2KGc= X-Google-Smtp-Source: ABdhPJyNJ2UxFhvxE8ssbsXslj4aTjQFYgwl1mEm71ES6dz0joECt+K7wKPCgEz6BbxPr9msG64/ZQ== X-Received: by 2002:a2e:b60d:: with SMTP id r13mr1310809ljn.30.1616168281607; Fri, 19 Mar 2021 08:38:01 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id f25sm662396lfh.226.2021.03.19.08.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 08:38:00 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Greg Kroah-Hartman Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <20210309062333.3216138-1-minchan@kernel.org> <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> From: Dmitry Osipenko Message-ID: <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> Date: Fri, 19 Mar 2021 18:38:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CEF986009867 X-Stat-Signature: btogxer9x83e8dijxz9thbqi1nic53rm Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-lj1-f175.google.com; client-ip=209.85.208.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616168283-15362 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 17:27, Greg Kroah-Hartman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Fri, Mar 19, 2021 at 05:19:47PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 16:51, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> 19.03.2021 16:47, Greg Kroah-Hartman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On Fri, Mar 19, 2021 at 04:45:21PM +0300, Dmitry Osipenko wrote: >>>>> 19.03.2021 16:42, Greg Kroah-Hartman =D0=BF=D0=B8=D1=88=D0=B5=D1=82= : >>>>>> On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: >>>>>>> 19.03.2021 15:44, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>>> ... >>>>>>>>> #include >>>>>>>>> +#include >>>>>>>>> + >>>>>>>>> +struct cma_stat { >>>>>>>>> + spinlock_t lock; >>>>>>>>> + /* the number of CMA page successful allocations */ >>>>>>>>> + unsigned long nr_pages_succeeded; >>>>>>>>> + /* the number of CMA page allocation failures */ >>>>>>>>> + unsigned long nr_pages_failed; >>>>>>>>> + struct kobject kobj; >>>>>>>>> +}; >>>>>>>>> =20 >>>>>>>>> struct cma { >>>>>>>>> unsigned long base_pfn; >>>>>>>>> @@ -16,6 +26,9 @@ struct cma { >>>>>>>>> struct debugfs_u32_array dfs_bitmap; >>>>>>>>> #endif >>>>>>>>> char name[CMA_MAX_NAME]; >>>>>>>>> +#ifdef CONFIG_CMA_SYSFS >>>>>>>>> + struct cma_stat *stat; >>>>>>>>> +#endif >>>>>>> >>>>>>> What is the point of allocating stat dynamically? >>>>>> >>>>>> Because static kobjects make me cry. >>>>>> >>>>> >>>>> I meant that it's already a part of struct cma, it looks like the s= tat >>>>> could be embedded into struct cma and then kobj could be initialize= d >>>>> separately. >>>> >>>> But that structure is statically allocated, so it can not be. This = has >>>> been discussed in the past threads for when this was reviewed if you= are >>>> curious :) >>> >>> Indeed, I missed that cma_areas[] is static, thank you. >>> >> >> And in this case should be better to make only the kobj allocated >> dynamically instead of the whole cma_stat. >=20 > Why does it matter? >=20 Then initialization order won't be a problem.