From: Vasily Averin <vvs@virtuozzo.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
akpm@linux-foundation.org, guro@fb.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs()
Date: Tue, 11 Feb 2020 14:46:23 +0300 [thread overview]
Message-ID: <792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com> (raw)
In-Reply-To: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain>
On 2/11/20 2:38 PM, Kirill Tkhai wrote:
> Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().
>
> Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> ---
> mm/vmscan.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b1863de475fb..f6efe2348ba3 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
> continue;
> }
> memcg_memory_event(memcg, MEMCG_LOW);
> - break;
It is not cycle break, it is switch/case break.
> + /* fallthrough */
> case MEMCG_PROT_NONE:
> + mem_cgroup_iter_break(target_memcg, memcg);
> /*
> * All protection thresholds breached. We may
> * still choose to vary the scan pressure
>
>
next prev parent reply other threads:[~2020-02-11 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 11:38 [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() Kirill Tkhai
2020-02-11 11:46 ` Vasily Averin [this message]
2020-02-11 11:48 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792e25d0-413f-28e0-1fd0-560523b63a45@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).