From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1B4C433DF for ; Mon, 19 Oct 2020 10:23:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA6262225A for ; Mon, 19 Oct 2020 10:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="imB+SIqI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA6262225A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADC546B005D; Mon, 19 Oct 2020 06:22:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8C546B0062; Mon, 19 Oct 2020 06:22:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907446B0068; Mon, 19 Oct 2020 06:22:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 649326B005D for ; Mon, 19 Oct 2020 06:22:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0D82A80DB365 for ; Mon, 19 Oct 2020 10:22:58 +0000 (UTC) X-FDA: 77388286836.29.straw64_1312ce027236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id DB22318086CAC for ; Mon, 19 Oct 2020 10:22:57 +0000 (UTC) X-HE-Tag: straw64_1312ce027236 X-Filterd-Recvd-Size: 4504 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 10:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603102977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dClCYoDEHGrmREG2sQsLlOLmsyhbsQZOxw+llhuTikA=; b=imB+SIqIHx4E6/BCOR69UjLRnwgwaYHXbvyT6W8gfDGqsRyFR54Hfct310hiDyTfJdYerY NguviApclcCEnj3xYsrUmJ4GsgMv17biYHufj8A0Zl+fJVYwyiGrJJA2Q0CM1ifN1E2oJb XO4jNVzOkqOmG2Eg++1az8hx9gsSyyU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-sPW-dcUcMnKKgPRZkQiKug-1; Mon, 19 Oct 2020 06:22:55 -0400 X-MC-Unique: sPW-dcUcMnKKgPRZkQiKug-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63CAB10199A8; Mon, 19 Oct 2020 10:22:53 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 336545B4A4; Mon, 19 Oct 2020 10:22:45 +0000 (UTC) Subject: Re: [PATCH v1 21/29] virtio-mem: memory notifier callbacks are specific to Sub Block Mode (SBM) To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Pankaj Gupta References: <20201012125323.17509-1-david@redhat.com> <20201012125323.17509-22-david@redhat.com> <20201019015724.GA54484@L-31X9LVDL-1304.local> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <794b68b2-a3da-5354-4a3b-62f94224c0a6@redhat.com> Date: Mon, 19 Oct 2020 12:22:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201019015724.GA54484@L-31X9LVDL-1304.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.10.20 03:57, Wei Yang wrote: > On Mon, Oct 12, 2020 at 02:53:15PM +0200, David Hildenbrand wrote: >> Let's rename accordingly. >> >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: Pankaj Gupta >> Signed-off-by: David Hildenbrand >> --- >> drivers/virtio/virtio_mem.c | 29 +++++++++++++++-------------- >> 1 file changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c >> index 3a772714fec9..d06c8760b337 100644 >> --- a/drivers/virtio/virtio_mem.c >> +++ b/drivers/virtio/virtio_mem.c >> @@ -589,8 +589,8 @@ static bool virtio_mem_contains_range(struct virtio_mem *vm, uint64_t start, >> return start >= vm->addr && start + size <= vm->addr + vm->region_size; >> } >> >> -static int virtio_mem_notify_going_online(struct virtio_mem *vm, >> - unsigned long mb_id) >> +static int virtio_mem_sbm_notify_going_online(struct virtio_mem *vm, >> + unsigned long mb_id) > > Look into this patch with "virtio-mem: Big Block Mode (BBM) memory hotplug" > together, I thought the code is a little "complex". > > The final logic of virtio_mem_memory_notifier_cb() looks like this: > > virtio_mem_memory_notifier_cb() > if (vm->in_sbm) > notify_xxx() > if (vm->in_sbm) > notify_xxx() > > Can we adjust this like > > virtio_mem_memory_notifier_cb() > notify_xxx() > if (vm->in_sbm) > return > notify_xxx() > if (vm->in_sbm) > return > > This style looks a little better to me. Then we lose all the shared code after any of the mode-specific handling? Like we have in MEM_OFFLINE, MEM_ONLINE, MEM_CANCEL_OFFLINE, ... Don't think this will improve the situation. -- Thanks, David / dhildenb