From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6623C433E0 for ; Mon, 25 May 2020 08:12:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 96F6C20776 for ; Mon, 25 May 2020 08:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="uC/DUKVP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F6C20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 26D9680021; Mon, 25 May 2020 04:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21DE68E0003; Mon, 25 May 2020 04:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10DE780021; Mon, 25 May 2020 04:12:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id EE40F8E0003 for ; Mon, 25 May 2020 04:12:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A84B1824556B for ; Mon, 25 May 2020 08:12:35 +0000 (UTC) X-FDA: 76854524670.15.dogs95_33b1c9109cd2c X-HE-Tag: dogs95_33b1c9109cd2c X-Filterd-Recvd-Size: 5063 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 08:12:35 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id v16so19799459ljc.8 for ; Mon, 25 May 2020 01:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mQlv94/UsIcWqqoQiFz4Gmt5TSCy0PaSYRGYfGZ8ASE=; b=uC/DUKVPr4AEHq5tZ0tk/8BJui59Ip+3Hv4adGb5DQ14R3VOvZPglrknK3jEuEDUri 0d/s8L/nPTs2TjywXIwDlAjAl0pbo1y4d4KL36xuI94CirTpSML2vZQUsvsl4pKnfCT/ N1Dr1x0yKT+NPvdkJagD16frkkV4x2sD0QXMuT8oRsZpcVs7WIynSnod8WL8W7zEpzVp 9VYGC1iie7CLhJuFTjwO+eudzrsEauJNzNODWYn+/OMtBZijYLasRQSg6Mccp6nvsS7K yPzPRVs3STK0Cn+lL+DaqTkrNgfUs+i/dYHTpAqH/NTlrp/7vli8ofSqHDlLR/MYqwVQ KVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mQlv94/UsIcWqqoQiFz4Gmt5TSCy0PaSYRGYfGZ8ASE=; b=efag+p05X7NNceDHuXRSUZyHA6G0J6JqdcMvoF96Q7eYVEJM9OX4DQLX0rYE9TrhTv JdX0awjZIf/8wYF9POy5+ePHZonHL4EcB1WYz0iOgRuiQ6m/OfEKfa8ieEq8QkZRPdhM 1LZ3J4mmAKiUZmYf/nlRkD0aubxLMDnkksTwahHjydgbxyEUNXJcgZeNrOuWUJYboCPc hKzKHWffffiSLxpbumgoZ751sCgp8/aFsszAjluMlEGSkCFMuQkGg55GzyMbTv6A6zk1 83lcG8wf3SeNzn4ARK2XefRsC5MzWUKNxVao9AOI1Bxy7w0YwEFBEh8wSelss0oVnzJ5 0mCA== X-Gm-Message-State: AOAM5330pM0+UDF3o98CjsdizZwBtdSgRjomUuPQtv0qC0AlydDKmHCa xW5tDMF1MvFcd2FTORveJ+74Rg== X-Google-Smtp-Source: ABdhPJyJtREc8uUJDAMfpETQ8xnMzoK/Y5+TXrGnZ2HOaSMhu/3tzdRc4VuGqCS4FTW3P1QcfIskmw== X-Received: by 2002:a2e:2a02:: with SMTP id q2mr11637583ljq.311.1590394353496; Mon, 25 May 2020 01:12:33 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:425b:15e7:251c:5b3:d625:2d43? ([2a00:1fa0:425b:15e7:251c:5b3:d625:2d43]) by smtp.gmail.com with ESMTPSA id m10sm4627606lfd.15.2020.05.25.01.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2020 01:12:32 -0700 (PDT) Subject: Re: [PATCH v6 1/4] MIPS: Do not flush tlb page when updating PTE entry To: Bibo Mao , Thomas Bogendoerfer , Jiaxun Yang , Huacai Chen , Andrew Morton , Paul Burton , Dmitry Korotin , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stafford Horne , Steven Price , Anshuman Khandual Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , "Maciej W. Rozycki" , linux-mm@kvack.org, David Hildenbrand References: <1590375160-6997-1-git-send-email-maobibo@loongson.cn> From: Sergei Shtylyov Message-ID: <79778fc3-c029-272b-358e-4f8f8e5772d3@cogentembedded.com> Date: Mon, 25 May 2020 11:12:25 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <1590375160-6997-1-git-send-email-maobibo@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! On 25.05.2020 5:52, Bibo Mao wrote: > It is not necessary to flush tlb page on all CPUs if suitable PTE > entry exists already during page fault handling, just updating > TLB is fine. > > Here redefine flush_tlb_fix_spurious_fault as empty on MIPS system. Need empty line here. > V6: > - Add update_mmu_tlb function as empty on all platform except mips > system, we use this function to update local tlb for page fault > smp-race handling > V5: > - define update_mmu_cache function specified on MIPS platform, and > add page fault smp-race stats info > V4: > - add pte_sw_mkyoung function to implement readable privilege, and > this function is only in effect on MIPS system. > - add page valid bit judgement in function pte_modify > V3: > - add detailed changelog, modify typo issue in patch V2 > v2: > - split flush_tlb_fix_spurious_fault and tlb update into two patches > - comments typo modification > - separate tlb update and add pte readable privilege into two patches It was a bad idea to keep the version change log in the 1st patch only, we have either cover letter for that, or all the individual patches... > Signed-off-by: Bibo Mao [...] MBR, Sergei