From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7A1C636CA for ; Fri, 16 Jul 2021 12:58:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 297E9613F3 for ; Fri, 16 Jul 2021 12:58:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 297E9613F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47BF48D00F6; Fri, 16 Jul 2021 08:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4042C8D00EC; Fri, 16 Jul 2021 08:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A4E28D00F6; Fri, 16 Jul 2021 08:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 0642E8D00EC for ; Fri, 16 Jul 2021 08:58:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C64D127DFA for ; Fri, 16 Jul 2021 12:58:13 +0000 (UTC) X-FDA: 78368454066.01.0F4B0B1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 575A9501553A for ; Fri, 16 Jul 2021 12:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626440292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjFVjJ9jlDmNbP8AD/NSiTAOAWlIu9GruBGLqG/Mukg=; b=gPl6h4BtrJet6mEGjs1DgUf98VtpI+lqxQMpWq6lQYiBMvP3mo1EmQ7JfZma9dlzYvt8o6 Vdo2qgoVI9kIidocTqRPIeivkMtwKtL+1ZkoJj9kHM83AOC6xWq+cEGR2mj14yW4s/iq5r Rxs6TQSjcqN5x7lnD26/vb9vlzQNi5g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-5LiDPCvkPLyRc0HSIAFN-A-1; Fri, 16 Jul 2021 08:58:11 -0400 X-MC-Unique: 5LiDPCvkPLyRc0HSIAFN-A-1 Received: by mail-wm1-f70.google.com with SMTP id l6-20020a05600c1d06b0290225338d8f53so3146038wms.8 for ; Fri, 16 Jul 2021 05:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KjFVjJ9jlDmNbP8AD/NSiTAOAWlIu9GruBGLqG/Mukg=; b=hCZms7CD4EmRTEI0gMtqk4WBeD8vu/pAB8tb6HMlzSIiVfPBWme9oSirOOcWzxXQGZ FsVDTuvALm+kxa6OAPzYzG+bqad3Vz7MZmmc7wzlxfsKP6E/SiQdnqZfFeMEcblwo5N7 LbeNRg4s1XnvRZMrI4P0TIU5WOZR8HReM3NL8Yduwa6IiCpozJWlKLwILXFsZocQZzZ5 1x/xrTzcFqbxuHuLK8FxoaPDpk9uLsUpTOun66A3FV7oYlBaH5DqlzbOkray3CnQnLR9 w/4F5+yNRhYPYpSaT4dIvwvPZJJVMUbWhNn1yNsMKdg9Wah2p8IGXQfxYofvce2Cx2Ce r7dA== X-Gm-Message-State: AOAM5332sRFMtVpNC8kg8O3qNY8U26Wy7JwGuapQ5NfjWbgMDgwj/AjU Ih43OBZ2DtiKZzHYv+taDbBIIiXvE27RXcZ8/Hb3nx0wCeQk7obvq8mTPkPGSvcj2oa0Y4fSoT7 foKnAOF6zXj4= X-Received: by 2002:a7b:c150:: with SMTP id z16mr16304088wmi.104.1626440290384; Fri, 16 Jul 2021 05:58:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2JL1Gw4adDvdYjazPsy1G3KUxKBf3eKKGPwrDHBDWTknfSWtgRQC8b9hbaZYN8jG1XR2FUA== X-Received: by 2002:a7b:c150:: with SMTP id z16mr16304068wmi.104.1626440290212; Fri, 16 Jul 2021 05:58:10 -0700 (PDT) Received: from [192.168.3.132] (p5b0c621f.dip0.t-ipconnect.de. [91.12.98.31]) by smtp.gmail.com with ESMTPSA id e3sm10163965wra.15.2021.07.16.05.58.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 05:58:09 -0700 (PDT) Subject: Re: [PATCH 2/3] mm/vmstat: simplify the array size calculation To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210715122911.15700-1-linmiaohe@huawei.com> <20210715122911.15700-3-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <79fb76da-f811-7030-abd6-1dd970e7ab53@redhat.com> Date: Fri, 16 Jul 2021 14:58:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715122911.15700-3-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gPl6h4Bt; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 575A9501553A X-Stat-Signature: 8w46tc8poqghhcaoc9fjjdmht51ttgrs X-HE-Tag: 1626440293-37321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.07.21 14:29, Miaohe Lin wrote: > We can replace the array_num * sizeof(array[0]) with sizeof(array) to > simplify the code. Could have mentioned taht your fixing indentation of one "return true;" LGTM Reviewed-by: David Hildenbrand > > Signed-off-by: Miaohe Lin > --- > mm/vmstat.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 57e8e7fda7aa..76aef9510f6d 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1889,17 +1889,15 @@ static bool need_update(int cpu) > /* > * The fast way of checking if there are any vmstat diffs. > */ > - if (memchr_inv(pzstats->vm_stat_diff, 0, NR_VM_ZONE_STAT_ITEMS * > - sizeof(pzstats->vm_stat_diff[0]))) > + if (memchr_inv(pzstats->vm_stat_diff, 0, sizeof(pzstats->vm_stat_diff))) > return true; > > if (last_pgdat == zone->zone_pgdat) > continue; > last_pgdat = zone->zone_pgdat; > n = per_cpu_ptr(zone->zone_pgdat->per_cpu_nodestats, cpu); > - if (memchr_inv(n->vm_node_stat_diff, 0, NR_VM_NODE_STAT_ITEMS * > - sizeof(n->vm_node_stat_diff[0]))) > - return true; > + if (memchr_inv(n->vm_node_stat_diff, 0, sizeof(n->vm_node_stat_diff))) > + return true; > } > return false; > } > -- Thanks, David / dhildenb