From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDE9C63798 for ; Thu, 12 Nov 2020 20:15:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A134622201 for ; Thu, 12 Nov 2020 20:15:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bxnvjz2y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A134622201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA8646B0036; Thu, 12 Nov 2020 15:15:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A573D6B005D; Thu, 12 Nov 2020 15:15:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D0006B0068; Thu, 12 Nov 2020 15:15:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 5AE756B0036 for ; Thu, 12 Nov 2020 15:15:28 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EBCF7824999B for ; Thu, 12 Nov 2020 20:15:27 +0000 (UTC) X-FDA: 77476871094.07.ants75_5b14cb427309 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id C8EA31803F9A8 for ; Thu, 12 Nov 2020 20:15:27 +0000 (UTC) X-HE-Tag: ants75_5b14cb427309 X-Filterd-Recvd-Size: 8574 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 20:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605212126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rwJcHMqFNMjcwmrQqeZ7xQpjUn5kuh+iR2Mn5fyrgQY=; b=Bxnvjz2ywXiyyZzXQ0f8w8qicp/8SGRdMse/2waMnAAA2pfrAc+4LKoDFLd9EthfJ7PbVr 66F7NnHcClD4oBUxyTGpJiVeOe4eDOiU+6Bwa10vt1yVjKFaI0JfPrGQz1OVDF15praMDJ dXg7QKmGFUekIL/SCZpREjvOjUmQNBE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-53q4Pe-vNguAu1hzruQ2Gg-1; Thu, 12 Nov 2020 15:15:22 -0500 X-MC-Unique: 53q4Pe-vNguAu1hzruQ2Gg-1 Received: by mail-wr1-f69.google.com with SMTP id r15so2459518wrn.15 for ; Thu, 12 Nov 2020 12:15:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=vHPfrB8xVjlPFSCqejvi+QTUrEERRY3Dc+wUeNVcoBQ=; b=NfuZIis9wH2WS0EQa34jaw5cC8KThpkTom0qu6vasUDJWKTqWINsD8LZA/y4BI9znh tqWvDGPZ82c+D94yVIWzOSwB6iSTstFcpDgeK6p57EHAOWsBCEdtlZaRL6N8/I/N5m3l VyO82g8VEao2nxlCZfcR3EXV6/cDG+doIB8M5tQnukUvGnrXlKyy/u7LHnFh5PDyDqOQ zX/J7G3bmRdq65jxQM7QSgmcX6K9fRlXrcn92HkJ2mtWDHrzfm0xFVTaks+P+KD3aHE+ y2EhKum6wv0xmfrzBUneyw22BSZaK6vahgJ9rRVXHLE/Xw9WAZUlo35UR7vL/NQp9zh5 xa1A== X-Gm-Message-State: AOAM531tuURRERFZ684YYNlnPmvbuXrzW1EYZWQGESOceNwPgUFAToER mvvBjtuUCbWus9v7/u88Qh5GiSxb1Oypx7GooWlixyeNeUd3pDP5H6lTisRS/aNpVgUVwXHD+9T CzUBzxAWjIno= X-Received: by 2002:adf:e350:: with SMTP id n16mr1455260wrj.419.1605212120788; Thu, 12 Nov 2020 12:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxji2+rXiblNfD29iXHuiDwrhuPVpa0KNLoEK9tHEW4ondrhf0pVB9gNYs6gWjo3tNv0xhLcA== X-Received: by 2002:adf:e350:: with SMTP id n16mr1455211wrj.419.1605212120462; Thu, 12 Nov 2020 12:15:20 -0800 (PST) Received: from [192.168.3.114] (p5b0c631d.dip0.t-ipconnect.de. [91.12.99.29]) by smtp.gmail.com with ESMTPSA id 35sm8578483wro.71.2020.11.12.12.15.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 12:15:19 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v8 2/9] mmap: make mlock_future_check() global Date: Thu, 12 Nov 2020 21:15:18 +0100 Message-Id: <7A16CA44-782D-4ABA-8D93-76BDD0A90F94@redhat.com> References: <20201112190827.GP4758@kernel.org> Cc: David Hildenbrand , Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org In-Reply-To: <20201112190827.GP4758@kernel.org> To: Mike Rapoport X-Mailer: iPhone Mail (18A8395) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 12.11.2020 um 20:08 schrieb Mike Rapoport : >=20 > =EF=BB=BFOn Thu, Nov 12, 2020 at 05:22:00PM +0100, David Hildenbrand wrot= e: >>> On 10.11.20 19:06, Mike Rapoport wrote: >>> On Tue, Nov 10, 2020 at 06:17:26PM +0100, David Hildenbrand wrote: >>>> On 10.11.20 16:14, Mike Rapoport wrote: >>>>> From: Mike Rapoport >>>>>=20 >>>>> It will be used by the upcoming secret memory implementation. >>>>>=20 >>>>> Signed-off-by: Mike Rapoport >>>>> --- >>>>> mm/internal.h | 3 +++ >>>>> mm/mmap.c | 5 ++--- >>>>> 2 files changed, 5 insertions(+), 3 deletions(-) >>>>>=20 >>>>> diff --git a/mm/internal.h b/mm/internal.h >>>>> index c43ccdddb0f6..ae146a260b14 100644 >>>>> --- a/mm/internal.h >>>>> +++ b/mm/internal.h >>>>> @@ -348,6 +348,9 @@ static inline void munlock_vma_pages_all(struct v= m_area_struct *vma) >>>>> extern void mlock_vma_page(struct page *page); >>>>> extern unsigned int munlock_vma_page(struct page *page); >>>>> +extern int mlock_future_check(struct mm_struct *mm, unsigned long fl= ags, >>>>> + unsigned long len); >>>>> + >>>>> /* >>>>> * Clear the page's PageMlocked(). This can be useful in a situati= on where >>>>> * we want to unconditionally remove a page from the pagecache -- e= .g., >>>>> diff --git a/mm/mmap.c b/mm/mmap.c >>>>> index 61f72b09d990..c481f088bd50 100644 >>>>> --- a/mm/mmap.c >>>>> +++ b/mm/mmap.c >>>>> @@ -1348,9 +1348,8 @@ static inline unsigned long round_hint_to_min(u= nsigned long hint) >>>>> return hint; >>>>> } >>>>> -static inline int mlock_future_check(struct mm_struct *mm, >>>>> - unsigned long flags, >>>>> - unsigned long len) >>>>> +int mlock_future_check(struct mm_struct *mm, unsigned long flags, >>>>> + unsigned long len) >>>>> { >>>>> unsigned long locked, lock_limit; >>>>>=20 >>>>=20 >>>> So, an interesting question is if you actually want to charge secretme= m >>>> pages against mlock now, or if you want a dedicated secretmem cgroup >>>> controller instead? >>>=20 >>> Well, with the current implementation there are three limits an >>> administrator can use to control secretmem limits: mlock, memcg and >>> kernel parameter. >>>=20 >>> The kernel parameter puts a global upper limit for secretmem usage, >>> memcg accounts all secretmem allocations, including the unused memory i= n >>> large pages caching and mlock allows per task limit for secretmem >>> mappings, well, like mlock does. >>>=20 >>> I didn't consider a dedicated cgroup, as it seems we already have enoug= h >>> existing knobs and a new one would be unnecessary. >>=20 >> To me it feels like the mlock() limit is a wrong fit for secretmem. But >> maybe there are other cases of using the mlock() limit without actually >> doing mlock() that I am not aware of (most probably :) )? >=20 > Secretmem does not explicitly calls to mlock() but it does what mlock() > does and a bit more. Citing mlock(2): >=20 > mlock(), mlock2(), and mlockall() lock part or all of the calling > process's virtual address space into RAM, preventing that memory from > being paged to the swap area. >=20 > So, based on that secretmem pages are not swappable, I think that > RLIMIT_MEMLOCK is appropriate here. >=20 The page explicitly lists mlock() system calls. E.g., we also don=E2=80=98t= account for gigantic pages - which might be allocated from CMA and are not= swappable. >> I mean, my concern is not earth shattering, this can be reworked later. = As I >> said, it just feels wrong. >>=20 >> --=20 >> Thanks, >>=20 >> David / dhildenb >>=20 >=20 > --=20 > Sincerely yours, > Mike. >=20