From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E44CC04AB1 for ; Sat, 11 May 2019 22:33:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6D2C217D6 for ; Sat, 11 May 2019 22:33:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZdWDQ1Gl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6D2C217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 321606B0003; Sat, 11 May 2019 18:33:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D2816B0005; Sat, 11 May 2019 18:33:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19A126B0006; Sat, 11 May 2019 18:33:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by kanga.kvack.org (Postfix) with ESMTP id EB86E6B0003 for ; Sat, 11 May 2019 18:33:45 -0400 (EDT) Received: by mail-vk1-f199.google.com with SMTP id x77so4458885vke.14 for ; Sat, 11 May 2019 15:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=cg1vXAzcRFjP3GXfQCRMyWsYUJ2Cc80Ce/8Y/l18iMY=; b=q2JYDh11hU2w/Wvjka9AvNY+VTGYjeUhTU6n7Gji9qp/hgKrQRGj7rjr8tWQ7y7yhC QKu52d83Qgz5iibOdrD93E5ZMqowZucC8VlcHfS/AHyAF1rPJ8rrCA65PvZFsTQMzq3R mDDOphfDgLaH7toa+4WP63YPsjO+A5AXmHplETx1JkhmfjGJczNwvbrtfJFTvKOiFxhI OIUBZrRGkV2dHZ4n/S8qJiaxWF2bQobXwcuT49omVa2UhUgu5Uox9FNEvnlA8upMw0jk jGFjUcBUVMlcUtSAIIBDB4HDKf/CSEGUQJlow6qFG4ivL2UXrsLLqSRR9i8JoQccj1bV JBDA== X-Gm-Message-State: APjAAAXvFixhLrbyc00btXr3pSwqkdZIITWCWlZP51hafm+7RYuJYiOl xWP0+uXGCKfvdF+qsW3YLL8pPT5i6Ikc+3b1aHIibawbQiVc93cdQQKJlD6XmeDE/16ESwiyCh/ B0Fl/8fI1TTot+j8fOa0CpZigxdvl25WW7gdsXS6QH3fqJa2cHR/29wfDJ1ZMMXSS6g== X-Received: by 2002:a67:f049:: with SMTP id q9mr9735156vsm.93.1557614025554; Sat, 11 May 2019 15:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/MOkexXOYJaKnE7q+wY7KgnWS6eKJUtl0q6siBDabcrCEmNzF21KBU+FG1pFRroDioOcD X-Received: by 2002:a67:f049:: with SMTP id q9mr9735143vsm.93.1557614024774; Sat, 11 May 2019 15:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557614024; cv=none; d=google.com; s=arc-20160816; b=oXcPic0sdyaLeFSCBepMLQZAhJbs+eJDFY335ftrOtl7vudAUVmvBEvmAT2V2K8B1T EkYpX9Hd6qxEidKwHrH1bqGjxFYhwW4wxDjv2Y5MdBgtjLPbq92ThHppuL+jHA6V9HcY EFsaDTSOHpYEOKqYg6ln1MsKlltMNOqZgzMtNx4qa5UHiGmnyIGabO4MTtC4HcpyCvCE 6ftx0wDWSwr82U6XVJAYGlQv8XykzoYMG30s/M3DxJLPY7hmVlvCWloZt3Z9rBZQTXih Hg3UFJ48hah3hDxEeB6vTGlgk8a14bkXX8aRO3G/Tdxo0H894WxhtdBIrQIZyWK9WN55 qotw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:dkim-signature; bh=cg1vXAzcRFjP3GXfQCRMyWsYUJ2Cc80Ce/8Y/l18iMY=; b=c5o2FLNb+fhConwgdYbeDEHiST4gzXpgPNvWQJilZtZ7bgF0bEyDQ2IPU6YVKMZuaG HG3V/gi40bhH9RsYxtJeEUz9vCge+JPfcrrHTRaI/xtesUp+ca86MmWz4VvC8x3m6et/ IfgnHQoW3GLSVeKHQI6+72wFhfE6cBbEgT+uNtdj3AQBzvOJk9facmpB97YoIwBcCJkO sg1Bm/TwmN+p7SZf704W/CT+0X7LPd1z6IZAgJc5bjhUEjBpQu1jzm3o4r2Y2+HE2yr3 0IxW5TNmMp5X1etcByOHF18uj/Jt7E8hNCsCWNz0kfhiBe7dtI1g/EpMC3ic6pHtk/Un Hv5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ZdWDQ1Gl; spf=pass (google.com: domain of william.kucharski@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2130.oracle.com (userp2130.oracle.com. [156.151.31.86]) by mx.google.com with ESMTPS id a10si531257vsq.82.2019.05.11.15.33.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 May 2019 15:33:44 -0700 (PDT) Received-SPF: pass (google.com: domain of william.kucharski@oracle.com designates 156.151.31.86 as permitted sender) client-ip=156.151.31.86; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ZdWDQ1Gl; spf=pass (google.com: domain of william.kucharski@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=william.kucharski@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4BMOgAx189680; Sat, 11 May 2019 22:33:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=cg1vXAzcRFjP3GXfQCRMyWsYUJ2Cc80Ce/8Y/l18iMY=; b=ZdWDQ1GlAM12R9SP3yvHS31Pp2G9dDtfK6IA0Xac73GUL0zD+nS5QIo9lvdcjZ5fprLA RBbMfZZNbNg7LHtQStm4pDyD/kTyDxRSFVIpDYaZ5bi46EqE1cO5vrM0GyB4xNERhak9 yLuT+zJ6U4ji3CReu/YV3pgmEit6FxgJhnlIBlaOUbVCno7+KKe5lCmUqDhFZeKWWdxf 8nnR9/rkifOcnfFelT97uZNiWd0oRDT+U5BL1WatnesS8orEMoWrKdrXEKPlm31Ov/yt FV7tVoJ9IBEHOI+xnGd9A3CRc4PfZQ4ViHzyHeVTms+aLyu5ofN+oiZU8+peyHK9KO8y 3g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2sdntt9r1v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 May 2019 22:33:20 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4BMXH7O112688; Sat, 11 May 2019 22:33:19 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2sdme9yw8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 May 2019 22:33:19 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4BMX5ur020474; Sat, 11 May 2019 22:33:05 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 11 May 2019 15:33:05 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] mm: vmscan: correct nr_reclaimed for THP From: William Kucharski In-Reply-To: <20190510163612.GA23417@bombadil.infradead.org> Date: Sat, 11 May 2019 16:33:01 -0600 Cc: "Huang, Ying" , Yang Shi , hannes@cmpxchg.org, mhocko@suse.com, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <7B762A95-B8A6-4281-94F1-5DA6B62EDCF9@oracle.com> References: <1557447392-61607-1-git-send-email-yang.shi@linux.alibaba.com> <87y33fjbvr.fsf@yhuang-dev.intel.com> <20190510163612.GA23417@bombadil.infradead.org> To: Matthew Wilcox X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9254 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=688 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905110166 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9254 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=718 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905110165 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On May 10, 2019, at 10:36 AM, Matthew Wilcox = wrote: >=20 > Please don't. That embeds the knowledge that we can only swap out = either=20 > normal pages or THP sized pages. I'm trying to make the VM capable of=20= > supporting arbitrary-order pages, and this would be just one more = place > to fix. >=20 > I'm sympathetic to the "self documenting" argument. My current tree = has > a patch in it: >=20 > mm: Introduce compound_nr >=20 > Replace 1 << compound_order(page) with compound_nr(page). Minor > improvements in readability. >=20 > It goes along with this patch: >=20 > mm: Introduce page_size() >=20 > It's unnecessarily hard to find out the size of a potentially huge = page. > Replace 'PAGE_SIZE << compound_order(page)' with page_size(page). >=20 > Better suggestions on naming gratefully received. I'm more happy with=20= > page_size() than I am with compound_nr(). page_nr() gives the wrong > impression; page_count() isn't great either. I like page_size() as well. At least to me, page_nr() or page_count() = would imply a basis of PAGESIZE, or that you would need to do something like: page_size =3D page_nr() << PAGE_SHIFT; to get the size in bytes; page_size() is more straightforward in that = respect.=