From: Arun KS <arunks@codeaurora.org>
To: Kees Cook <keescook@chromium.org>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Minchan Kim <minchan@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Arun Sudhilal <getarunks@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.
Date: Wed, 24 Oct 2018 10:47:52 +0530 [thread overview]
Message-ID: <7a4fcbaee7efb71d2a3c6b403c090db4@codeaurora.org> (raw)
In-Reply-To: <CAGXu5j+NsDHRWA5PKAKeJCO_oiGkFAUeWE8O-1fEBQX80MDu1A@mail.gmail.com>
On 2018-10-24 01:34, Kees Cook wrote:
> On Mon, Oct 22, 2018 at 10:11 PM, Konstantin Khlebnikov
> <khlebnikov@yandex-team.ru> wrote:
>> On 23.10.2018 7:15, Joe Perches wrote:> On Mon, 2018-10-22 at 22:53
>> +0530,
>> Arun KS wrote:
>>>> Remove managed_page_count_lock spinlock and instead use atomic
>>>> variables.
>>>
>>> Perhaps better to define and use macros for the accesses
>>> instead of specific uses of atomic_long_<inc/dec/read>
>>>
>>> Something like:
>>>
>>> #define totalram_pages() (unsigned
>>> long)atomic_long_read(&_totalram_pages)
>>
>> or proper static inline
>> this code isn't so low level for breaking include dependencies with
>> macro
>
> BTW, I noticed a few places in the patch that did multiple evaluations
> of totalram_pages. It might be worth fixing those prior to doing the
> conversion, too. e.g.:
>
> if (totalram_pages > something)
> foobar(totalram_pages); <- value may have changed here
>
> should, instead, be:
>
> var = totalram_pages; <- get stable view of the value
> if (var > something)
> foobar(var);
Thanks for reviewing. Point taken.
>
> -Kees
>
>> [dropped bloated cc - my server rejects this mess]
>
> Thank you -- I was struggling to figure out the best way to reply to
> this. :)
I'm sorry for the trouble caused. Sent the email using,
git send-email --to-cmd="scripts/get_maintainer.pl -i"
0001-convert-totalram_pages-totalhigh_pages-and-managed_p.patch
Is this not a recommended approach?
Regards,
Arun
>
> -Kees
next prev parent reply other threads:[~2018-10-24 5:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1540229092-25207-1-git-send-email-arunks@codeaurora.org>
[not found] ` <1540229092-25207-1-git-send-email-arunks-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-22 18:11 ` [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic Michal Hocko
[not found] ` <20181022181122.GK18839-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-10-23 4:46 ` Arun Sudhilal
2018-10-23 5:33 ` Michal Hocko
2018-10-23 6:13 ` Julia Lawall
2018-10-23 7:11 ` Arun Sudhilal
2018-10-25 5:31 ` Arun KS
2018-10-23 5:37 ` Huang, Ying
2018-11-22 1:33 ` Guo Ren
[not found] ` <c57bcc584b3700c483b0311881ec3ae8786f88b1.camel@perches.com>
[not found] ` <c57bcc584b3700c483b0311881ec3ae8786f88b1.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-10-23 4:48 ` Arun KS
2018-10-23 5:11 ` Konstantin Khlebnikov
2018-10-23 20:04 ` Kees Cook
2018-10-24 5:17 ` Arun KS [this message]
2018-10-24 6:15 ` Michal Hocko
2018-10-24 6:26 ` Joe Perches
2018-10-24 8:23 ` Michal Hocko
2018-10-24 8:39 ` Joe Perches
2018-10-25 9:21 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4fcbaee7efb71d2a3c6b403c090db4@codeaurora.org \
--to=arunks@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=getarunks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).