From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48407C433F5 for ; Mon, 17 Jan 2022 16:00:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 896436B0071; Mon, 17 Jan 2022 11:00:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8445E6B0073; Mon, 17 Jan 2022 11:00:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E5426B0074; Mon, 17 Jan 2022 11:00:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 5BDEB6B0071 for ; Mon, 17 Jan 2022 11:00:46 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1314D9369F for ; Mon, 17 Jan 2022 16:00:46 +0000 (UTC) X-FDA: 79040242092.12.A126662 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 7D78280011 for ; Mon, 17 Jan 2022 16:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642435245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0jP9NUGHSBRROmPolsKpE9Ht5fG16z4vLEx/qzEYMvM=; b=SRjeukvEd0o/tRgkVZQFWZQU9vHp2mRytD9pbkstaP0SH521E548CptFr7COVvq5hOsGkw kjYoO7Ss2FzTMm4C1NeFeGk8khsoMSI4VKIHjzP5yHf9B/mKEVouOogGB+b1p+34sZF+2I 0GO1gcwiZd0o0ohHYr9yAWt1adxVnXU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-510-o_rh4ZrVPseaSCoX0IXfmQ-1; Mon, 17 Jan 2022 10:32:05 -0500 X-MC-Unique: o_rh4ZrVPseaSCoX0IXfmQ-1 Received: by mail-ed1-f69.google.com with SMTP id er7-20020a056402448700b00402bbb8ce8bso3002443edb.1 for ; Mon, 17 Jan 2022 07:32:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=0jP9NUGHSBRROmPolsKpE9Ht5fG16z4vLEx/qzEYMvM=; b=VJnrMOaAeY43f4NlxcXbPG/nZvaUQK+0PxFz/tuuZysWXaDDMiMImEdo2KDsQSR4wp 6zSTXFbKI5ulXPa1b2Lv6+CPAAa4y5QOslSQzOcAAuz4czD18zp4P/oxgdb4tUAvN2qu zDCK7bDVSZXBj3Lnsn6VJ43FYZJnny6eTMZ1S2VEpgAeD/7Xpt1Z5YZXCBdhC3/YoCEW 989S8ZQvz+GBO7cIrCy7aLk861PsTL7B0BPsU3xuKsXx5ABGXzmkvgELbG2ZaUKMVKS+ qnKMO3HJg4WgdimXhYyGYn+Jy4FSsbbA55ueWsI1PG9zXsumJ1YoyBXzmRTq2pEbBKhe Cdfw== X-Gm-Message-State: AOAM5316LC0ZjdPIgmBxKB+Hs0tS8ZcmB0muxTHYZ1tKVtwQzqlbqj75 cY+o8/FOLwLpowBb8wDjUBmnPXhw95gF8544dIkP+oHqVsKdIvAOOxdbhtMp1e7PXPL3iu8RoH0 T2MzjUPJM2HM= X-Received: by 2002:a05:6402:42ce:: with SMTP id i14mr21058739edc.126.1642433524352; Mon, 17 Jan 2022 07:32:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzC0KEtX0vuwV0ZCf9AwrJa2Vj8i8C9aUd5qTt/hWF1LTtiVg7dGt04/1NET3pWwmkxpYTtPQ== X-Received: by 2002:a05:6402:42ce:: with SMTP id i14mr21058717edc.126.1642433524026; Mon, 17 Jan 2022 07:32:04 -0800 (PST) Received: from ?IPV6:2003:cb:c705:dd00:68a1:1bd:6733:bde9? (p200300cbc705dd0068a101bd6733bde9.dip0.t-ipconnect.de. [2003:cb:c705:dd00:68a1:1bd:6733:bde9]) by smtp.gmail.com with ESMTPSA id u14sm5886078edv.92.2022.01.17.07.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 07:32:03 -0800 (PST) Message-ID: <7d39763f-7fc6-a56f-4f1d-7bce42ff59d6@redhat.com> Date: Mon, 17 Jan 2022 16:32:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page" To: Chen Wandun , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com References: <20220117142712.3967624-1-chenwandun@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220117142712.3967624-1-chenwandun@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7D78280011 X-Stat-Signature: ogs39tn6k1mihd4ncie3s7tpu7x8s6yq Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SRjeukvE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1642435245-280301 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.01.22 15:27, Chen Wandun wrote: > This reverts commit 075782149abff45ee22f27315eced44d02b96779. > > commit 075782149abf ("mm/page_isolation: unset migratetype directly for > non Buddy page") will result memory that should in buddy disappear by > mistake. move_freepages_block move all pages in pageblock instead of > pages indicated by input parameter, so if input pages is not in buddy > but other pages in pageblock is in buddy, it will result in page out of > control. > I was wondering about exactly that condition when skimming over the patch but didn't have time review in detail. Acked-by: David Hildenbrand > Reported-by: "kernelci.org bot" > Signed-off-by: Chen Wandun > --- > mm/page_isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 6a0ddda6b3c5..f67c4c70f17f 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > * onlining - just onlined memory won't immediately be considered for > * allocation. > */ > - if (!isolated_page && PageBuddy(page)) { > + if (!isolated_page) { > nr_pages = move_freepages_block(zone, page, migratetype, NULL); > __mod_zone_freepage_state(zone, nr_pages, migratetype); > } -- Thanks, David / dhildenb