From: David Hildenbrand <david@redhat.com>
To: Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org
Cc: mhocko@kernel.org, mhocko@suse.com, rientjes@google.com,
willy@infradead.org, hannes@cmpxchg.org, guro@fb.com,
riel@surriel.com, minchan@kernel.org, christian@brauner.io,
hch@infradead.org, oleg@redhat.com, jannh@google.com,
shakeelb@google.com, luto@kernel.org,
christian.brauner@ubuntu.com, fweimer@redhat.com,
jengelh@inai.de, timmurray@google.com, linux-api@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease
Date: Tue, 20 Jul 2021 14:43:52 +0200 [thread overview]
Message-ID: <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> (raw)
In-Reply-To: <20210718214134.2619099-1-surenb@google.com>
On 18.07.21 23:41, Suren Baghdasaryan wrote:
> process_mrelease needs to be added in the CONFIG_MMU-dependent block which
> comes before __task_will_free_mem and task_will_free_mem. Move these
> functions before this block so that new process_mrelease syscall can use
> them.
>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
> changes in v2:
> - Fixed build error when CONFIG_MMU=n, reported by kernel test robot. This
> required moving task_will_free_mem implemented in the first patch
> - Renamed process_reap to process_mrelease, per majority of votes
> - Replaced "dying process" with "process which was sent a SIGKILL signal" in
> the manual page text, per Florian Weimer
> - Added ERRORS section in the manual page text
> - Resolved conflicts in syscall numbers caused by the new memfd_secret syscall
> - Separated boilerplate code wiring-up the new syscall into a separate patch
> to facilitate the review process
>
> mm/oom_kill.c | 150 +++++++++++++++++++++++++-------------------------
> 1 file changed, 75 insertions(+), 75 deletions(-)
TBH, I really dislike this move as it makes git blame a lot harder with
any real benefit.
Can't you just use prototypes to avoid the move for now in patch #2?
static bool task_will_free_mem(struct task_struct *task);
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-07-20 12:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 21:41 [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease Suren Baghdasaryan
2021-07-18 21:41 ` [PATCH v2 2/3] mm: introduce process_mrelease system call Suren Baghdasaryan
2021-07-21 8:02 ` David Hildenbrand
2021-07-21 15:43 ` Suren Baghdasaryan
2021-07-21 22:59 ` Suren Baghdasaryan
2021-07-22 7:45 ` David Hildenbrand
2021-07-18 21:41 ` [PATCH v2 3/3] mm: wire up syscall process_mrelease Suren Baghdasaryan
2021-07-20 12:43 ` David Hildenbrand [this message]
2021-07-20 16:18 ` [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease Suren Baghdasaryan
2021-07-20 23:07 ` Andrew Morton
2021-07-21 7:30 ` David Hildenbrand
2021-07-21 15:33 ` Suren Baghdasaryan
2021-07-21 16:12 ` David Hildenbrand
2021-07-21 20:19 ` Suren Baghdasaryan
2021-07-21 20:50 ` Andrew Morton
2021-07-21 20:59 ` Suren Baghdasaryan
2021-07-23 1:15 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=fweimer@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jannh@google.com \
--cc=jengelh@inai.de \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleg@redhat.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).