From: Ying Huang <ying.huang@intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Wei Xu <weixugc@google.com>, Greg Thelen <gthelen@google.com>,
Yang Shi <shy828301@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Tim C Chen <tim.c.chen@intel.com>,
Brice Goglin <brice.goglin@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hesham Almatary <hesham.almatary@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alistair Popple <apopple@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Feng Tang <feng.tang@intel.com>,
Jagdish Gediya <jvgediya@linux.ibm.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v6 03/13] mm/demotion: Return error on write to numa_demotion sysfs
Date: Mon, 13 Jun 2022 11:26:55 +0800 [thread overview]
Message-ID: <7ed1f9f544937b5c82ab380a4977e5ae22a98c43.camel@intel.com> (raw)
In-Reply-To: <20220610135229.182859-4-aneesh.kumar@linux.ibm.com>
On Fri, 2022-06-10 at 19:22 +0530, Aneesh Kumar K.V wrote:
> With CONFIG_MIGRATION disabled return EINVAL on write.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> mm/memory-tiers.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index 9c6b40d7e0bf..c3123a457d90 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -105,6 +105,9 @@ static ssize_t numa_demotion_enabled_store(struct kobject *kobj,
> {
> ssize_t ret;
>
>
> + if (!IS_ENABLED(CONFIG_MIGRATION))
> + return -EINVAL;
> +
How about enclose numa_demotion_enabled_xxx related code with CONFIG_MIGRATION?
> ret = kstrtobool(buf, &numa_demotion_enabled);
> if (ret)
> return ret;
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2022-06-13 3:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 13:52 [PATCH v6 00/13] mm/demotion: Memory tiers and demotion Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 01/13] mm/demotion: Add support for explicit memory tiers Aneesh Kumar K.V
2022-06-13 3:22 ` Ying Huang
2022-06-13 3:31 ` Aneesh Kumar K V
2022-06-13 5:30 ` Ying Huang
2022-06-13 13:16 ` Johannes Weiner
2022-06-13 13:28 ` Aneesh Kumar K V
2022-06-14 8:20 ` Aneesh Kumar K.V
2022-06-14 15:13 ` Davidlohr Bueso
2022-06-10 13:52 ` [PATCH v6 02/13] mm/demotion: Move memory demotion related code Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 03/13] mm/demotion: Return error on write to numa_demotion sysfs Aneesh Kumar K.V
2022-06-13 3:26 ` Ying Huang [this message]
2022-06-13 3:35 ` Aneesh Kumar K V
2022-06-13 5:33 ` Ying Huang
2022-06-13 5:48 ` Aneesh Kumar K V
2022-06-14 8:40 ` Ying Huang
2022-06-10 13:52 ` [PATCH v6 04/13] mm/demotion/dax/kmem: Set node's memory tier to MEMORY_TIER_PMEM Aneesh Kumar K.V
2022-06-13 6:59 ` Ying Huang
2022-06-13 7:05 ` Aneesh Kumar K V
2022-06-10 13:52 ` [PATCH v6 05/13] mm/demotion: Build demotion targets based on explicit memory tiers Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 06/13] mm/demotion: Expose memory tier details via sysfs Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 07/13] mm/demotion: Add per node memory tier attribute to sysfs Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 08/13] mm/demotion: Add support for memory tier creation from userspace Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 09/13] mm/demotion: Add pg_data_t member to track node memory tier details Aneesh Kumar K.V
2022-06-13 7:07 ` Ying Huang
2022-06-10 13:52 ` [PATCH v6 10/13] mm/demotion: Demote pages according to allocation fallback order Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 11/13] mm/demotion: Update node_is_toptier to work with memory tiers Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 12/13] mm/demotion: Add documentation for memory tiering Aneesh Kumar K.V
2022-06-10 13:52 ` [PATCH v6 13/13] mm/demotion: Add sysfs ABI documentation Aneesh Kumar K.V
-- strict thread matches above, loose matches on Subject: below --
2022-06-10 13:49 [PATCH v6 00/13] mm/demotion: Memory tiers and demotion Aneesh Kumar K.V
2022-06-10 13:49 ` [PATCH v6 03/13] mm/demotion: Return error on write to numa_demotion sysfs Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ed1f9f544937b5c82ab380a4977e5ae22a98c43.camel@intel.com \
--to=ying.huang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=apopple@nvidia.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brice.goglin@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave@stgolabs.net \
--cc=feng.tang@intel.com \
--cc=gthelen@google.com \
--cc=hesham.almatary@huawei.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=tim.c.chen@intel.com \
--cc=weixugc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).