From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA0AC7619A for ; Tue, 11 Apr 2023 18:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E486C900002; Tue, 11 Apr 2023 14:27:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF7146B007B; Tue, 11 Apr 2023 14:27:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE63A900002; Tue, 11 Apr 2023 14:27:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BDB056B0078 for ; Tue, 11 Apr 2023 14:27:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59092A0C58 for ; Tue, 11 Apr 2023 18:27:43 +0000 (UTC) X-FDA: 80669943606.21.A5A070B Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf16.hostedemail.com (Postfix) with ESMTP id 923AE180023 for ; Tue, 11 Apr 2023 18:27:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bxbElAlZ; spf=pass (imf16.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681237661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eOFmzkUrPnsCQkJP2IiRTU+5Uv/Sb6TP41x5Vc3yr0M=; b=rRQYlxKda/cXhzsDreXtEqmU6IT9WtUifkiGmFeZ5NRKOp1hM1xBlbvllLpzrRpVpZULxe LXrchUmnmIlHsvj9b8MdifdOhj8LQnZPDAiABu/sg4x/goMIDFTnWHtZkMqg6Uw+9wff/G 2uJT7eQZLGMqu6m4LXG2QUSr3g6uk00= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bxbElAlZ; spf=pass (imf16.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681237661; a=rsa-sha256; cv=none; b=VLvlRwGf5hbkl5l6m4PwWUaScAPqwYG/GpLGEOfQFhDA6CBf2vWttswIOewK4LB9Nyfs4h 5cyqtNNiTi/16MngVj5Jz3egGJifhThyACPuDPXDiPVVkJbQmsJLEK3YQ95oeCzTcBfn2j rwyrYYmN2M8dsxv9GFipSwOcanhclDM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681237660; x=1712773660; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1QioC9Kxlkpc1XJQphVkupGM3XmsH0QP9DjCNhRYggY=; b=bxbElAlZDlSxum4QI/T05QpohYNEf1fXI/UoNJs8rMNwb6dV3FmyBXUB 3RUXmfOarq7O5YbRdEfX5TAMuQMzRSRxz2DmdEZRem9L4PLMfhi1VeBYK RwbxbkLsxVTfTAzzHbdhZKTSMh7vXcb5q+z5JpMYGn8SzIIEbhczb+Lht fq6vb/9I/QPP4GyNQDVHfElVJmvNf1+ZJmiyt7pLZ4XMTLpPqAKnmIQtE y2LaInATecIQ6GxwDDyjSBlbK+TB30l28SjWZD8W6EbxRfqt2dYE905bQ Zwe/MZ/6Wi5b5tasNsEEjudOyLibHRTxplCKr60ntdBhQAmzOYkhMyqJl A==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="343708297" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343708297" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 11:27:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="691265257" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="691265257" Received: from gtryonx-mobl.amr.corp.intel.com (HELO [10.209.72.81]) ([10.209.72.81]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 11:27:36 -0700 Message-ID: <7fe765e1-88b5-7bf1-133c-4587224f1e7a@intel.com> Date: Tue, 11 Apr 2023 11:27:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC v8 17/56] x86/fault: Add support to handle the RMP fault for user address Content-Language: en-US To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, Brijesh Singh , Jarkko Sakkinen References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-18-michael.roth@amd.com> <20230328233101.4idfki7ulpyhxrwy@amd.com> From: Dave Hansen In-Reply-To: <20230328233101.4idfki7ulpyhxrwy@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: k317jc9dbftf3uzmwis8iqg96i894tn4 X-Rspam-User: X-Rspamd-Queue-Id: 923AE180023 X-Rspamd-Server: rspam06 X-HE-Tag: 1681237660-449971 X-HE-Meta: U2FsdGVkX18rW9r4dV5qF0E9ve+v5Y1VPcOTW/nWb0bbwMEf7CPDnX5WQJcH59yJB+qp/ZWasNFjNNSxG9Aaifx95YiCha8NO09EVQvBU3ZHpedTPBMs9V7qwwlzJnv6ocQxLDKBxrlHApp4Uv9z4gSKaVa1T0s3JJ9MAN4OKEiKDEAiD7xRQ9E5maQIbTSt7eORe9ew/cPdBv7ffMcm3qy6zD0sp4X7o63hX9zneE7phCtokfnK8gkSxGI/HBBEfghP6X+JeOsGHBRFpHYS72lIoNCbzixaLzZ0rZRYsPMyZw3+gINU9Bhgoy8vImBiMf2UNiG6ejLm1BjV2M8BX63MCLufTBjRTmNKcXWD7UCGDCj4QQWvDZGjC4EVNbAh8xqqAGSJJrwz8Q2ApG06uWEpKrTu0NqK4RBjHgERCyDSektq49DwhhfZnGA4TuVJh0iT8k0BMt5RGHgb3YGdLw46kxAG/NKJeoUmST8HGjjcblygbzkNIx1oPPcwVdXO7mKvDjYKTq0RpSX4wQkr+wMKvMq+vwpbmpSBnTIsAiP2JOT1KVUi1IoZKtwKdHdCOlA9sZBaHQYepdIG/vsM2ZNDw5kym71+qD/RM2yn3GNINvZbsE/6yUajewnT3IfmUc/FSViSjv2zzsk0iy7pv59rBho36HdfqD7zk4zzlG7nkzOk6WGOqJ+w2OKBz9XuoBUB1o/cazrH5lCCBdsCK7acjnojjaPZ2pN5epm19tUkGzsDYSXG6CJTv6a+H6Z1bpDHITCsJBlAKJp41Pzo0DcaSsV9U1tkJGzpbEnk2uyLkrD2+swB6HIyAKmo8zq4pBn9fKRr2IliogG+lxfHjbNInJK3K807rjENPlrGg10OprHKw2YE2mTnBUU0AjJez7D4LsHphpAOcMN++xaiG8WgVmGq9FB7C5o2k9M3iu0M4X0VCH1ytNb5ugovA2XJvPERbNLj4jgZuJOCljI JnkJ2JRa KP5+CZ4I6oP0pJf5usjNT7UWWn0n8kdSYHCD7OrGfDnlc7RZyhrKDB4Vc/xw7dU+pKDEfOUvbprniS5mo1FhcqGNA7agMZq82wafiFNT7f1wS3XWj4Ezx/XZR2anbodsrhPy/iaLZ9M/Qo7kVQxI4i3e+O0SpkY6UVn7E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/28/23 16:31, Michael Roth wrote: > However... > > The fact that any pages potentially triggering these #PFs are able to be > mapped as 2M in the first place means that all the PFNs covered by that > 2M mapping must also been allocated by via mappable/VMA memory rather > than via restricted memfd where userspace mappings are not possible. > > So I think we should be able to drop this patch entirely, as well as > allow the use of HugeTLBFS for non-restricted memfd memory (though > eventually the guest will switch all its memory to private/restricted > so not gaining much there other than reducing management complexity). This is sounding a bit voodoo-ish to me. If this whole series is predicated on having its memory supplied via one very specific ABI with very specific behavior. That connection and the associated contract isn't spelled out very clearly in this series. I'm sure it works on your machine and is clear to _you_ but I'm worried that nobody else is going to be able to figure out the voodoo. Could we make sure that this stuff is made very clear in the Documentation and cover letter, please?