From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E612EC4332F for ; Mon, 21 Nov 2022 18:15:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270FF6B0074; Mon, 21 Nov 2022 13:15:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F91E6B0075; Mon, 21 Nov 2022 13:15:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1936B0078; Mon, 21 Nov 2022 13:15:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EDA656B0074 for ; Mon, 21 Nov 2022 13:15:07 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 89AA41201DA for ; Mon, 21 Nov 2022 18:15:07 +0000 (UTC) X-FDA: 80158251054.19.5EB1A92 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 9D89B180019 for ; Mon, 21 Nov 2022 18:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669054506; x=1700590506; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GAVtFtjbl2NQuREt3KtkaZtzB7KUOF9ZPwGqcocelO4=; b=R65Myt9d4zIyTqixYLIOba/6zWbodoG/svXktaWWdVxYpDqAhZKkMAX2 VEtYxHtCxNkEqQsgZTvD5Urxk6p6fgrjBooUE9IN8F+sy5z4oC+kLsrNK 9QMSzWfNr+/HcnYt0HpleP8mot12C1XnRWsPPxzSVPr7Sk6A2UryOX900 ax/PwBMjz23+o63UPa3H9qpuRVldqrFV8NLmxP8u5ukHlfxDFOUX1bZKR hJFEyX0DSdY5Rd/YQLnodJJYsyO2FdiWEgLHpxsEoIH6Xhe271t0FP5KZ hmolGS59BSOWqlZuHkYO9Ew8vXWLv5DYNVTtupwQ15B/aJk7qx1Ea+2Zm A==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="399916934" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="399916934" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 10:12:55 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="709904648" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="709904648" Received: from ticela-or-327.amr.corp.intel.com (HELO [10.209.6.63]) ([10.209.6.63]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 10:12:54 -0800 Message-ID: <805fb0fb-84e2-41ac-ed02-3470fd8c63fe@intel.com> Date: Mon, 21 Nov 2022 10:12:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 01/20] x86/tdx: Define TDX supported page sizes as macros Content-Language: en-US To: Sathyanarayanan Kuppuswamy , Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, peterz@infradead.org, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <2eedfcff-e8c1-79af-63f4-c852af7b7e77@linux.intel.com> From: Dave Hansen In-Reply-To: <2eedfcff-e8c1-79af-63f4-c852af7b7e77@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=R65Myt9d; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669054507; a=rsa-sha256; cv=none; b=V0usmsNeOddASlfWmmocNYcBxrlALgmpRaWy/u+Oqf2V5k/9/HpG6vQdd97Wh0Q171/+SG jHeljMJuwSRd7XvQyQ7EXK79oq3RCFerGDTFpIiNqtLintLIzsdPjrJE5pE1UlN9JHk6WW BklmRp9j9kXmmSC0e5vOLrjEEB66IHg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669054507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OvuvU6svSB3nZbKeFUM56DWqF0u4ovHmMMB3BW1fbNE=; b=vshknIvUGOvo+RMc/CkKK6hk6m9UM9qPbNp47ZagIIdlzg4SmXlUgxFDk/O3qUffrOo70Z w0IIxISknUaC8/zUIOIYHOHgB4VEvrY9xtFmYz3X3xEZoDFAvOIDTrfF/DGowCvK6A1VD9 N5ikVH2SWOSt10AxHt0cLr2q5S2KRhE= X-Rspamd-Queue-Id: 9D89B180019 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=R65Myt9d; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-Stat-Signature: 17r7rixbaz9ctkxgy4rkkso5ik7c9cp5 X-HE-Tag: 1669054506-172113 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001668, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/20/22 18:52, Sathyanarayanan Kuppuswamy wrote: > On 11/20/22 4:26 PM, Kai Huang wrote: >> +/* >> + * TDX supported page sizes (4K/2M/1G). >> + * >> + * Those values are part of the TDX module ABI. Do not change them. > It would be better if you include specification version and section > title. I actually think TDX code, in general, spends way too much time quoting and referring to the spec. Also, why quote the version? Do we quote the SDM version when we add new SDM-defined architecture? It's just busywork that bloats the kernel and adds noise. Please focus on adding value to the comments that came from your brain and not just pasting boilerplate gunk over and over.