From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01396C4361B for ; Tue, 8 Dec 2020 08:47:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6927423A5E for ; Tue, 8 Dec 2020 08:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6927423A5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A9BF46B005C; Tue, 8 Dec 2020 03:47:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4D3A6B005D; Tue, 8 Dec 2020 03:47:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 961926B0068; Tue, 8 Dec 2020 03:47:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 83A906B005C for ; Tue, 8 Dec 2020 03:47:10 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4A0B5180AD815 for ; Tue, 8 Dec 2020 08:47:10 +0000 (UTC) X-FDA: 77569485420.25.stop22_390d652273e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 283901804E3A0 for ; Tue, 8 Dec 2020 08:47:10 +0000 (UTC) X-HE-Tag: stop22_390d652273e5 X-Filterd-Recvd-Size: 3958 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 08:47:08 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UHyFcey_1607417219; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UHyFcey_1607417219) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Dec 2020 16:47:00 +0800 Subject: Re: [PATCH 04/11] mm: don't pass "enum lru_list" to trace_mm_lru_insertion() To: Yu Zhao , Andrew Morton , Hugh Dickins Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-5-yuzhao@google.com> From: Alex Shi Message-ID: <80656d92-c984-7f24-c2cf-ba6dde4ef90e@linux.alibaba.com> Date: Tue, 8 Dec 2020 16:46:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201207220949.830352-5-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Alex Shi =E5=9C=A8 2020/12/8 =E4=B8=8A=E5=8D=886:09, Yu Zhao =E5=86=99=E9=81=93: > The parameter is redundant in the sense that it can be extracted > from the "struct page" parameter by page_lru() correctly. >=20 > Signed-off-by: Yu Zhao > --- > include/trace/events/pagemap.h | 11 ++++------- > mm/swap.c | 5 +---- > 2 files changed, 5 insertions(+), 11 deletions(-) >=20 > diff --git a/include/trace/events/pagemap.h b/include/trace/events/page= map.h > index 8fd1babae761..e1735fe7c76a 100644 > --- a/include/trace/events/pagemap.h > +++ b/include/trace/events/pagemap.h > @@ -27,24 +27,21 @@ > =20 > TRACE_EVENT(mm_lru_insertion, > =20 > - TP_PROTO( > - struct page *page, > - int lru > - ), > + TP_PROTO(struct page *page), > =20 > - TP_ARGS(page, lru), > + TP_ARGS(page), > =20 > TP_STRUCT__entry( > __field(struct page *, page ) > __field(unsigned long, pfn ) > - __field(int, lru ) > + __field(enum lru_list, lru ) > __field(unsigned long, flags ) > ), > =20 > TP_fast_assign( > __entry->page =3D page; > __entry->pfn =3D page_to_pfn(page); > - __entry->lru =3D lru; > + __entry->lru =3D page_lru(page); > __entry->flags =3D trace_pagemap_flags(page); > ), > =20 > diff --git a/mm/swap.c b/mm/swap.c > index 136acabbfab5..e053b4db108a 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -957,7 +957,6 @@ EXPORT_SYMBOL(__pagevec_release); > =20 > static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lru= vec) > { > - enum lru_list lru; > int was_unevictable =3D TestClearPageUnevictable(page); > int nr_pages =3D thp_nr_pages(page); > =20 > @@ -993,11 +992,9 @@ static void __pagevec_lru_add_fn(struct page *page= , struct lruvec *lruvec) > smp_mb__after_atomic(); > =20 > if (page_evictable(page)) { > - lru =3D page_lru(page); > if (was_unevictable) > __count_vm_events(UNEVICTABLE_PGRESCUED, nr_pages); > } else { > - lru =3D LRU_UNEVICTABLE; > ClearPageActive(page); > SetPageUnevictable(page); > if (!was_unevictable) > @@ -1005,7 +1002,7 @@ static void __pagevec_lru_add_fn(struct page *pag= e, struct lruvec *lruvec) > } > =20 > add_page_to_lru_list(page, lruvec); > - trace_mm_lru_insertion(page, lru); > + trace_mm_lru_insertion(page); > } > =20 > struct lruvecs { >=20