From: Mike Kravetz <mike.kravetz@oracle.com>
To: Wei Yang <richard.weiyang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com
Subject: Re: [Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop instead of break and check
Date: Fri, 28 Aug 2020 09:25:10 -0700 [thread overview]
Message-ID: <80ca8de0-45cd-0c53-9f95-90957960c19d@oracle.com> (raw)
In-Reply-To: <20200828033242.8787-7-richard.weiyang@linux.alibaba.com>
On 8/27/20 8:32 PM, Wei Yang wrote:
> Function dequeue_huge_page_node_exact() iterates the free list and
> return the first non-isolated one.
>
> Instead of break and check the loop variant, we could return in the loop
> directly. This could reduce some redundant check.
>
> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Commit bbe88753bd42 (mm/hugetlb: make hugetlb migration callback CMA aware)
in v5.9-rc2 modified dequeue_huge_page_node_exact. This patch will need
to be updated to take those changes into account.
--
Mike Kravetz
next prev parent reply other threads:[~2020-08-28 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 3:32 [Patch v2 0/7] mm/hugetlb: code refine and simplification Wei Yang
2020-08-28 3:32 ` [Patch v2 1/7] mm/hugetlb: not necessary to coalesce regions recursively Wei Yang
2020-08-28 3:32 ` [Patch v2 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache() Wei Yang
2020-08-28 16:21 ` Mike Kravetz
2020-08-28 3:32 ` [Patch v2 3/7] mm/hugetlb: use list_splice to merge two list at once Wei Yang
2020-08-28 3:32 ` [Patch v2 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL Wei Yang
2020-08-28 3:32 ` [Patch v2 5/7] mm/hugetlb: a page from buddy is not on any list Wei Yang
2020-08-28 3:32 ` [Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop instead of break and check Wei Yang
2020-08-28 16:25 ` Mike Kravetz [this message]
2020-08-28 3:32 ` [Patch v2 7/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ca8de0-45cd-0c53-9f95-90957960c19d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).