From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2475FC4338F for ; Thu, 19 Aug 2021 20:43:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C019D6108B for ; Thu, 19 Aug 2021 20:43:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C019D6108B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2CC966B006C; Thu, 19 Aug 2021 16:43:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C426B0071; Thu, 19 Aug 2021 16:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16B266B0072; Thu, 19 Aug 2021 16:43:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id EE81F6B006C for ; Thu, 19 Aug 2021 16:43:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 93B84181B94B9 for ; Thu, 19 Aug 2021 20:43:01 +0000 (UTC) X-FDA: 78493004562.12.EF6F574 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf03.hostedemail.com (Postfix) with ESMTP id 076023000099 for ; Thu, 19 Aug 2021 20:43:00 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id w22-20020a056830411600b0048bcf4c6bd9so10299855ott.8 for ; Thu, 19 Aug 2021 13:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=6AuFKvgToZ7Ta1FvqLShY8VobvpryykUZKzf0fozJsI=; b=RAPuF9LkPlLDHQGygCJBq+C9FhAfcBI0q9lzvcbq0+vFvjDff2qqs0yqNiUGqgT6pJ +KGVklTDk55wQM2lKKBNAcOGMFcXIJA2F0AhgQgsblw6LNuHoHg5mhuoiNH4UVR1INZ1 m3nzz0+xc/Q6FpA1TxXq3F+nTBmf94raaIf0+5ndKXr8ozG8cCXxbY/ZouCaLa5HlCEC khHdrHAv77vpam+HZ4I6Ga00T+/Ij/dSldaKRxTfKDU5xLdMx6jVfQ+DPXnp/S7UQvSg CU8HfbACS1oUbNjAo1+RFheI0KeQsN9mh2Ow6smeMT8M/Bi+zt6GNJYpAZfiFgbcB/hd yaLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=6AuFKvgToZ7Ta1FvqLShY8VobvpryykUZKzf0fozJsI=; b=WmHwPyFup8AzFLwBS5lZZZBqiMyS9zhqzgICaP5fPJsG2J+rhRhqxR4i60uNfX333D YYJfI2tchvSmJEcD2TN2WZhJxfqtRPqlQpWEb9f+dSXSD1xcjqhckT6Aw7/Pv1d1E3Rh BnVGupdO8pnBNh6hqBn6q4gwUjb1A7ojGD/ylGa8ouLZ3A2zYl8mMpbDkQGbcu0vv161 4UhosveR7l92IPKzVELYZMFVW1XLwngD57edtisbt+WB0SmJ4WVKJlK+DdkGSqFTpWRh /S6+EU8hiRCvyRRFWJjehkR2EZK6a+aNE96vSqIXs2HxanvpNgs7iA2mhciGSLpg3+MP U/0Q== X-Gm-Message-State: AOAM532DLzas1g7IXuhaU/Pre6K1WAKe9/yfpVVhLBjmszj8WNNV3FbT ABywkw7XzjNledk5Qb05bG7ifA== X-Google-Smtp-Source: ABdhPJzVAfKQrGyiYF1L0Skh5bMfGADM2OCaV0cTOg8AtRAK3YmpSa2ooGXsKcRuk4MWrrk7Z3kjDQ== X-Received: by 2002:a9d:6192:: with SMTP id g18mr13666032otk.314.1629405780110; Thu, 19 Aug 2021 13:43:00 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id n17sm938960otl.32.2021.08.19.13.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 13:42:59 -0700 (PDT) Date: Thu, 19 Aug 2021 13:42:43 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Remove bogus VM_BUG_ON In-Reply-To: Message-ID: <813d476-b6d4-456e-b5c3-5fe0455edeb3@google.com> References: <20210818144932.940640-1-willy@infradead.org> <2197941-297c-f820-aa57-fb5167794fb1@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=RAPuF9Lk; spf=pass (imf03.hostedemail.com: domain of hughd@google.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 076023000099 X-Stat-Signature: jee1orrizih1qbkigtkxf4n6jrfzyap4 X-HE-Tag: 1629405780-837486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 18 Aug 2021, Matthew Wilcox wrote: > On Wed, Aug 18, 2021 at 09:34:51AM -0700, Hugh Dickins wrote: > > On Wed, 18 Aug 2021, Matthew Wilcox (Oracle) wrote: > > > > > It is not safe to check page->index without holding the page lock. > > > It can be changed if the page is moved between the swap cache and the > > > page cache for a shmem file, for example. There is a VM_BUG_ON below > > > which checks page->index is correct after taking the page lock. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: 5c211ba29deb ("mm: add and use find_lock_entries") > > > > I don't mind that VM_BUG_ON_PAGE() being removed, but question whether > > this Fixes anything, and needs to go to stable. Or maybe it's just that > > the shmem example is wrong - moving shmem from page to swap cache does > > not change page->index. Or maybe you have later changes in your tree > > which change that and do require this. Otherwise, I'll have to worry > > why my testing has missed it for six months. > > I'm sorry, I think you're going to have to worry :-( Indeed, it seems that way; or maybe I can leave this testing to syzbot. > Syzbot found it initially: > > https://lore.kernel.org/linux-mm/0000000000009cfcda05c926b34b@google.com/ Ah, that's useful info. Though I can quite see why you didn't mention that originally: it looks as if syzbot hit a find_lock_entries() crash and an irqstate warning about the same time, and its bisection went off and found the commit that introduced those irqstate warnings: neither the root cause of the irqstate warning, nor the cause of the find_lock_entries() crash which it claims in the Subject. I have briefly tried the C reproducer, but didn't get anything out of it; and suspect it may be a reproducer of the irqstate warning rather than the crash which interests you and me. And I can't tell more from the dump, no dump_page() info is shown, and the "Code:" just points into a function epilog of assorted ud2s. > > and then I hit it today during my testing (which is definitely due to > further changes in my tree). Okay, and it's perfectly reasonable for your tree to make changes which require that VM_BUG_ON_PAGE to be removed. But I do not yet understand why it needs to be removed from the current or stable tree. I don't believe it has anything to do with swap cache. The reproducer is mounting with "huge=within_size", and doing lots of truncation: my supposition is that a shmem THP is being collapsed or split, concurrently with that find_lock_entries(). I don't actually see how that would lead to this VM_BUG_ON_PAGE: I imagine find_get_entry()'s xas_reload check after get_speculative should be good enough - but don't know my way around XArray, so mention this in case it triggers an Aha from you. While there's certainly a sense in which removing the VM_BUG_ON_PAGE removes the root cause of the crash, I don't think we understand what is going on here yet: and therefore I'm reluctant to remove it. But I have not given this issue much time, busy with other stuff. > > I should have added: > > Reported-by: syzbot+c87be4f669d920c76330@syzkaller.appspotmail.com That's fair, it did report it, if confusingly. Hugh (p.s. in parentheses, to minimize confusion from going slightly off-topic, but I think I'd be wrong not to mention a separate issue in this area, with mmotm and linux-next since your folios went in: doesn't happen easily, but I have twice hit the include/linux/pagemap.h:258 VM_BUG_ON_PAGE(PageTail(page), page), in page_cache_add_speculative() - both times when serving filemap_map_pages(). I have not thought about it at all, but expect that when you do, you'll simply decide that one is unsafe and has to be deleted.)