From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08856CD1284 for ; Tue, 2 Apr 2024 12:39:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 303D56B0082; Tue, 2 Apr 2024 08:39:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B2D56B0083; Tue, 2 Apr 2024 08:39:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A276B0085; Tue, 2 Apr 2024 08:39:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F01DF6B0082 for ; Tue, 2 Apr 2024 08:39:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A9356A0C5A for ; Tue, 2 Apr 2024 12:39:33 +0000 (UTC) X-FDA: 81964547826.26.6BD0C1F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 1E5C910000F for ; Tue, 2 Apr 2024 12:39:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JBEaGuaQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pFjoKW9y; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712061571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=17nfIwhr2J6EqJPvt6WiOi3WK73dMRHs/vc3cZf3PnY=; b=dHI1wLqcgTFgF15cDkFH+PRHDnC39E2C92Of7TzjLBMjNFGejNlIlry6brJ2HONSt8bQyb 2zLxF97yJnNQahjWJ+klqrX15CCjLfUsI+beY9Uc65iXVj8YtOWDzRZ1j/RkivF3Q6/8Wz XQzB1JRi52TzqGIgBBIQE8Pj6GOKTdw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JBEaGuaQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pFjoKW9y; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712061571; a=rsa-sha256; cv=none; b=0NXTWs2a6PRR112HcQZRfSL24VAYfKS1zBPuDIk/P2k80AfNYz0pwrZZKijj7Ghbw1zA5b k3OptMtFUEdT94bIiQKnJaduc5K1+mqvvEc/9LRmDyaZ8RFpJQB6PBwptpHJ0HGiu8AkEu Kj9P5mXR/crlklyvlOwl/p9jXmF9mn4= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 591A234695; Tue, 2 Apr 2024 12:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712061569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17nfIwhr2J6EqJPvt6WiOi3WK73dMRHs/vc3cZf3PnY=; b=JBEaGuaQJDg98/s5Ofujt2YLWFKHBeEjhU4gnarvkgBGXHkun/w9dKLPqU3IE7ZoreaH+q s1XKO6giyDAzYliyDBcye6n6ZXktQ872qJ7Vkd8xRxe1HZOk/85u/Hjbk17HRlEzj7XxNl tJiPxlyfcfSLoieVddQ77Pgg+COs0oM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712061569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17nfIwhr2J6EqJPvt6WiOi3WK73dMRHs/vc3cZf3PnY=; b=pFjoKW9yKpaMZ3bQM74sAyJb3mDXSpHOEEViumXPBNL/WwpUFWgvGHpGVNWs8YyAtOYbwo vxDkpKGvIJKBRAAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 479AB13357; Tue, 2 Apr 2024 12:39:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id Ct8oEYH8C2arQwAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 12:39:29 +0000 Message-ID: <819252eb-0ad5-4464-87d5-bbf13661c379@suse.cz> Date: Tue, 2 Apr 2024 14:39:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] mm,page_owner: Fix accounting of pages when migrating Content-Language: en-US To: Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240326063036.6242-1-osalvador@suse.de> <20240326063036.6242-4-osalvador@suse.de> <50f31489-b5c3-480e-a7db-20edbbb2c9c2@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Bar: / X-Rspam-User: X-Stat-Signature: jqbkjaq4t1sohhw7wpqt5bwtfqf39e77 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1E5C910000F X-HE-Tag: 1712061570-825527 X-HE-Meta: U2FsdGVkX187b+E/3Tud5zFVJpTF5HD3B8yyQgr2y2yzWEmVCUNjhtnZQ5pFeAJ3F8GwrKz9OKowpz2pxXa1EjOBwcYYxUPWRtIyzhz62MsbS8+EV93SKG6lRFCu7/KjJ3cEdoJ9vI52a8813lj/CfNWlRak7zDcOeCXQUksYBRSBHb82yfTwR9uHggEtLnzGg48TTbyh000aWGvMt1J21zg2UewLvj03gs/m3ABjWmkqZf5sgaGYx/Fdbp3qiMGxR4rfLKvuzpfRfew2Qv20lqgRKkfHe/lPrYAFaoJcLW08jaDaiCuQaQ0uRxu6Ls7etm+HMaJGtnA0ef2z2NJ4hFmKiPeQAfTm6JB3ujoNn6h2uI9rFRXC+p/HqeQV7ueDx0N26l/Qswh+lieqClIh4WGog7vb1u+dYo8Vqn3DMkbUKTa629Ng69sZ1pNd1Hn04IEisdl34qz0d8X6O64aXvHD22EydapIU1Id0R5j0fnMebzOvVQs+aOzoLw2lB1GmqDXUikm8NZlfAwGQUXk9fGWglT91t1ac2uvzyxOpFDkFPzx9Y0IYy+ckpYPV6BD5H9KTFIHnHx3JaPNe0dPcOwkeUQy9tyVZkJUdCLOr0I/Z6KpC+ebF8/7ASNQs352HvgtF4MUJM63ae7Ev3HrPf6QtFf6iax+YmpqRFRj7MgQ6eQ/OMAlCE0pvWAJLVqxwyL3o7hvO1qO6YGlScznnt/TAwqSkcdksiGv9vdpKiIntUWz+fQ5z5FO39yu2/DTD8MdlpvOBy87SctFRhKHeecziaY5OXRP40Tcauk4ChNsV2KZLtTreuS1IbM29lVo0CaxesAYwsxqtgV98prC9A+CYh7KwvhCYBohPxu0WqLM1TI7CcKZ8vCFP8tJqyFmzKSpWDEL4nppTXmY1dUlwWoyJuwUpoAvm+3lVFoBDs1dCDALQT5gazvvSbGoRZj8L7id9WEtoBQJPuX75H qAJgIKgA xBPXZtGTg83FIiLtH+HWEqpJE9QJx8eIvpAdIwS31S1uaN6THV4o84efRAy8OGUAoJL4HuiBReyStahy9u4E+0zBIizLV+mFVrCWVH7s33mnVgJVjYaSUhR6BbHhpVYKSnWy1MJS9lzjtv6S6x42C5YAGCskMkxP6TWxx4Xet1VJXfvYJa7iAOYUqNgZxVbx80q8AqanVAmh9LiuidnBiaM5kszDKnET/zrYW9LnLOZtVR+IUTpr2b2gV3lOULpu2dCTnuQfksu83UjGRd2u3IZpMXEj1AeLR4HmST8bvHpc36d+lWFevKKdxRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/2/24 1:22 PM, Oscar Salvador wrote: > On Tue, Apr 02, 2024 at 12:26:51PM +0200, Vlastimil Babka wrote: >> Can the migration still fail after __folio_copy_owner()? That goes again to >> the comment you changed in patch 1/3. If it can, this will kinda create a >> mess with the old folio's handles not reflecting reality? (although >> refcounts will be ok) > > According to my research (I replied in patch#1), no, migration cannot > fail after __folio_copy_owner(), so we are safe here (Tm). OK then, Reviewed-by: Vlastimil Babka