From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FB9C433C1 for ; Mon, 22 Mar 2021 14:53:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D8456192E for ; Mon, 22 Mar 2021 14:53:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D8456192E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B425D6B00D0; Mon, 22 Mar 2021 10:35:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF2B66B00D3; Mon, 22 Mar 2021 10:35:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944096B00DE; Mon, 22 Mar 2021 10:35:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 74A676B00D0 for ; Mon, 22 Mar 2021 10:35:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D5FFF87F3 for ; Mon, 22 Mar 2021 14:53:51 +0000 (UTC) X-FDA: 77947804662.07.0C31F3A Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf29.hostedemail.com (Postfix) with ESMTP id BCCDB3E1 for ; Mon, 22 Mar 2021 14:52:38 +0000 (UTC) IronPort-SDR: HsTlJ6qLxH728OX47ceKN2sQm0yuB7agREx21P6GUUlkhRxxMp+lI/UrCLR66ZhRlK7/9occhx TiUP+kiC6Chw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="190380056" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="190380056" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 07:52:31 -0700 IronPort-SDR: AcDswo0o5vJUZRQnv7Qgq4FfRiJvce9xEXN0iZXavHHDTiu8NLkg8XL3qJb8K0JAMd3q/9W2Pq cGiyP/W0DPkQ== X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="390502622" Received: from xzhan86-mobl.amr.corp.intel.com (HELO [10.209.39.64]) ([10.209.39.64]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 07:52:30 -0700 Subject: Re: [PATCH v23 07/28] x86/mm: Remove _PAGE_DIRTY from kernel RO pages To: "Kirill A. Shutemov" Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Christoph Hellwig References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-8-yu-cheng.yu@intel.com> <20210322091351.ulemcluuhqkzuwkm@box> From: "Yu, Yu-cheng" Message-ID: <81fa71ee-3b0b-b959-b8c2-19e1a5adc4c4@intel.com> Date: Mon, 22 Mar 2021 07:52:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322091351.ulemcluuhqkzuwkm@box> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: kn84sx7q5sw56gm9ribq139yaxg34fbz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BCCDB3E1 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mga09.intel.com; client-ip=134.134.136.24 X-HE-DKIM-Result: none/none X-HE-Tag: 1616424758-255492 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/22/2021 2:13 AM, Kirill A. Shutemov wrote: > On Tue, Mar 16, 2021 at 08:10:33AM -0700, Yu-cheng Yu wrote: >> The x86 family of processors do not directly create read-only and Dirty >> PTEs. These PTEs are created by software. One such case is that kernel >> read-only pages are historically setup as Dirty. >> >> New processors that support Shadow Stack regard read-only and Dirty PTEs as >> shadow stack pages. This results in ambiguity between shadow stack and >> kernel read-only pages. To resolve this, removed Dirty from kernel read- >> only pages. >> >> Signed-off-by: Yu-cheng Yu >> Cc: "H. Peter Anvin" >> Cc: Kees Cook >> Cc: Thomas Gleixner >> Cc: Dave Hansen >> Cc: Christoph Hellwig >> Cc: Andy Lutomirski >> Cc: Ingo Molnar >> Cc: Borislav Petkov >> Cc: Peter Zijlstra > > Looks good to me. > > Reviewed-by: Kirill A. Shutemov > Thanks for reviewing. Yu-cheng