From: Gavin Shan <gshan@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
shan.gavin@gmail.com, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v3 2/4] mm/page_reporting: Export reporting order as module parameter
Date: Fri, 25 Jun 2021 11:54:03 +1000 [thread overview]
Message-ID: <8248d291-e06f-fd59-113b-e963ad14ecf8@redhat.com> (raw)
In-Reply-To: <20210624150033-mutt-send-email-mst@kernel.org>
On 6/25/21 5:02 AM, Michael S. Tsirkin wrote:
> On Thu, Jun 24, 2021 at 06:55:13AM -0700, Alexander Duyck wrote:
>> On Tue, Jun 22, 2021 at 5:34 PM Gavin Shan <gshan@redhat.com> wrote:
>>>
>>> The macro PAGE_REPORTING_MIN_ORDER is defined as the page reporting
>>> threshold. It can't be adjusted at runtime.
>>>
>>> This introduces a variable (@page_reporting_order) to replace the
>>> marcro (PAGE_REPORTING_MIN_ORDER). It's also exported so that the
>>> page reporting order can be adjusted at runtime.
>>>
>>> Suggested-by: David Hildenbrand <david@redhat.com>
>>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>>> ---
>>> Documentation/admin-guide/kernel-parameters.txt | 6 ++++++
>>> mm/page_reporting.c | 8 ++++++--
>>> mm/page_reporting.h | 5 ++---
>>> 3 files changed, 14 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>>> index cb89dbdedc46..566c4b9af3cd 100644
>>> --- a/Documentation/admin-guide/kernel-parameters.txt
>>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>>> @@ -3566,6 +3566,12 @@
>>> off: turn off poisoning (default)
>>> on: turn on poisoning
>>>
>>> + page_reporting.page_reporting_order=
>>> + [KNL] Minimal page reporting order
>>> + Format: <integer>
>>> + Adjust the minimal page reporting order. The page
>>> + reporting is disabled when it exceeds (MAX_ORDER-1).
>>> +
>>
>> Based on the issue found by Stephen I think we may need to tweak this
>> a bit. I think we may want to just default this value to MAX_ORDER. We
>> can override this value at registration time with the value provided
>> either by the reporting device or pageblock_order if prdev->order is
>> not set.
>>
>>> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
>>> index df9c5054e1b4..293a8713ef7c 100644
>>> --- a/mm/page_reporting.c
>>> +++ b/mm/page_reporting.c
>>> @@ -10,6 +10,10 @@
>>> #include "page_reporting.h"
>>> #include "internal.h"
>>>
>>> +unsigned int page_reporting_order = pageblock_order;
>>
>> Rather than setting this to pageblock_order directly you can set this
>> to MAX_ORDER which should be constant. Then we can just add some
>> checks in page_reporting_register to update it when pageblock_order is
>> less than page_reporting_order.
>>
>> Then in the next patch you could tweak it so that it will use
>> "prdev->order ? : pageblock_order" instead of just pageblock_order.
>
> I like that! Much cleaner ... the patch is in -mm now, I think it's a
> good idea to drop it and update to use this idea.
>
Thanks, Alex and Michael. v4 was posted to include the changes. Besides,
"module.h" is missed in page_reporting.c as Andrew found. All the changes
are squeezed to PATCH[2] and PATCH[3].
Andrew, could you help to replace the patches with v4 in linux-mm tree?
Sorry for work to you :)
Thanks,
Gavin
next prev parent reply other threads:[~2021-06-24 23:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 2:34 [PATCH v3 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size Gavin Shan
2021-06-23 0:52 ` Alexander Duyck
2021-06-23 2:34 ` [PATCH v3 1/4] mm/page_reporting: Fix code style in __page_reporting_request() Gavin Shan
2021-06-23 2:34 ` [PATCH v3 2/4] mm/page_reporting: Export reporting order as module parameter Gavin Shan
2021-06-24 13:55 ` Alexander Duyck
2021-06-24 19:02 ` Michael S. Tsirkin
2021-06-25 1:54 ` Gavin Shan [this message]
2021-06-23 2:34 ` [PATCH v3 3/4] mm/page_reporting: Allow driver to specify reporting order Gavin Shan
2021-06-23 2:34 ` [PATCH v3 4/4] virtio_balloon: Specify page reporting order if needed Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8248d291-e06f-fd59-113b-e963ad14ecf8@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).