From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Oscar Salvador <osalvador@suse.de>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH RFC 2/2] mm/memory_hotplug: handle memblocks only with CONFIG_ARCH_KEEP_MEMBLOCK
Date: Tue, 21 Apr 2020 14:41:41 +0200 [thread overview]
Message-ID: <82cd6dc0-eae9-3909-063e-e3fb4f0c8a9a@redhat.com> (raw)
In-Reply-To: <20200421123953.GF27314@dhcp22.suse.cz>
>> For s390x, it seems to be fairly easy to avoid CONFIG_ARCH_KEEP_MEMBLOCK.
>> arm64 could rework most code (esp., pfn_valid(), valid_phys_addr_range()
>> and kexec_file_load()) to not require memblocks for hotplugged
>> memory. E.g., as hotplugged memory has no holes and can be identified
>> using !early_section(), arm64's variant of pfn_valid() could be reworked
>> fairly easily to not require memblocks for hotadded memory. powerpc might
>> be more involed.
>
> I haven't checked these architectures but is the information really
> useful for this patch?
It might of interest for Arm64 people (cced below). I sent out s390x
patches to change that.
I can drop that part.
>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Michal Hocko <mhocko@kernel.org>
>> Cc: Baoquan He <bhe@redhat.com>
>> Cc: Oscar Salvador <osalvador@suse.de>
>> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
>> Cc: Mike Rapoport <rppt@linux.ibm.com>
>> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> with a minor nit
>
>> - /*
>> - * Add new range to memblock so that when hotadd_new_pgdat() is called
>> - * to allocate new pgdat, get_pfn_range_for_nid() will be able to find
>> - * this new range and calculate total pages correctly. The range will
>> - * be removed at hot-remove time.
>> - */
>> +#ifdef CONFIG_ARCH_KEEP_MEMBLOCK
>
> if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)
>
> would be slightly nicer. This should work for all the ifedefs in this
> patch.
Yeah, will change if it compiles.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-04-21 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 10:47 [PATCH RFC 0/2] mm/memory_hotplug: handle memblocks only with CONFIG_ARCH_KEEP_MEMBLOCK David Hildenbrand
2020-04-16 10:47 ` [PATCH RFC 1/2] mm/memory_hotplug: no need to init new pgdat with node_start_pfn David Hildenbrand
2020-04-16 14:11 ` Pankaj Gupta
2020-04-21 12:30 ` Michal Hocko
2020-04-21 12:35 ` David Hildenbrand
2020-04-21 12:52 ` Michal Hocko
2020-04-21 13:06 ` David Hildenbrand
2020-04-22 8:21 ` Michal Hocko
2020-04-22 8:32 ` David Hildenbrand
2020-04-22 10:00 ` Michal Hocko
2020-04-16 10:47 ` [PATCH RFC 2/2] mm/memory_hotplug: handle memblocks only with CONFIG_ARCH_KEEP_MEMBLOCK David Hildenbrand
2020-04-16 17:09 ` Mike Rapoport
2020-04-21 12:39 ` Michal Hocko
2020-04-21 12:41 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82cd6dc0-eae9-3909-063e-e3fb4f0c8a9a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pankaj.gupta.linux@gmail.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).