From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82513C433E1 for ; Thu, 9 Jul 2020 13:59:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EB9F2074B for ; Thu, 9 Jul 2020 13:59:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="coM9AtJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EB9F2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B1A36B0005; Thu, 9 Jul 2020 09:59:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 963006B0006; Thu, 9 Jul 2020 09:59:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A14B6B0007; Thu, 9 Jul 2020 09:59:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 763316B0005 for ; Thu, 9 Jul 2020 09:59:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3A4AA2480 for ; Thu, 9 Jul 2020 13:59:01 +0000 (UTC) X-FDA: 77018693682.21.birds81_430c13226ec6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 0D714180442CE for ; Thu, 9 Jul 2020 13:59:01 +0000 (UTC) X-HE-Tag: birds81_430c13226ec6 X-Filterd-Recvd-Size: 4789 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 13:59:00 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id q74so2432744iod.1 for ; Thu, 09 Jul 2020 06:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ttUciq1R4DLXwSrCKOG8sMg2/ZhVL4qipuIgKqQy2hE=; b=coM9AtJu0ST+XR8OMgywQuHtTrKC9/b3RSDkB5xLiy4QzbX3T0Aw61rbH1CahgBBuR uHGxD5IVaENFxujEI50kNZMa4M546fERlVcPXVLx0073TNTIByYun/g+RHhX1WEDPk90 nLVTJFCuIlptJdGLVxMiS/3WV+WEeYk/uPnJy7GYNSE5TcqY5Sk+XRfP9o7wxQhjTuBd OfxdrSK1xj7iSzi0tqotyg0P0tyJIhgxoopV77fateMyHS2NoNRk3u2YMgfEUz9jt+Mx I7oNOyQ+dlAawprLARe5BTTjR91BKrEJGHW7LfKtefXB0VFKSsrdcDKI81gtPbkU0jfv Jz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ttUciq1R4DLXwSrCKOG8sMg2/ZhVL4qipuIgKqQy2hE=; b=gnQc7ikhsDK22SJiXMorXJOXFeHwje3vbjUdqfyRqnSJslZyC6ZHCl5g9+5SL31BSM KxIPw28Ms+FO6aPyW5+gQLx+28H/Jm1lsEtJJyzUyEOCEN1qXISzo7+r2wPKMoX9EGBJ 6DyJ1e0QA22uIj89c6j3i1GTcapE/ESzbtO1HH6CjVMy0FFbYaEMxGXV0mu+MRY6tHTk ++VRlOsihVk3Iipgw8cLUUAirsC5IztGzTX6kwDmj+hSVxRy1jul60M7A2CJadwcKXSj 6h7XlWHG/6jXbXl1AR6b8E2qikrUi9RO5n1ZxJ3kwGXlFo20PKf84FTtNGLtMwmW8XZs i59g== X-Gm-Message-State: AOAM533Lj3xrA5vYgLUNn+pd8Zo0O0yrUah4oc6HiLExgnerhyY6FPN2 yibBuKyEmilEUWpuygzn9hSogg== X-Google-Smtp-Source: ABdhPJwILxLSUCxDdCac/fZUN7tHM3l14dJ0zrZ6D/Tc1v+OsXoh2HYNZYg6WBqjtOr30hdwGoEJQw== X-Received: by 2002:a05:6638:168e:: with SMTP id f14mr67991477jat.64.1594303139999; Thu, 09 Jul 2020 06:58:59 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a1sm1884363ilq.50.2020.07.09.06.58.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2020 06:58:59 -0700 (PDT) Subject: Re: remove dead bdi congestion leftovers To: Christoph Hellwig Cc: Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> From: Jens Axboe Message-ID: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> Date: Thu, 9 Jul 2020 07:58:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709053233.GA3243@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 0D714180442CE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/8/20 11:32 PM, Christoph Hellwig wrote: > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: >>> Hi Jens, >>> >>> we have a lot of bdi congestion related code that is left around with= out >>> any use. This series removes it in preparation of sorting out the bd= i >>> lifetime rules properly. >> >> Please run series like this through a full compilation, for both this = one >> and the previous series I had to fix up issues like this: >> >> drivers/md/bcache/request.c: In function =E2=80=98bch_cached_dev_reque= st_init=E2=80=99: >> drivers/md/bcache/request.c:1233:18: warning: unused variable =E2=80=98= g=E2=80=99 [-Wunused-variable] >> 1233 | struct gendisk *g =3D dc->disk.disk; >> | ^ >> drivers/md/bcache/request.c: In function =E2=80=98bch_flash_dev_reques= t_init=E2=80=99: >> drivers/md/bcache/request.c:1320:18: warning: unused variable =E2=80=98= g=E2=80=99 [-Wunused-variable] >> 1320 | struct gendisk *g =3D d->disk; >> | ^ >> >> Did the same here, applied it. >=20 > And just like the previous one I did, and the compiler did not complain= . > There must be something about certain gcc versions not warning about > variables that are initialized but not otherwise used. Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit these cases for me, not sure why gcc-10 doesn't. And the ones quoted above are about as trivial as they can get. --=20 Jens Axboe