From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MISSING_HEADERS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B18C43460 for ; Fri, 9 Apr 2021 16:03:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB5F36115C for ; Fri, 9 Apr 2021 16:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB5F36115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5708B6B006C; Fri, 9 Apr 2021 12:03:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9DF6B006E; Fri, 9 Apr 2021 12:03:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34BEF6B0070; Fri, 9 Apr 2021 12:03:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 13C2E6B006C for ; Fri, 9 Apr 2021 12:03:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C330F1802EAAD for ; Fri, 9 Apr 2021 16:03:56 +0000 (UTC) X-FDA: 78013299672.20.B7E9A00 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf04.hostedemail.com (Postfix) with ESMTP id E38053C3 for ; Fri, 9 Apr 2021 16:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617984235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l/YtRHbaNxAvJJBbIoYtFy0sDOmcZWRbIs4MjOEQB/k=; b=iq9BVXcuU72lFl+fz8yERc5XRuVhCy8038KMlGqCech/kfUrQBW8x/b0KwFIukQUbSfETC xOyQs/WhFFFrUf36+yGqNHNAyD+EczbIqmWbR+IsoLdLPrGpagOP6S/i7clkdbJOARsxVX xYNVcjIuDQldjVccuh8Po/f8ar5/beA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-VKd9VOlPMEOH6PW381t7Pg-1; Fri, 09 Apr 2021 12:03:50 -0400 X-MC-Unique: VKd9VOlPMEOH6PW381t7Pg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54C20801814; Fri, 9 Apr 2021 16:03:48 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-119-35.rdu2.redhat.com [10.10.119.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id E36435C1D5; Fri, 9 Apr 2021 16:03:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <625171.1617971734@warthog.procyon.org.uk> References: <625171.1617971734@warthog.procyon.org.uk> <20210409111636.GR2531743@casper.infradead.org> <161796595714.350846.1547688999823745763.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Matthew Wilcox , torvalds@linux-foundation.org, Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jlayton@kernel.org, hch@lst.de, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <838189.1617984218.1@warthog.procyon.org.uk> Date: Fri, 09 Apr 2021 17:03:38 +0100 Message-ID: <838190.1617984218@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E38053C3 X-Stat-Signature: 8z9ihpfyryzujkjyyw394y37t6torby3 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617984234-878005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191) > Function old new delta > iomap_write_end_inline - 128 +128 I can get rid of the iomap_write_end_inline() increase for my config by marking it __always_inline, thereby getting: add/remove: 1/2 grow/shrink: 15/15 up/down: 280/-530 (-250) It seems that the decision whether or not to inline iomap_write_end_inline() is affected by the switch to bool. David