Re: [PATCH] mm, page_alloc: avoid page_to_pfn() in move_freepages()

[David Hildenbrand <david@redhat.com>]

> -	start_pfn = page_to_pfn(page);
> -	start_pfn = start_pfn & ~(pageblock_nr_pages-1);
> -	start_page = pfn_to_page(start_pfn);
> -	end_page = start_page + pageblock_nr_pages - 1;
> +	pfn = page_to_pfn(page);
> +	start_pfn = pfn & ~(pageblock_nr_pages-1);

please add spaces around the "-" ("pageblock_nr_pages - 1")

>  	end_pfn = start_pfn + pageblock_nr_pages - 1;
>  
>  	/* Do not cross zone boundaries */
>  	if (!zone_spans_pfn(zone, start_pfn))
> -		start_page = page;
> +		start_pfn = pfn;
>  	if (!zone_spans_pfn(zone, end_pfn))
>  		return 0;
>  
> -	return move_freepages(zone, start_page, end_page, migratetype,
> +	return move_freepages(zone, start_pfn, end_pfn, migratetype,
>  								num_movable);
>  }
>  
> 

In general, this looks good to me (also as a pure cleanup). But there is
still a discussion going on if this is a bugfix or not, so I hold back
and rb/acks - especially as it might need a patch description update ;)

-- 
Thanks,

David / dhildenb