From: David Laight <David.Laight@ACULAB.COM>
To: 'Kefeng Wang' <wangkefeng.wang@huawei.com>,
Marco Elver <elver@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "glider@google.com" <glider@google.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"jannh@google.com" <jannh@google.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>,
"hdanton@sina.com" <hdanton@sina.com>
Subject: RE: [PATCH v2 2/3] kfence: maximize allocation wait timeout duration
Date: Thu, 16 Sep 2021 15:45:16 +0000 [thread overview]
Message-ID: <858909f98f33478891056a840ad68b9f@AcuMS.aculab.com> (raw)
In-Reply-To: <abd74d5a-1236-4f0e-c123-a41e56e22391@huawei.com>
From: Kefeng Wang
> Sent: 16 September 2021 02:21
>
> We found kfence_test will fails on ARM64 with this patch with/without
> CONFIG_DETECT_HUNG_TASK,
>
> Any thought ?
>
...
> >> /* Enable static key, and await allocation to happen. */
> >> static_branch_enable(&kfence_allocation_key);
> >> - wait_event_timeout(allocation_wait, atomic_read(&kfence_allocation_gate), HZ);
> >> + if (sysctl_hung_task_timeout_secs) {
> >> + /*
> >> + * During low activity with no allocations we might wait a
> >> + * while; let's avoid the hung task warning.
> >> + */
> >> + wait_event_timeout(allocation_wait, atomic_read(&kfence_allocation_gate),
> >> + sysctl_hung_task_timeout_secs * HZ / 2);
> >> + } else {
> >> + wait_event(allocation_wait, atomic_read(&kfence_allocation_gate));
> >> + }
> >> /* Disable static key and reset timer. */
> >> static_branch_disable(&kfence_allocation_key);
It has replaced a wait_event_timeout() with a wait_event().
That probably isn't intended.
Although I'd expect their to be some test for the wait being
signalled or timing out.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-09-16 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 10:51 [PATCH v2 0/3] kfence: optimize timer scheduling Marco Elver
2021-04-21 10:51 ` [PATCH v2 1/3] kfence: await for allocation using wait_event Marco Elver
2021-04-21 10:51 ` [PATCH v2 2/3] kfence: maximize allocation wait timeout duration Marco Elver
2021-09-16 1:02 ` Kefeng Wang
2021-09-16 1:20 ` Kefeng Wang
2021-09-16 8:49 ` Marco Elver
2021-09-18 8:07 ` Liu Shixin
2021-09-18 9:37 ` Marco Elver
2021-09-18 9:45 ` Marco Elver
2021-09-16 15:45 ` David Laight [this message]
2021-09-16 15:48 ` Marco Elver
2021-04-21 10:51 ` [PATCH v2 3/3] kfence: use power-efficient work queue to run delayed work Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858909f98f33478891056a840ad68b9f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hdanton@sina.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).