From: David Hildenbrand <david@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Mike Rapoport <rppt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Michal Hocko <mhocko@suse.com>, Feng Tang <feng.tang@intel.com>,
Don Zickus <dzickus@redhat.com>,
x86@kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE
Date: Wed, 21 Apr 2021 22:56:06 +0200 [thread overview]
Message-ID: <866b3f40-9416-0246-cf0a-6f46e9abd9bf@redhat.com> (raw)
In-Reply-To: <m1eef3qx2i.fsf@fess.ebiederm.org>
On 21.04.21 21:03, Eric W. Biederman wrote:
> David Hildenbrand <david@redhat.com> writes:
>
>> Stumbling over the history of MAP_EXECUTABLE, I noticed that we still
>> have some in-tree users that we can get rid of.
>>
>> A good fit for the whole series could be Andrew's tree.
>
> In general this looks like a good cleanup.
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> As far as I can see we can go after MAP_DENYWRITE the same way.
> Today deny_write_access in open_exec is what causes -ETXTBSY
> when attempting to write to file that is current executing.
>
> Do you have any plans to look at that?
I did have a look and thought about ripping out MAP_DENYWRITE; I'm still
in the process of connecting the pieces.
Some VM_DENYWRITE e.g., in mm/khugepaged.c still gives me a headache ,
and I'll have to double-check whether it would be okay to just fallback
on checking the actual vm->file.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-04-21 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 9:34 [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE David Hildenbrand
2021-04-21 9:34 ` [PATCH v1 1/3] perf: MAP_EXECUTABLE does not indicate VM_MAYEXEC David Hildenbrand
2021-04-21 9:34 ` [PATCH v1 2/3] binfmt: remove in-tree usage of MAP_EXECUTABLE David Hildenbrand
2021-05-12 13:12 ` David Hildenbrand
2021-04-21 9:34 ` [PATCH v1 3/3] mm: ignore MAP_EXECUTABLE in ksys_mmap_pgoff() David Hildenbrand
2021-04-21 19:03 ` [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE Eric W. Biederman
2021-04-21 19:21 ` Kees Cook
2021-04-21 20:56 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=866b3f40-9416-0246-cf0a-6f46e9abd9bf@redhat.com \
--to=david@redhat.com \
--cc=Kevin.Brodsky@arm.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=gerg@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).