From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBA7C10F00 for ; Fri, 6 Mar 2020 16:03:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D34A21D56 for ; Fri, 6 Mar 2020 16:03:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D34A21D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 371326B0003; Fri, 6 Mar 2020 11:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 321296B0006; Fri, 6 Mar 2020 11:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 210366B0007; Fri, 6 Mar 2020 11:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 0753C6B0003 for ; Fri, 6 Mar 2020 11:03:55 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B0A4E45BC for ; Fri, 6 Mar 2020 16:03:54 +0000 (UTC) X-FDA: 76565408388.12.straw89_5c4db5d427b1e X-HE-Tag: straw89_5c4db5d427b1e X-Filterd-Recvd-Size: 3347 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Mar 2020 16:03:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CF114B1F3; Fri, 6 Mar 2020 16:03:51 +0000 (UTC) Subject: Re: [PATCH v7 6/7] mm/madvise: employ mmget_still_valid for write lock To: Oleksandr Natalenko Cc: Minchan Kim , Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Jann Horn , alexander.h.duyck@linux.intel.com, sj38.park@gmail.com References: <20200302193630.68771-1-minchan@kernel.org> <20200302193630.68771-7-minchan@kernel.org> <20200306130303.kztv64f52qknxb6k@butterfly.localdomain> From: Vlastimil Babka Message-ID: <86fc8d7b-ad6b-1691-b022-025d01e9e8e3@suse.cz> Date: Fri, 6 Mar 2020 17:03:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200306130303.kztv64f52qknxb6k@butterfly.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/6/20 2:03 PM, Oleksandr Natalenko wrote: > Hello. > > On Fri, Mar 06, 2020 at 01:52:07PM +0100, Vlastimil Babka wrote: >> > diff --git a/mm/madvise.c b/mm/madvise.c >> > index e794367f681e..e77c6c1fad34 100644 >> > --- a/mm/madvise.c >> > +++ b/mm/madvise.c >> > @@ -1118,6 +1118,8 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, >> > if (write) { >> > if (down_write_killable(&mm->mmap_sem)) >> > return -EINTR; >> > + if (current->mm != mm && !mmget_still_valid(mm)) >> > + goto skip_mm; >> >> This will return 0, is that correct? Shoudln't there be a similar error e.g. as >> when finding the task by pid fails (-ESRCH ?), because IIUC the task here is >> going away and dumping the core? > > Yeah. > > Something like this then: > > === > diff --git a/mm/madvise.c b/mm/madvise.c > index 48d1da08c160..7ed2f4d13924 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1122,6 +1122,10 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, > if (write) { > if (down_write_killable(&mm->mmap_sem)) > return -EINTR; > + if (current->mm != mm && !mmget_still_valid(mm)) { > + error = -ESRCH; > + goto skip_mm; > + } > } else { > down_read(&mm->mmap_sem); > } > @@ -1173,6 +1177,7 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, > } > out: > blk_finish_plug(&plug); > +skip_mm: > if (write) > up_write(&mm->mmap_sem); > else > > === > > ? Yep, thanks.