From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D42C433E2 for ; Wed, 16 Sep 2020 01:40:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2716020936 for ; Wed, 16 Sep 2020 01:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2716020936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83594900008; Tue, 15 Sep 2020 21:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E6408E0001; Tue, 15 Sep 2020 21:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC5D900008; Tue, 15 Sep 2020 21:40:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 5953B8E0001 for ; Tue, 15 Sep 2020 21:40:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0E362181AEF15 for ; Wed, 16 Sep 2020 01:40:15 +0000 (UTC) X-FDA: 77267219190.03.bird32_4b00d0527116 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id C24E828A4E8 for ; Wed, 16 Sep 2020 01:40:14 +0000 (UTC) X-HE-Tag: bird32_4b00d0527116 X-Filterd-Recvd-Size: 2926 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 01:40:13 +0000 (UTC) IronPort-SDR: CtQtZLAMX8XoJHnaca5QJVpaZPmisYEjSH6b8iOe5F/71I8b5+J+YCyqFTDVK9wAXgM8zDlXFn xHUlI9Oaoh5A== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="160314694" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="160314694" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 18:40:12 -0700 IronPort-SDR: 9dCQ00xOsaiQN/m1KzC/GDcdx+oY6svWoZFw4Nh2p6ZKe2KWVxmiThlP2XUvdSHcBrsu/onOhm fL9ai3XJkIYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="507812976" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.164]) by fmsmga005.fm.intel.com with ESMTP; 15 Sep 2020 18:40:10 -0700 From: "Huang\, Ying" To: Matthew Wilcox Cc: SeongJae Park , linux-mm@kvack.org, Andrew Morton , "Kirill A . Shutemov" Subject: Re: [PATCH 11/11] mm/vmscan: Allow arbitrary sized pages to be paged out References: <20200908195539.25896-12-willy@infradead.org> <20200915074045.17570-1-sjpark@amazon.com> <20200915125213.GB5449@casper.infradead.org> Date: Wed, 16 Sep 2020 09:40:10 +0800 In-Reply-To: <20200915125213.GB5449@casper.infradead.org> (Matthew Wilcox's message of "Tue, 15 Sep 2020 13:52:13 +0100") Message-ID: <87363its79.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: C24E828A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > On Tue, Sep 15, 2020 at 09:40:45AM +0200, SeongJae Park wrote: >> On Tue, 8 Sep 2020 20:55:38 +0100 "Matthew Wilcox (Oracle)" wrote: >> > Remove the assumption that a compound page has HPAGE_PMD_NR pins from >> > the page cache. >> > >> > Signed-off-by: Matthew Wilcox (Oracle) >> > Cc: Huang Ying > >> > - int page_cache_pins = PageTransHuge(page) && PageSwapCache(page) ? >> > - HPAGE_PMD_NR : 1; >> > + int page_cache_pins = thp_nr_pages(page); >> >> Is it ok to remove the PageSwapCache() check? > > I think so? My understanding is that it was added in commit bd4c82c22c36 > to catch shmem pages, but there was really no reason to only do this for > shmem pages. The original implementation is to write out Anonymous THP (not shmem). The code should work after the changing, because now any THP except normal Anonymous THP in swap cache will be split during reclaiming already. Acked-by: "Huang, Ying" Best Regards, Huang, Ying