From: "Huang\, Ying" <ying.huang@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH -V6 RESEND 1/3] numa balancing: Migrate on fault among multiple bound nodes
Date: Thu, 10 Dec 2020 16:21:25 +0800 [thread overview]
Message-ID: <87a6umjcl6.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <87zh2ulyhc.fsf@yhuang-dev.intel.com> (Ying Huang's message of "Fri, 04 Dec 2020 17:19:43 +0800")
"Huang, Ying" <ying.huang@intel.com> writes:
> Peter Zijlstra <peterz@infradead.org> writes:
>
>> On Wed, Dec 02, 2020 at 11:40:54AM +0000, Mel Gorman wrote:
>>> On Wed, Dec 02, 2020 at 04:42:32PM +0800, Huang Ying wrote:
>>> > Now, NUMA balancing can only optimize the page placement among the
>>> > NUMA nodes if the default memory policy is used. Because the memory
>>> > policy specified explicitly should take precedence. But this seems
>>> > too strict in some situations. For example, on a system with 4 NUMA
>>> > nodes, if the memory of an application is bound to the node 0 and 1,
>>> > NUMA balancing can potentially migrate the pages between the node 0
>>> > and 1 to reduce cross-node accessing without breaking the explicit
>>> > memory binding policy.
>>> >
>>>
>>> Ok, I think this part is ok and while the test case is somewhat
>>> superficial, it at least demonstrated that the NUMA balancing overhead
>>> did not offset any potential benefit
>>>
>>> Acked-by: Mel Gorman <mgorman@suse.de>
>>
>> Who do we expect to merge this, me through tip/sched/core or akpm ?
>
> Hi, Peter,
>
> Per my understanding, this is NUMA balancing related, so could go
> through your tree.
>
> BTW: I have just sent -V7 with some small changes per Mel's latest
> comments.
>
> Hi, Andrew,
>
> Do you agree?
So, what's the conclusion here? Both path works for me. I will update
2/3 per Alejandro Colomar's comments. But that's for man-pages only,
not for kernel. So, we can merge this one into kernel if you think it's
appropriate.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2020-12-10 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 8:42 [PATCH -V6 RESEND 0/3] numa balancing: Migrate on fault among multiple bound nodes Huang Ying
2020-12-02 8:42 ` [PATCH -V6 RESEND 1/3] " Huang Ying
2020-12-02 11:40 ` Mel Gorman
2020-12-03 10:25 ` Peter Zijlstra
2020-12-03 10:53 ` Mel Gorman
2020-12-04 9:19 ` Huang, Ying
2020-12-10 8:21 ` Huang, Ying [this message]
2020-12-02 8:42 ` [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING Huang Ying
2020-12-02 11:43 ` Mel Gorman
2020-12-03 1:49 ` Huang, Ying
2020-12-03 9:37 ` Mel Gorman
2020-12-02 12:33 ` Alejandro Colomar (mailing lists; readonly)
2020-12-08 8:13 ` Huang, Ying
2020-12-18 10:21 ` Alejandro Colomar (mailing lists; readonly)
2020-12-21 1:31 ` Huang, Ying
2020-12-02 8:42 ` [PATCH -V6 RESEND 3/3] NOT kernel/numactl: Support to enable Linux kernel NUMA balancing Huang Ying
2020-12-02 11:45 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6umjcl6.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).