From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11429C34026 for ; Tue, 18 Feb 2020 11:34:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5D6C22527 for ; Tue, 18 Feb 2020 11:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="lUGk1K1L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5D6C22527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74CB36B0003; Tue, 18 Feb 2020 06:34:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D6066B0006; Tue, 18 Feb 2020 06:34:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EA0F6B0007; Tue, 18 Feb 2020 06:34:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 443E56B0003 for ; Tue, 18 Feb 2020 06:34:12 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D5FA98248047 for ; Tue, 18 Feb 2020 11:34:11 +0000 (UTC) X-FDA: 76503039102.07.sand35_5ec26fb156919 X-HE-Tag: sand35_5ec26fb156919 X-Filterd-Recvd-Size: 4205 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 11:34:11 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48MJf55j4Qz9sRf; Tue, 18 Feb 2020 22:34:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1582025646; bh=F7rOX2P8YJfiyqq4A5WbvyfzEZuOiRJVBM5AGIE9VLo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lUGk1K1LgcxxwFvhf4O8QE6CFRz1x1YViE69mhhvpRza/ZauXEIbtfshwLuDoclIF 2UleuHIvpdqQvM/Qzslny2AiXMi7qEf5pyet/3Hd5nJS3BWZ5C05JnhDsibRnJj/fu DboWyESspxGpc4Tp4afiXbLbAWQFzX+lUlZfJ3nR+kWceKghmadYCgEZnbKRRxA3W0 xV/o37WrDkG4yqupn0nBeJjXrwrN5Xcy+Tr+wS4+Zoj5dFzUn+UXQ7i18grsDDI7F7 HkSHyKkwg6MRAxxcCsSj/tGvUMDIDdIV7nTdTb6glkeaCKtKCu/9a5wCl0kVkxhWfF ks1lEvpcuO0Nw== From: Michael Ellerman To: Pingfan Liu , linux-mm@kvack.org Cc: Pingfan Liu , Dan Williams , Michal Hocko , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , David Hildenbrand , Leonardo Bras , Nathan Fontenot , Nathan Lynch Subject: Re: [PATCHv2] mm/sparse: rename pfn_present() as pfn_in_present_section() In-Reply-To: <1581919110-29575-1-git-send-email-kernelfans@gmail.com> References: <1581919110-29575-1-git-send-email-kernelfans@gmail.com> Date: Tue, 18 Feb 2020 22:34:04 +1100 Message-ID: <87a75gf7tf.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Pingfan Liu writes: > After introducing mem sub section concept, pfn_present() loses its literal > meaning, and will not be necessary a truth on partial populated mem section. > > Since all of the callers use it to judge an absent section, it is better to > rename pfn_present() as pfn_in_present_section(). > > Signed-off-by: Pingfan Liu > Cc: Dan Williams > Cc: Michal Hocko > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Leonardo Bras > Cc: Nathan Fontenot > Cc: Nathan Lynch > To: linux-mm@kvack.org > --- > v1 -> v2: adopt David's suggestion, rename it as pfn_in_present_section() > arch/powerpc/platforms/pseries/hotplug-memory.c | 2 +- > drivers/base/node.c | 2 +- > include/linux/mmzone.h | 4 ++-- > mm/page_ext.c | 2 +- > mm/shuffle.c | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c > index a4d40a3..f3ed1ba 100644 > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c > +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c > @@ -360,7 +360,7 @@ static bool lmb_is_removable(struct drmem_lmb *lmb) > > for (i = 0; i < scns_per_block; i++) { > pfn = PFN_DOWN(phys_addr); > - if (!pfn_present(pfn)) { > + if (!pfn_in_present_section(pfn)) { > phys_addr += MIN_MEMORY_BLOCK_SIZE; > continue; > } Fine by me: Acked-by: Michael Ellerman (powerpc) cheers