From: "Huang\, Ying" <ying.huang@intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Minchan Kim <minchan@kernel.org>,
Ross Zwisler <ross.zwisler@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP
Date: Mon, 05 Jun 2017 09:00:42 +0800 [thread overview]
Message-ID: <87a85n1c5h.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170602055759.GC5909@linux.intel.com> (Ross Zwisler's message of "Thu, 1 Jun 2017 23:57:59 -0600")
Ross Zwisler <ross.zwisler@linux.intel.com> writes:
> On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>>
>> The .rw_page in struct block_device_operations is used by the swap
>> subsystem to read/write the page contents from/into the corresponding
>> swap slot in the swap device. To support the THP (Transparent Huge
>> Page) swap optimization, the .rw_page is enhanced to support to
>> read/write THP if possible.
>>
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Minchan Kim <minchan@kernel.org>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Ross Zwisler <ross.zwisler@intel.com>
>> Cc: Vishal L Verma <vishal.l.verma@intel.com>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-nvdimm@lists.01.org
>> ---
>> drivers/block/brd.c | 6 +++++-
>> drivers/block/zram/zram_drv.c | 2 ++
>> drivers/nvdimm/btt.c | 4 +++-
>> drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++-----------
>> 4 files changed, 41 insertions(+), 13 deletions(-)
>
> The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits
> you can add:
>
> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Thanks!
> I think we still want Vishal to make sure that the BTT changes are okay. I
> don't know that code well enough to know whether it's safe to throw 512 pages
> at btt_[read|write]_pg().
>
> Also, Ying, next time can you please CC me (and probably the linux-nvdimm
> list) on the whole series? It would give us more context on what the larger
> change is, allow us to see the cover letter, allow us to test with all the
> patches in the series, etc. It's pretty easy for reviewers to skip over the
> patches we don't care about or aren't in our area.
Sure.
Best Regards,
Huang, Ying
> Thanks,
> - Ross
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-05 1:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 6:46 [PATCH -mm 00/13] mm, THP, swap: Delay splitting THP after swapped out Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 01/13] mm, THP, swap: Support to clear swap cache flag for THP " Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 02/13] mm, THP, swap: Support to reclaim swap space " Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 03/13] mm, THP, swap: Make reuse_swap_page() works " Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 04/13] mm, THP, swap: Don't allocate huge cluster for file backed swap device Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP Huang, Ying
2017-06-02 5:57 ` Ross Zwisler
2017-06-05 1:00 ` Huang, Ying [this message]
2017-05-25 6:46 ` [PATCH -mm 06/13] block: Increase BIO_MAX_PAGES to PMD size if THP_SWAP enabled Huang, Ying
2017-05-25 8:42 ` Ming Lei
2017-05-26 0:56 ` Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 07/13] mm, THP, swap: Support to write THP to swap device as a whole Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 08/13] mm, THP, swap: Support to split THP for THP swapped out Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 09/13] memcg, THP, swap: Support move mem cgroup charge " Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 10/13] memcg, THP, swap: Avoid to duplicated charge THP in swap cache Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 11/13] memcg, THP, swap: Make mem_cgroup_swapout() support THP Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 12/13] mm, THP, swap: Delay splitting THP after swapped out Huang, Ying
2017-05-25 6:46 ` [PATCH -mm 13/13] mm, THP, swap: Add THP swapping out fallback counting Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a85n1c5h.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=minchan@kernel.org \
--cc=ross.zwisler@intel.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).